pinctrl: Show -- for unknown pin levels

It's better to indicate an unknown pin level than treat it as a low,
so show '--' instead.

Make the RP1 gpiochip report an unknown level when the Input Enable is
not set on the pad.

Signed-off-by: Phil Elwell <[email protected]>

Author: pelwell

pinctrl/gpiochip_rp1.c

@@ -338,10 +338,14 @@ static int rp1_gpio_get_level(void *priv, unsigned gpio)
 {
     volatile uint32_t *base = priv;
     int bank, offset;
+    uint32_t pad_reg;
     uint32_t reg;
     int level;
 
     rp1_gpio_get_bank(gpio, &bank, &offset);
+    pad_reg = rp1_gpio_pads_read(base, bank, offset);
+    if (!(pad_reg & RP1_PADS_IE_SET))
+	return -1;
     reg = rp1_gpio_sys_rio_sync_in_read(base, bank, offset);
     level = (reg & (1U << offset)) ? 1 : 0;
 

pinctrl/pinctrl.c

@@ -155,7 +155,7 @@ static int do_gpio_get(unsigned int gpio)
 
     printf(" %s | %s // %s%s%s\n",
            gpio_get_pull_name(gpio_get_pull(gpio)),
-           gpio_get_level(gpio) ? "hi" : "lo",
+           (gpio_get_level(gpio) == 1) ? "hi" : (gpio_get_level(gpio) == 0) ? "lo" : "--",
            name ? name : "",
            name ? " = " : "",
            gpio_get_gpio_fsel_name(gpio, fsel));