pinctrl: Fix the pulls on BCM2712C0

pelwell · pelwell · commit 61e4becfd533 · 2025-02-28T16:31:54.000Z
The pulls for AON GPIOs 32-35 (known to pinctrl as 132-135) were being
looked for in the wrong place. Fix that. D0 escaped because of the
remapping.

Signed-off-by: Phil Elwell &lt;phil@raspberrypi.com&gt;
diff --git a/pinctrl/gpiochip_bcm2712.c b/pinctrl/gpiochip_bcm2712.c
@@ -321,7 +321,7 @@ static volatile uint32_t *bcm2712_pad_base(struct bcm2712_inst *inst,
         return NULL;
     }
 
-    gpio = gpio_offset + inst->pad_offset;
+    gpio += inst->pad_offset;
     *bit = (gpio % 15) * 2;
     return inst->pinmux_base + (gpio / 15);
 }

Original file line number	Diff line number	Diff line change
`@@ -321,7 +321,7 @@ static volatile uint32_t bcm2712_pad_base(struct bcm2712_inst inst,`
`321`	`321`	`return NULL;`
`322`	`322`	`}`
`323`	`323`
`324`		`- gpio = gpio_offset + inst->pad_offset;`
	`324`	`+ gpio += inst->pad_offset;`
`325`	`325`	`bit = (gpio % 15) 2;`
`326`	`326`	`return inst->pinmux_base + (gpio / 15);`
`327`	`327`	`}`