gpiolib: Range-check gpio numbers

pelwell · pelwell · commit d531baf9eed8 · 2023-09-21T15:46:50.000+01:00
Just pretend this check was present from day one.

Signed-off-by: Phil Elwell &lt;phil@raspberrypi.com&gt;
diff --git a/pinctrl/gpiolib.c b/pinctrl/gpiolib.c
@@ -101,7 +101,7 @@ static int gpio_get_interface(unsigned gpio,
 
 int gpio_num_is_valid(unsigned gpio)
 {
-    return !!gpio_names[gpio];
+    return gpio < MAX_GPIO_PINS && !!gpio_names[gpio];
 }
 
 GPIO_DIR_T gpio_get_dir(unsigned gpio)

Original file line number	Diff line number	Diff line change
`@@ -101,7 +101,7 @@ static int gpio_get_interface(unsigned gpio,`
`101`	`101`
`102`	`102`	`int gpio_num_is_valid(unsigned gpio)`
`103`	`103`	`{`
`104`		`- return !!gpio_names[gpio];`
	`104`	`+ return gpio < MAX_GPIO_PINS && !!gpio_names[gpio];`
`105`	`105`	`}`
`106`	`106`
`107`	`107`	`GPIO_DIR_T gpio_get_dir(unsigned gpio)`