Add restrictions to credential overwriting and plug into authentication

Author: rastating

lib/wpxf/core/module_authentication.rb

@@ -39,6 +39,7 @@ def authenticate_with_wordpress(username, password)
         emit_error 'Failed to authenticate with WordPress'
         return false
       else
+        store_credentials username, password
         emit_success 'Authenticated with WordPress', true
         return cookie
       end

lib/wpxf/db/credentials.rb

@@ -7,11 +7,12 @@ module Wpxf::Db::Credentials
   # @param password [String] the password.
   # @param type [String] the type of string stored in the password field.
   # @return [Models::Credential] the newly created {Models::Credential}.
-  def store_credentials(username, password, type = 'plain')
+  def store_credentials(username, password = nil, type = 'plain')
     credential = Models::Credential.first(
       host: target_host,
       port: target_port,
       username: username,
+      password: nil,
       type: type,
       workspace: active_workspace
     )

spec/lib/wpxf/core/module_spec.rb

@@ -14,6 +14,11 @@ def requires_authentication
     end.new
   end
 
+  before :each, 'setup subject' do
+    subject.active_workspace = Models::Workspace.first
+    subject.set_option_value('host', '127.0.0.1')
+  end
+
   describe '#new' do
     it 'registers the verbose option' do
       expect(subject.get_option('verbose')).to_not be_nil
@@ -127,7 +132,7 @@ def requires_authentication
       subject.register_options([opt_a, opt_c])
       subject.payload.register_option(opt_b)
 
-      expect(subject.missing_options).to eq %w(host opt_a opt_b)
+      expect(subject.missing_options).to eq %w[opt_a opt_b]
     end
   end
 
@@ -182,6 +187,13 @@ def requires_authentication
         subject.authenticate_with_wordpress('user', 'pass')
       end
 
+      it 'should store the credentials' do
+        allow(subject).to receive(:wordpress_login).and_return('cookie')
+        subject.authenticate_with_wordpress('user', 'pass')
+        count = Models::Credential.count(username: 'user', password: 'pass')
+        expect(count).to eql 1
+      end
+
       it 'returns the cookie' do
         allow(subject).to receive(:wordpress_login).and_return('cookie')
         res = subject.authenticate_with_wordpress('user', 'pass')

spec/lib/wpxf/db/credentials_spec.rb

@@ -41,18 +41,37 @@
 
     context 'if a record with the same host + username + type already exists' do
       context 'and the record is in the same workspace' do
-        it 'should overwrite the previous credential' do
-          subject.store_credentials 'foo', 'bar', 'test'
-          subject.store_credentials 'foo', 'foo', 'test'
-          expect(Models::Credential.count).to eql 1
+        context 'and has no password' do
+          it 'should overwrite the previous credential' do
+            subject.store_credentials 'foo', nil, 'test'
+            subject.store_credentials 'foo', 'bar', 'test'
+            expect(Models::Credential.count).to eql 1
 
-          credential = Models::Credential.first
-          expect(credential.password).to eql 'foo'
-          Models::Credential.truncate
+            credential = Models::Credential.first
+            expect(credential.password).to eql 'bar'
+            Models::Credential.truncate
 
-          subject.store_credentials 'foo', 'bar', 'unique'
-          subject.store_credentials 'foo', 'foo', 'unique2'
-          expect(Models::Credential.count).to eql 2
+            subject.store_credentials 'foo', 'bar', 'unique'
+            subject.store_credentials 'foo', 'foo', 'unique2'
+            expect(Models::Credential.count).to eql 2
+          end
+        end
+
+        context 'and has a password' do
+          it 'should add a new entry' do
+            Models::Credential.create(
+              host: subject.target_host,
+              port: subject.target_port,
+              username: 'foo',
+              password: 'bar',
+              type: 'plain',
+              workspace: Models::Workspace.first(name: 'default')
+            )
+
+            expect(Models::Credential.count).to eql 1
+            subject.store_credentials 'foo', 'foo'
+            expect(Models::Credential.count).to eql 2
+          end
         end
       end