Fix bug in #normalize_uri causing duplicate slashes

Author: rastating

lib/wpxf/net/http_client.rb

@@ -1,3 +1,5 @@
+require 'uri'
+
 module Wpxf
   module Net
     # Provides HTTP client functionality.
@@ -62,13 +64,11 @@ def target_host
       # @param parts the URI parts to join and normalize.
       # @return [String] a normalized URI.
       def normalize_uri(*parts)
-        uri = parts * '/'
-        uri = uri.gsub(%r{(?<!:)//}, '/')
-        unless uri.start_with?('/') || uri.start_with?('http://') ||
-               uri.start_with?('https://')
-          uri = '/' + uri
-        end
-        uri
+        path = parts * '/'
+        path = '/' + path unless path.start_with?('/', 'http://', 'https://')
+        url = URI.parse(path)
+        url.path.squeeze!('/')
+        url.to_s
       end
 
       # Returns the base URI string.

spec/net/http_client_spec.rb

@@ -268,6 +268,10 @@
     it 'joins each part specified with a forward slash' do
       expect(subject.normalize_uri('a', 'uri', 'path')).to eq '/a/uri/path'
     end
+
+    it 'removes duplicate forward slashes' do
+      expect(subject.normalize_uri('http://localhost/', '/path')).to eq 'http://localhost/path'
+    end
   end
 
   describe '#target_port' do