Address PR review feedback

- Remove eager loading support from LazyImage; use plain img in Authors
- Fix guides landing page detection (handle with/without trailing slash)
- Add build-time error for guides missing title in frontmatter
- Add jobTitle field to authors.json, use it directly instead of regex
- Make proficiencyLevel configurable via frontmatter (default: Intermediate)
- Add proficiencyLevel and keywords to CustomDocFrontMatter type
- Remove unnecessary type casts in Metadata component

Author: ppekrol

docs/authors.json

@@ -2,13 +2,15 @@
     "Paweł Lachowski": {
         "name": "Paweł Lachowski",
         "title": "Technical Writer @ RavenDB",
+        "jobTitle": "Technical Writer",
         "url": null,
         "image_url": "https://ravendb.net/wp-content/uploads/2024/11/Default-author-thumbnail-150x150.png",
         "socials": {}
     },
     "Omer Ratsaby": {
         "name": "Omer Ratsaby",
         "title": "DevOps Engineer @ RavenDB",
+        "jobTitle": "DevOps Engineer",
         "url": null,
         "image_url": "https://ravendb.net/wp-content/uploads/2024/11/Default-author-thumbnail-150x150.png",
         "socials": {}

src/components/Common/LazyImage.tsx

@@ -5,7 +5,6 @@ import ThemedImage, { Props as ThemedImageProps } from "@theme/ThemedImage";
 export interface LazyImageProps extends React.ImgHTMLAttributes<HTMLImageElement> {
     imgSrc?: string | { light: string; dark: string };
     minContentHeight?: number;
-    loading?: "lazy" | "eager";
 }
 
 export default function LazyImage({
@@ -15,7 +14,6 @@ export default function LazyImage({
     className,
     style,
     minContentHeight = 100,
-    loading = "lazy",
     ...props
 }: LazyImageProps) {
     const [isLoaded, setIsLoaded] = useState(false);
@@ -47,7 +45,7 @@ export default function LazyImage({
                 className={clsx(className, "transition-opacity duration-300", !isLoaded ? "opacity-0" : "opacity-100")}
                 onLoad={() => setIsLoaded(true)}
                 onError={() => setIsLoaded(true)}
-                loading={loading}
+                loading="lazy"
             />
         </span>
     );

src/theme/DocItem/Authors/index.tsx

@@ -2,7 +2,6 @@ import React from "react";
 import { useDoc } from "@docusaurus/plugin-content-docs/client";
 import authorsData from "@site/docs/authors.json";
 import { Icon } from "@site/src/components/Common/Icon";
-import LazyImage from "@site/src/components/Common/LazyImage";
 import { IconName } from "@site/src/typescript/iconName";
 
 type Platform = "x" | "github" | "linkedin" | "email";
@@ -80,13 +79,7 @@ export default function DocItemAuthors() {
             {author && (
                 <div className="docAuthor">
                     {author.imageURL && (
-                        <LazyImage
-                            src={author.imageURL}
-                            alt={author.name}
-                            className="docAuthorImg"
-                            minContentHeight={32}
-                            loading="eager"
-                        />
+                        <img src={author.imageURL} alt={author.name} className="docAuthorImg" loading="eager" />
                     )}
                     <div>
                         <div className="docAuthorName">

src/theme/DocItem/Metadata/index.tsx

@@ -25,14 +25,21 @@ export default function MetadataWrapper(props: Props): ReactNode {
         canonicalUrl = canonicalUrl.concat("/");
     }
 
-    const isGuide = permalink.startsWith("/guides/") && !permalink.endsWith("/guides/");
-    const description = metadata.description || (frontMatter.description as string) || "";
+    const guidesLandingPaths = ["/guides", "/guides/"];
+    const isGuide = permalink.startsWith("/guides/") && !guidesLandingPaths.includes(permalink);
+    const description = metadata.description || frontMatter.description || "";
+
+    if (isGuide && !metadata.title) {
+        throw new Error(`Guide "${permalink}" is missing a required "title" in frontmatter.`);
+    }
+
     const title = metadata.title || "";
 
-    const authorKey = frontMatter.author as string | undefined;
+    const authorKey = frontMatter.author;
     const authorInfo = authorKey ? authorsData[authorKey as keyof typeof authorsData] : null;
-    const publishedAt = frontMatter.publishedAt as string | undefined;
-    const keywords = frontMatter.keywords as string[] | undefined;
+    const publishedAt = frontMatter.publishedAt;
+    const keywords = frontMatter.keywords;
+    const proficiencyLevel = frontMatter.proficiencyLevel || "Intermediate";
 
     const ogImageUrl = `${baseUrl}/img/social-card.jpg`;
 
@@ -60,9 +67,9 @@ export default function MetadataWrapper(props: Props): ReactNode {
                                 "@type": "Person",
                                 name: authorInfo.name,
                                 ...(authorInfo.url ? { url: authorInfo.url } : {}),
-                                ...(authorInfo.title
+                                ...(authorInfo.jobTitle
                                     ? {
-                                          jobTitle: authorInfo.title.replace(/ @ .*$/, ""),
+                                          jobTitle: authorInfo.jobTitle,
                                           worksFor: {
                                               "@type": "Organization",
                                               name: "RavenDB",
@@ -79,7 +86,7 @@ export default function MetadataWrapper(props: Props): ReactNode {
                       url: "https://ravendb.net",
                       logo: { "@type": "ImageObject", url: ogImageUrl },
                   },
-                  proficiencyLevel: "Intermediate",
+                  proficiencyLevel,
               })
             : null;
 

src/typescript/docMetadata.d.ts

@@ -10,6 +10,8 @@ export interface CustomDocFrontMatter extends DocFrontMatter {
     icon?: IconName;
     image?: string | { light: string; dark: string };
     publishedAt?: string;
+    proficiencyLevel?: string;
+    keywords?: string[];
 }
 
 type CustomDocContextValue = Omit<DocContextValue, "frontMatter" | "metadata"> & {