Index: converting string.Join('_' wrong result

[bwmeyer]

As the highlighting of double quotes in the studios index detail is wrong/misleading, I wanted to use single quotes.
So I have changed the call of the string.Join method accordingly.
Unfortunately this will not be correctly converted.

When an index with string.Join character based is created in c# it will be converted to this:
String.Join < string > ('_', ...
instead of
String.Join('_', ...

        [TestMethod]
        public void CreateIndexTest()
        {
            using var store = GetDocumentStore();
            new TestDocIndex().Execute(store);
            var index = store.Maintenance.Send(new GetIndexOperation("TestDocIndex"));
            Assert.IsFalse(index.Maps.First().Contains("String.Join < string > ("));
        }

        public class TestDoc : DocumentBase
        {
            public string Id { get; set; }
            public List<string> Data { get; set; } = new List<string>();
        }

        public class TestDocIndex : AbstractIndexCreationTask<TestDoc>
        {
            public TestDocIndex()
            {
                Map = testDocs => from testDoc in testDocs
                                  select new
                                  {
                                      testDoc.Id,
                                      Data = string.Join('_', testDoc.Data)
                                  };
                StoreAllFields(FieldStorage.Yes);
            }
        }``

[maciejaszyk]

Hi!
I've looked into that and found out it is a bug related to our index builder. I will take a look into that. As a workaround you can use a string as separator instead of char in string.Join and everything works just fine.

Thanks for your feedback.

public class TestDocIndex : AbstractIndexCreationTask<TestDoc>
    {
        public TestDocIndex()
        {
            Map = testDocs => from testDoc in testDocs
                select new
                {
                    testDoc.Id,
                    Data = string.Join("_", testDoc.Data) //or you can use LINQ: testDoc.Data.Aggregate(((s, s1) => $"{s}_{s1}"))
                };
            StoreAllFields(FieldStorage.Yes);
        }
    }

[bwmeyer]

This is what I have done, but the double quotes aren't highlighted well in studio.

[maciejaszyk]

Maybe this will help you.
char.ToString('_')

[arekpalinski]

@bwmeyer Okay so it's just the UI issue, right?

@ml054 please have a look.

[bwmeyer]

Yes, the double quotes is only a UI issue (and was misleading me first)

[ml054]

@bwmeyer I've opened issue for that: https://issues.hibernatingrhinos.com/issue/RavenDB-18542 You can watch this issue to track progress.