Too many clients creations

[dtaalbers]

For a while now I am getting the following warning:

There has been a lot of topology updates (more than 20) for the same client id in less than a minute. Last one from (ip-address) as (id) This is usually an indication that you are creating a large number of DocumentStore instance. Are you creating a Document Store per request, instead of using DocumentStore as a singleton?

I am following the docs by creating a singleton for the Document Store. My guess is because I have a few (about 9) APIs (each on their own domain and azure app service that are using the same database server and also have a few Azure functions running every * minutes, that a Client is created for each API and function runtime? Could the amount of API's and/or theAzure functions be the issue as to why I am getting these warnings?

If so, what approach should I use to fix this warning in my situation? Any help is appreciated.

[ayende]

The way we validate this is the we generate a per client process value.
So multiple processes won't matter.
Are you sure that you are using a singleton? Or are you creating it once per function invocation?

[dtaalbers]

My apologies for the extremely late reply. At the moment the store is created like this in an Azure function (eventGridTrigger).

export class DocumentRepository {

    public session: IDocumentSession;
    private store: DocumentStore;

    constructor(urls: string[], buffer: Buffer, database: string) {        
        // Create a store using the configured settings.
        this.store = new DocumentStore(urls, database, {
            type: 'pfx',
            certificate: buffer
        });
        // We are reading 'PascalCased' data but we want to convert them to 'camelCased' objects.
        this.store.conventions.remoteEntityFieldNameConvention = 'pascal';
        this.store.conventions.entityFieldNameConvention = 'camel';
        // Init the store with our custom settings.
        this.store.initialize();
        // Open the session
        this.session = this.store.openSession();
    }

    public async dispose() {
        this.session.dispose();
        this.store.dispose();
    }
}

const eventGridTrigger: AzureFunction = async function (context: Context, eventGridEvent: any): Promise<void> {
    const buffer = Buffer.from(certificate.value, 'base64');
    const repository = new DocumentRepository([url1, url2, url3], buffer, database);

     ...the rest...
};

export default eventGridTrigger;

So I am guessing this is what you described as creating it once per function invocation? which I think is the wrong way to do it?

[ayende]

You need to do it like this:

// initialize *once* for the lifetime of the process
const store = new DocumentStore(urls, database, {
            type: 'pfx',
            certificate: buffer
        });
// We are reading 'PascalCased' data but we want to convert them to 'camelCased' objects.
store.conventions.remoteEntityFieldNameConvention = 'pascal';
store.conventions.entityFieldNameConvention = 'camel';
store.initialize();

const eventGridTrigger: AzureFunction = async function (context: Context, eventGridEvent: any): Promise<void> {
    const buffer = Buffer.from(certificate.value, 'base64');
    const repository = new DocumentRepository(store);

     ...the rest...
};

export class DocumentRepository {

    public session: IDocumentSession;
    constructor( store: DocumentStore) {        
        this.session = store.openSession();
    }

    public async dispose() {
        this.session.dispose();
    }
}

I'm not sure if the DocumentRepository is a valid object to use in this manner, but you can just move the

[dtaalbers]

Thank you very much! That makes more sense indeed.