[Chore] Fix gosec, govet and errcheck lint issues (#4309)

Signed-off-by: win5923 <[email protected]>
Signed-off-by: Rueian <[email protected]>
Co-authored-by: Rueian <[email protected]>

Author: win5923

.golangci.yml

@@ -14,13 +14,13 @@ linters:
     - unparam
     - unused
     - wastedassign
+    - gosec
+    - govet
+    - errcheck
     - testifylint
     # TODO: The following linters are disabled for now to unblock the golangci-lint v2 migration.
     # We will fix the lint errors and re-enable these linters in follow-up PRs.
     # - noctx
-    # - gosec
-    # - govet
-    # - errcheck
     # - errorlint
     # - revive
     # - staticcheck

experimental/cmd/main.go

@@ -108,8 +108,14 @@ func main() {
 	token := httpproxy.NewTokenAuth(security_token, proxy, secure_prefix, remote)
 	// Create handler
 	http.HandleFunc("/", token.AuthFunc())
-	// Run HTTP proxy
-	err = http.ListenAndServe(":"+http_local_port, nil)
+	// Run HTTP proxy with timeouts
+	server := &http.Server{
+		Addr:         ":" + http_local_port,
+		ReadTimeout:  0, // No timeout
+		WriteTimeout: 0, // No timeout
+		IdleTimeout:  0, // No timeout
+	}
+	err = server.ListenAndServe()
 	if err != nil {
 		klog.Fatal("HTTP server died unexpectedly, error - ", err)
 	}

experimental/pkg/httpproxy/support.go

@@ -12,8 +12,8 @@ import (
 
 type authorization struct {
 	proxy    *httputil.ReverseProxy
-	prefix   string
 	upstream *url.URL
+	prefix   string
 }
 
 // Create Unauthorized response