Test: Add unit test for replica validation.

This is added since we moved the validation logic.

Author: kash2104

ray-operator/controllers/ray/utils/validation_test.go

@@ -395,7 +395,9 @@ func TestValidateRayClusterSpecEmptyContainers(t *testing.T) {
 		Template: podTemplateSpec(nil, nil),
 	}
 	workerGroupSpecWithOneContainer := rayv1.WorkerGroupSpec{
-		Template: podTemplateSpec(nil, nil),
+		Template:    podTemplateSpec(nil, nil),
+		MinReplicas: ptr.To(int32(0)),
+		MaxReplicas: ptr.To(int32(5)),
 	}
 	headGroupSpecWithNoContainers := *headGroupSpecWithOneContainer.DeepCopy()
 	headGroupSpecWithNoContainers.Template.Spec.Containers = []corev1.Container{}
@@ -459,8 +461,10 @@ func TestValidateRayClusterSpecSuspendingWorkerGroup(t *testing.T) {
 		Template: podTemplateSpec(nil, nil),
 	}
 	workerGroupSpecSuspended := rayv1.WorkerGroupSpec{
-		GroupName: "worker-group-1",
-		Template:  podTemplateSpec(nil, nil),
+		GroupName:   "worker-group-1",
+		Template:    podTemplateSpec(nil, nil),
+		MinReplicas: ptr.To(int32(0)),
+		MaxReplicas: ptr.To(int32(5)),
 	}
 	workerGroupSpecSuspended.Suspend = ptr.To(true)
 
@@ -692,8 +696,10 @@ func TestValidateRayClusterSpec_Resources(t *testing.T) {
 			},
 			WorkerGroupSpecs: []rayv1.WorkerGroupSpec{
 				{
-					GroupName: "worker-group",
-					Template:  podTemplateSpec(nil, nil),
+					GroupName:   "worker-group",
+					Template:    podTemplateSpec(nil, nil),
+					MinReplicas: ptr.To(int32(0)),
+					MaxReplicas: ptr.To(int32(5)),
 				},
 			},
 		}
@@ -773,8 +779,10 @@ func TestValidateRayClusterSpec_Labels(t *testing.T) {
 			},
 			WorkerGroupSpecs: []rayv1.WorkerGroupSpec{
 				{
-					GroupName: "worker-group",
-					Template:  podTemplateSpec(nil, nil),
+					GroupName:   "worker-group",
+					Template:    podTemplateSpec(nil, nil),
+					MinReplicas: ptr.To(int32(0)),
+					MaxReplicas: ptr.To(int32(5)),
 				},
 			},
 		}
@@ -2473,3 +2481,83 @@ func TestValidateRayClusterUpgradeOptions(t *testing.T) {
 		})
 	}
 }
+
+func TestValidateRayClusterSpec_WorkerGroupReplicaValidation(t *testing.T) {
+	createSpec := func() rayv1.RayClusterSpec {
+		return rayv1.RayClusterSpec{
+			EnableInTreeAutoscaling: ptr.To(false),
+			HeadGroupSpec: rayv1.HeadGroupSpec{
+				Template: podTemplateSpec(nil, nil),
+			},
+		}
+	}
+
+	tests := []struct {
+		name        string
+		errorMsg    string
+		expectError bool
+		spec        rayv1.RayClusterSpec
+	}{
+		{
+			name: "minReplicas greater than maxReplicas",
+			spec: func() rayv1.RayClusterSpec {
+				s := createSpec()
+				s.WorkerGroupSpecs = []rayv1.WorkerGroupSpec{
+					{
+						GroupName:   "worker-group-3",
+						Template:    podTemplateSpec(nil, nil),
+						MinReplicas: ptr.To(int32(5)),
+						MaxReplicas: ptr.To(int32(3)),
+					},
+				}
+				return s
+			}(),
+			expectError: true,
+			errorMsg:    "worker group worker-group-3 has minReplicas 5 greater than maxReplicas 3",
+		},
+		{
+			name: "replicas smaller than minReplicas when autoscaling disabled",
+			spec: func() rayv1.RayClusterSpec {
+				s := createSpec()
+				s.WorkerGroupSpecs = []rayv1.WorkerGroupSpec{
+					{
+						GroupName:   "worker-group-3",
+						Template:    podTemplateSpec(nil, nil),
+						Replicas:    ptr.To(int32(1)),
+						MinReplicas: ptr.To(int32(2)),
+						MaxReplicas: ptr.To(int32(5)),
+					},
+				}
+				return s
+			}(),
+			expectError: false,
+		},
+		{
+			name: "valid when autoscaling enabled",
+			spec: func() rayv1.RayClusterSpec {
+				s := createSpec()
+				s.EnableInTreeAutoscaling = ptr.To(true)
+				s.WorkerGroupSpecs = []rayv1.WorkerGroupSpec{
+					{
+						GroupName: "worker-group-3",
+						Template:  podTemplateSpec(nil, nil),
+					},
+				}
+				return s
+			}(),
+			expectError: false,
+		},
+	}
+
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			err := ValidateRayClusterSpec(&tt.spec, nil)
+			if tt.expectError {
+				require.Error(t, err)
+				require.EqualError(t, err, tt.errorMsg)
+			} else {
+				require.NoError(t, err)
+			}
+		})
+	}
+}