[Follow Up][Test] Support to set QPS and burst by configuration (#3999)

* [Follow Up][Test] Support to set QPS and burst by configuration

Signed-off-by: Future-Outlier <[email protected]>

* nit

Signed-off-by: Future-Outlier <[email protected]>

* nit

Signed-off-by: Future-Outlier <[email protected]>

---------

Signed-off-by: Future-Outlier <[email protected]>

Author: Future-Outlier

ray-operator/main_test.go

@@ -128,13 +128,15 @@ unknownfield: 1
 			expectErr: false,
 		},
 		{
-			name: "invalid type for field",
+			name: "set QPS and Burst",
 			configData: `apiVersion: config.ray.io/v1alpha1
 kind: Configuration
 metricsAddr: ":8080"
 probeAddr: ":8082"
 enableLeaderElection: true
-reconcileConcurrency: true
+reconcileConcurrency: 1
+qps: 150.5
+burst: 300
 `,
 			expectedConfig: configapi.Configuration{
 				TypeMeta: metav1.TypeMeta{
@@ -144,38 +146,46 @@ reconcileConcurrency: true
 				MetricsAddr:          ":8080",
 				ProbeAddr:            ":8082",
 				EnableLeaderElection: ptr.To(true),
-				ReconcileConcurrency: 0,
-				QPS:                  ptr.To(configapi.DefaultQPS),
-				Burst:                ptr.To(configapi.DefaultBurst),
+				ReconcileConcurrency: 1,
+				QPS:                  ptr.To(150.5),
+				Burst:                ptr.To(300),
 			},
-			expectErr:   true,
-			errContains: "json: cannot unmarshal bool into Go struct field Configuration.reconcileConcurrency of type int",
+			expectErr: false,
 		},
 		{
-			name: "invalid version for config",
-			configData: `apiVersion: config.ray.io/v1beta1
+			name: "set Burst using float",
+			configData: `apiVersion: config.ray.io/v1alpha1
 kind: Configuration
 metricsAddr: ":8080"
 probeAddr: ":8082"
 enableLeaderElection: true
-reconcileConcurrency: true
+reconcileConcurrency: 1
+qps: 150
+burst: 300.5
 `,
 			expectedConfig: configapi.Configuration{
+				TypeMeta: metav1.TypeMeta{
+					Kind:       "Configuration",
+					APIVersion: "config.ray.io/v1alpha1",
+				},
 				MetricsAddr:          ":8080",
 				ProbeAddr:            ":8082",
 				EnableLeaderElection: ptr.To(true),
-				QPS:                  ptr.To(configapi.DefaultQPS),
-				Burst:                ptr.To(configapi.DefaultBurst),
+				ReconcileConcurrency: 1,
+				QPS:                  ptr.To(150.0),
+				Burst:                ptr.To(300),
 			},
 			expectErr:   true,
-			errContains: `no kind "Configuration" is registered for version "config.ray.io/v1beta1" in scheme`,
+			errContains: "json: cannot unmarshal number 300.5 into Go struct field Configuration.burst of type int",
 		},
 		{
-			name: "set QPS and Burst",
-			configData: `apiVersion: config.ray.io/v1beta1
+			name: "invalid type for field",
+			configData: `apiVersion: config.ray.io/v1alpha1
 kind: Configuration
-qps: 150
-burst: 300
+metricsAddr: ":8080"
+probeAddr: ":8082"
+enableLeaderElection: true
+reconcileConcurrency: true
 `,
 			expectedConfig: configapi.Configuration{
 				TypeMeta: metav1.TypeMeta{
@@ -185,12 +195,12 @@ burst: 300
 				MetricsAddr:          ":8080",
 				ProbeAddr:            ":8082",
 				EnableLeaderElection: ptr.To(true),
-				ReconcileConcurrency: 1,
-				QPS:                  ptr.To((150.0)),
-				Burst:                ptr.To(300),
+				ReconcileConcurrency: 0,
+				QPS:                  ptr.To(configapi.DefaultQPS),
+				Burst:                ptr.To(configapi.DefaultBurst),
 			},
 			expectErr:   true,
-			errContains: `no kind "Configuration" is registered for version "config.ray.io/v1beta1" in scheme`,
+			errContains: "json: cannot unmarshal bool into Go struct field Configuration.reconcileConcurrency of type int",
 		},
 		{
 			name: "Set ReconcileConcurrency",