Skip to content

Commit e0360eb

Browse files
pschafhalterpcmoritz
authored andcommitted
Remove UT libraries and clean up remaining UT datastructures (#1230)
* Remove UT string include from redis * Remove UT string include from DB tests * Modify TaskSpec_print to remove UT string * Remove UT libraries
1 parent ae4e1dd commit e0360eb

File tree

8 files changed

+4
-2721
lines changed

8 files changed

+4
-2721
lines changed

src/common/state/redis.cc

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,6 @@ extern "C" {
1111
#include "hiredis/adapters/ae.h"
1212
}
1313

14-
#include "utstring.h"
15-
1614
#include "common.h"
1715
#include "db.h"
1816
#include "db_client_table.h"

src/common/task.h

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,8 @@
44
#include <stddef.h>
55
#include <stdint.h>
66
#include "common.h"
7-
#include "utstring.h"
7+
8+
#include <string>
89

910
#include "format/common_generated.h"
1011

@@ -360,10 +361,9 @@ ObjectID task_compute_put_id(TaskID task_id, int64_t put_index);
360361
* Print the task as a humanly readable string.
361362
*
362363
* @param spec The task_spec in question.
363-
* @param output The buffer to write the string to.
364-
* @return Void.
364+
* @return The humanly readable string.
365365
*/
366-
void TaskSpec_print(TaskSpec *spec, UT_string *output);
366+
std::string TaskSpec_print(TaskSpec *spec);
367367

368368
/**
369369
* Create a copy of the task spec. Must be freed with TaskSpec_free after use.

src/common/test/db_tests.cc

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,6 @@
1515
#include "state/redis.h"
1616
#include "task.h"
1717

18-
#include "utstring.h"
19-
2018
SUITE(db_tests);
2119

2220
TaskBuilder *g_task_builder = NULL;

src/common/thirdparty/utarray.h

Lines changed: 0 additions & 238 deletions
This file was deleted.

0 commit comments

Comments
 (0)