Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion python/requirements_compiled.txt
Original file line number Diff line number Diff line change
Expand Up @@ -221,7 +221,7 @@ black==22.10.0
# via -r python/requirements/lint-requirements.txt
bleach==6.1.0
# via nbconvert
bokeh==2.4.3 ; python_version < "3.12"
bokeh==3.8.2 ; python_version < "3.12"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Source and compiled requirements files are inconsistent

Medium Severity

The PR updates bokeh to 3.8.2 in requirements_compiled.txt but leaves bokeh==2.4.3 in the source file python/requirements/ml/data-requirements.txt. This inconsistency means that regenerating the compiled requirements or installing from the source file directly would result in the old, vulnerable version being installed. The security fix for incomplete WebSocket origin validation (#14768) would be ineffective when using the source requirements file.

🔬 Verification Test

Test code:

# Check source requirements file
grep "bokeh" python/requirements/ml/data-requirements.txt

# Check compiled requirements file  
grep "bokeh==" python/requirements_compiled.txt

Command run:

grep "bokeh" python/requirements/ml/data-requirements.txt && grep "bokeh==" python/requirements_compiled.txt

Output:

bokeh==2.4.3; python_version < '3.12'
bokeh==3.8.2 ; python_version < "3.12"

Why this proves the bug: The output shows that the source file data-requirements.txt specifies version 2.4.3 while the compiled file specifies version 3.8.2, confirming the version mismatch between source and compiled requirements.

Fix in Cursor Fix in Web

# via
# -r python/requirements/ml/data-requirements.txt
# dask
Expand Down