LightningCLI and RayPlugin compatibility (#164)

Proper fix for #151 removing what #154 added.

Author: mauvilsa

.github/workflows/test.yaml

@@ -131,6 +131,7 @@ jobs:
           pushd ray_lightning/tests
           python -m pytest -v --durations=0 -x test_ddp.py
           python -m pytest -v --durations=0 -x test_ddp_sharded.py
+          python -m pytest -v --durations=0 -x test_lightning_cli.py
 
   test_linux_ray_release_2:
     runs-on: ubuntu-latest

ray_lightning/tests/test_lightning_cli.py

@@ -0,0 +1,27 @@
+import pytest
+from importlib.util import find_spec
+from pytorch_lightning.utilities.cli import LightningCLI
+from ray_lightning import RayStrategy
+from ray_lightning.tests.utils import BoringModel
+from unittest import mock
+
+
+@pytest.mark.skipif(
+    not find_spec("jsonargparse"), reason="jsonargparse required")
+def test_lightning_cli_raystrategy_instantiation():
+    init_args = {
+        "num_workers": 4,  # Resolve from RayStrategy.__init__
+        "use_gpu": False,  # Resolve from RayStrategy.__init__
+        "bucket_cap_mb": 50,  # Resolve from DistributedDataParallel.__init__
+    }
+    cli_args = ["--trainer.strategy=RayStrategy"]
+    cli_args += [f"--trainer.strategy.{k}={v}" for k, v in init_args.items()]
+
+    with mock.patch("sys.argv", ["any.py"] + cli_args):
+        cli = LightningCLI(BoringModel, run=False)
+
+    assert isinstance(cli.config_init["trainer"]["strategy"], RayStrategy)
+    assert {
+        k: cli.config["trainer"]["strategy"]["init_args"][k]
+        for k in init_args
+    } == init_args

requirements-test.txt

@@ -11,3 +11,4 @@ torch==1.12.0
 torchmetrics
 torchvision
 protobuf<=3.20.1
+jsonargparse>=4.13.2