Merge pull request #26 from rayanlevert/bugfix/i25

ProgressBar : ArgumentCountError if the title contains percentage

Author: rayanlevert

src/ProgressBar.php

@@ -153,7 +153,10 @@ public function advance(int $toAdvance = 1): void
         }
 
         if ($this->title) {
-            print sprintf(self::UP . self::LEFT . "\33[2K" . $this->title . self::DOWN, 1, 1000, 1);
+            // Escape percentage signs in the title to prevent sprintf errors
+            $escapedTitle = str_replace('%', '%%', $this->title);
+
+            print sprintf(self::UP . self::LEFT . "\33[2K" . $escapedTitle . self::DOWN, 1, 1000, 1);
         }
 
         // Resets the line placing the cursor leftmost + the current iteration / max

tests/ProgressBar/ProgressBarTest.php

@@ -83,6 +83,51 @@ public function startWithTitleDifferentColor(): void
         ob_clean();
     }
 
+    #[Test]
+    public function titleWithSinglePercentageSign(): void
+    {
+        // Test with a single percentage sign
+        new ProgressBar(5)->setTitle('Progress: 50%', Foreground::GREEN)->start();
+
+        $this->assertStringStartsWith(
+            "\n\n\e[1A\e[1000D\33[2K" . Style::stylize("\tProgress: 50%", fg: Foreground::GREEN)
+                . "\e[1B\e[1000D\33[2K\t0 / 5 [     ] 0%",
+            ob_get_contents()
+        );
+
+        ob_clean();
+    }
+
+    #[Test]
+    public function titleWithDoublePercentageSign(): void
+    {
+        // Test with a double percentage sign
+        new ProgressBar(5)->setTitle('Progress: 100%%')->start();
+
+        $this->assertStringStartsWith(
+            "\n\n\e[1A\e[1000D\33[2K" . Style::stylize("\tProgress: 100%%", fg: Foreground::BLUE)
+                . "\e[1B\e[1000D\33[2K\t0 / 5 [     ] 0%",
+            ob_get_contents()
+        );
+
+        ob_clean();
+    }
+
+    #[Test]
+    public function titleWithMultiplePercentageSigns(): void
+    {
+        // Test with multiple percentage signs
+        new ProgressBar(5)->setTitle('Progress: 25% and 75%')->start();
+
+        $this->assertStringStartsWith(
+            "\n\n\e[1A\e[1000D\33[2K" . Style::stylize("\tProgress: 25% and 75%", fg: Foreground::BLUE)
+                . "\e[1B\e[1000D\33[2K\t0 / 5 [     ] 0%",
+            ob_get_contents()
+        );
+
+        ob_clean();
+    }
+
     #[Test]
     public function advanceWithoutStarting(): void
     {