-
Notifications
You must be signed in to change notification settings - Fork 5.4k
[raycastbot] Improve Regex for issue-bot #23870
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Made https:// an optional group for matching to continue even if it's not present
Greptile SummaryThis PR improves the issue bot's regex patterns by making Key changes:
The change is well-implemented with the Confidence Score: 5/5
Important Files Changed
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additional Comments (1)
-
scripts/bots/issue-bot.ts, line 20 (link)logic: Inconsistency:
newMatchGitHubuses a capturing group(https:\/\/)?whilenewMatchon line 18 uses a non-capturing group(?:https:\/\/)?. This creates an off-by-one error in capture groups.When the regex matches, line 63 expects the extension folder in capture group 1, but if
https://is present, it becomes capture group 2.
1 file reviewed, 1 comment
|
Just fixed the regex, oops! greptile check again if you don't mind. |
Greptile's behavior is changing!From now on, if a review finishes with no comments, we will not post an additional "statistics" comment to confirm that our review found nothing to comment on. However, you can confirm that we reviewed your changes in the status check section. This feature can be toggled off in your Code Review Settings by deselecting "Create a status check for each PR". |
|
This pull request has been automatically marked as stale because it did not have any recent activity. It will be closed if no further activity occurs in the next 7 days to keep our backlog clean 😊 |
|
This looks good
|
0xdhrv
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, checking with @pernielsentikaer for another view
Description
Made
https://an optional group for matching to continue even if it's not present (e.g #23602). This change was made on bothnewMatchandnewMatchGitHubas these are the most common formats for issues I've seenScreencast
Checklist
npm run buildand tested this distribution build in Raycastassetsfolder are used by the extension itselfREADMEare located outside the metadata folder if they were not generated with our metadata tool