No method to include READ_PHONE_STATE

[kenargo]

A substate of the Manifest.permission.CALL_PHONE but needed when you only need partial permissions to phone services.

[rayliverified]

Webpage not available body { margin-top: 0px; padding-top: 0px; } /* Used for additional styles, e.g. direction */ h2 { margin-top: 5px; padding-top: 0px; } Hi Kenneth, Thanks for taking a look! If you submit a PR, I'll review and merge it.- Ray

[kenargo]

It appears that the repository is locked; I cannot push the branch with the changes. Or it’s working differently than prior times. I’ve attached the 2 changed files. Note: I’m not handling the fact that CALL_PHONE includes READ_PHONE_STATE. If users want to show descriptions for both or even show both permissions it would be a valid use-case. The code could be overly smart and remove READ_PHONE_STATE if there is no description and both CALL_PHONE and READ_PHONE_STATE but I figure this is more effort than it’s worth. If you disagree, let me know and I’ll add the additional logic. Thanks, Ken From: Ray Li [mailto:notifications@github.com] Sent: Saturday, October 19, 2019 3:06 PM To: searchy2/CustomPermissionsDialogue <CustomPermissionsDialogue@noreply.github.com> Cc: Kenneth A. Argo <kenargo@kenargo.com>; Author <author@noreply.github.com> Subject: Re: [searchy2/CustomPermissionsDialogue] No method to include READ_PHONE_STATE (#6) Webpage not available body { margin-top: 0px; padding-top: 0px; } /* Used for additional styles, e.g. direction */ h2 { margin-top: 5px; padding-top: 0px; } Hi Kenneth, Thanks for taking a look! If you submit a PR, I'll review and merge it.- Ray — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#6> , or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADHP4OBG4X24HVPCBUZ3FFTQPOAEBANCNFSM4JCRT6GA> . <https://github.com/notifications/beacon/ADHP4OEGWAHTJ2B5D7LP5CTQPOAEBA5CNFSM4JCRT6GKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBX5SWA.gif>

[rayliverified]

Hi Ken,

You will need to create another branch by forking this repository before any changes can be made.
Or, if you send me the modified files, I can make the changes. It looks like Github doesn't get the files that you attach through your email.

• Ray

[kenargo]

Oh,  ok,  I'll do that today. ⁣Get BlueMail for Android ​

…

On Oct 20, 2019, 10:31 AM, at 10:31 AM, Ray Li ***@***.***> wrote: Hi Ken, You will need to create another branch by forking this repository before any changes can be made. Or, if you send me the modified files, I can make the changes. It looks like Github doesn't get the files that you attach through your email. - Ray -- You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub: #6 (comment)

[kenargo]

I completed the push yesterday morning. Let me know what you think and if you take the changes so I can integrate the GIT version rather than my private. Thanks, Ken From: Kenneth A. Argo [mailto:kenargo@kenargo.com] Sent: Saturday, October 19, 2019 5:05 PM To: 'searchy2/CustomPermissionsDialogue' <reply@reply.github.com>; 'searchy2/CustomPermissionsDialogue' <CustomPermissionsDialogue@noreply.github.com> Cc: 'Author' <author@noreply.github.com> Subject: RE: [searchy2/CustomPermissionsDialogue] No method to include READ_PHONE_STATE (#6) It appears that the repository is locked; I cannot push the branch with the changes. Or it’s working differently than prior times. I’ve attached the 2 changed files. Note: I’m not handling the fact that CALL_PHONE includes READ_PHONE_STATE. If users want to show descriptions for both or even show both permissions it would be a valid use-case. The code could be overly smart and remove READ_PHONE_STATE if there is no description and both CALL_PHONE and READ_PHONE_STATE but I figure this is more effort than it’s worth. If you disagree, let me know and I’ll add the additional logic. Thanks, Ken From: Ray Li [mailto:notifications@github.com] Sent: Saturday, October 19, 2019 3:06 PM To: searchy2/CustomPermissionsDialogue <CustomPermissionsDialogue@noreply.github.com <mailto:CustomPermissionsDialogue@noreply.github.com> > Cc: Kenneth A. Argo <kenargo@kenargo.com <mailto:kenargo@kenargo.com> >; Author <author@noreply.github.com <mailto:author@noreply.github.com> > Subject: Re: [searchy2/CustomPermissionsDialogue] No method to include READ_PHONE_STATE (#6) Webpage not available body { margin-top: 0px; padding-top: 0px; } /* Used for additional styles, e.g. direction */ h2 { margin-top: 5px; padding-top: 0px; } Hi Kenneth, Thanks for taking a look! If you submit a PR, I'll review and merge it.- Ray — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#6> , or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADHP4OBG4X24HVPCBUZ3FFTQPOAEBANCNFSM4JCRT6GA> . <https://github.com/notifications/beacon/ADHP4OEGWAHTJ2B5D7LP5CTQPOAEBA5CNFSM4JCRT6GKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBX5SWA.gif>

[rayliverified]

Thanks Ken,

I'm taking a look right now!

[rayliverified]

Looks good! Merged #7

[rayliverified]

Hey Ken,

Just wanted to follow up. Is v2.2.0 working for you?

[kenargo]

Yea, but I missed a corner case when only READ_STATE (with no description) was indicated. I just pushed the fix. From: Ray Li [mailto:notifications@github.com] Sent: Wednesday, October 23, 2019 12:34 PM To: searchy2/CustomPermissionsDialogue <CustomPermissionsDialogue@noreply.github.com> Cc: Kenneth A. Argo <kenargo@kenargo.com>; Author <author@noreply.github.com> Subject: Re: [searchy2/CustomPermissionsDialogue] No method to include READ_PHONE_STATE (#6) Hey Ken, Just wanted to follow up. Is v2.2.0 working for you? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#6> , or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADHP4OC674Y3SKPSOBI662TQQCRKJANCNFSM4JCRT6GA> . <https://github.com/notifications/beacon/ADHP4OGSJFRPNIJSOJDNZ3TQQCRKJA5CNFSM4JCRT6GKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECCTSSY.gif>

[kenargo]

I thought I replied but I don't see it. I had to push a one line additional change to cover a corner case.  The old code worked but I removed the description from code and then it stopped working. When you get a chance,  I sent a pull request. ⁣Get BlueMail for Android ​

…

On Oct 23, 2019, 12:34 PM, at 12:34 PM, Ray Li ***@***.***> wrote: Hey Ken, Just wanted to follow up. Is v2.2.0 working for you? -- You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub: #6 (comment)