Merge pull request WolvenKit#2682 from WolvenKit/fix/warn-if-mesh-has-no-bones

throw if bones are imported into a mesh without

Author: manavortex

WolvenKit.Modkit/RED4/Tools/MeshTools.cs

@@ -46,7 +46,7 @@ public static bool ExportMesh(CR2WFile cr2W, FileInfo outfile, MeshExportArgs me
             catch (ArgumentNullException)
             {
             }
-            
+
 
             if (model == null)
             {
@@ -568,11 +568,11 @@ public static List<RawMeshContainer> ContainRawMesh(MemoryStream gfs, MeshesInfo
                                         info.appearances.Keys.FirstOrDefault("default") :
                                         "submesh_" + Convert.ToString(index).PadLeft(2, '0') + "_LOD_" + info.LODLvl[index];
                 }
-                
+
 
                 meshContainer.materialNames = new string[info.appearances.Count];
 
-                
+
                 //var Mesh_apps = info.appearances.Keys.Select(key => Path.GetFileNameWithoutExtension(meshname)+'_' + key).ToList();
 
                 var apps = info.appearances.Keys.ToList();
@@ -655,6 +655,11 @@ public static (int numLodLevels, int numSubmeshesPerLod) GetLodInfo(CMesh mesh)
 
         public static void UpdateMeshJoints(ref List<RawMeshContainer> meshes, RawArmature? existingJoints, RawArmature? incomingJoints, string fileName = "")
         {
+            if (existingJoints is not { BoneCount: > 0 } && incomingJoints is { BoneCount: > 0 })
+            {
+                throw new WolvenKitException(0x2005, $"\nThe destination mesh has no bones");
+            }
+
             HashSet<string> bonesNotFound = [];
             // updating mesh bone indices
             if (existingJoints is { BoneCount: > 0 } && incomingJoints is { BoneCount: > 0 })
@@ -679,7 +684,7 @@ public static void UpdateMeshJoints(ref List<RawMeshContainer> meshes, RawArmatu
                             }
 
                             var boneName = incomingJoints.Names[mesh.boneindices[e, eye]];
-                            
+
                             var found = false;
                             for (ushort r = 0; r < existingJoints.BoneCount; r++)
                             {
@@ -714,8 +719,7 @@ public static void UpdateMeshJoints(ref List<RawMeshContainer> meshes, RawArmatu
 
             if (bonesNotFound.Any())
             {
-                throw new WolvenKitException(0x2005,
-                    $"\n{string.Join("\n", bonesNotFound)}");
+                throw new WolvenKitException(0x2005, $"\n{string.Join("\n", bonesNotFound)}");
             }
         }
 
@@ -876,7 +880,7 @@ public static void AddSubMeshesToModel(List<RawMeshContainer> meshes, Skin? skin
                 ArgumentNullException.ThrowIfNull(mesh.weights);
                 ArgumentNullException.ThrowIfNull(mesh.indices);
                 ArgumentNullException.ThrowIfNull(mesh.garmentMorph);
-                
+
 
                 Mesh? mes;
                 Node? node;
@@ -899,7 +903,7 @@ public static void AddSubMeshesToModel(List<RawMeshContainer> meshes, Skin? skin
                 ArgumentNullException.ThrowIfNull(mesh.materialNames, nameof(mesh.materialNames));
 
                 var prim = mes.CreatePrimitive();
-                
+
                 if (materials != null && materials.ContainsKey(mesh.materialNames[0]))
                 {
                     prim.Material = materials[mesh.materialNames[0]];