feat: add email validation in Authenticate api

Author: rsbh

internal/api/v1beta1/authenticate.go

@@ -72,6 +72,10 @@ func (h Handler) Authenticate(ctx context.Context, request *frontierv1beta1.Auth
 		return nil, status.Error(codes.Internal, err.Error())
 	}
 
+	if (request.StrategyName == authenticate.MailLinkAuthMethod.String() || request.StrategyName == authenticate.MailOTPAuthMethod.String()) && !isValidEmail(request.Email) {
+		return nil, status.Error(codes.InvalidArgument, "Invalid email")
+	}
+
 	// not logged in, try registration
 	response, err := h.authnService.StartFlow(ctx, authenticate.RegistrationStartRequest{
 		Method:      request.GetStrategyName(),

internal/api/v1beta1/authenticate_test.go

@@ -68,7 +68,7 @@ func TestHandler_Authenticate(t *testing.T) {
 				authn.EXPECT().SanitizeCallbackURL("").Return("")
 				session.EXPECT().ExtractFromContext(mock.AnythingOfType("context.backgroundCtx")).Return(nil, frontiersession.ErrNoSession)
 				authn.EXPECT().StartFlow(mock.AnythingOfType("context.backgroundCtx"), authenticate.RegistrationStartRequest{
-					Email:       "",
+					Email:       "[email protected]",
 					Method:      authenticate.MailOTPAuthMethod.String(),
 					ReturnToURL: "",
 					CallbackUrl: "",
@@ -81,14 +81,39 @@ func TestHandler_Authenticate(t *testing.T) {
 			},
 			request: &frontierv1beta1.AuthenticateRequest{
 				StrategyName: authenticate.MailOTPAuthMethod.String(),
-				Email:        "",
+				Email:        "[email protected]",
 			},
 			wantErr: nil,
 			want: &frontierv1beta1.AuthenticateResponse{
 				Endpoint: "",
 				State:    "",
 			},
 		},
+		{
+			name: "should throw error if email is invalid in mailotp",
+			setup: func(authn *mocks.AuthnService, session *mocks.SessionService) {
+				authn.EXPECT().SanitizeReturnToURL("").Return("")
+				authn.EXPECT().SanitizeCallbackURL("").Return("")
+				session.EXPECT().ExtractFromContext(mock.AnythingOfType("context.backgroundCtx")).Return(nil, frontiersession.ErrNoSession)
+				authn.EXPECT().StartFlow(mock.AnythingOfType("context.backgroundCtx"), authenticate.RegistrationStartRequest{
+					Email:       "frontier",
+					Method:      authenticate.MailOTPAuthMethod.String(),
+					ReturnToURL: "",
+					CallbackUrl: "",
+				}).Return(&authenticate.RegistrationStartResponse{
+					Flow: &authenticate.Flow{
+						StartURL: "",
+					},
+					State: "",
+				}, nil)
+			},
+			request: &frontierv1beta1.AuthenticateRequest{
+				StrategyName: authenticate.MailOTPAuthMethod.String(),
+				Email:        "frontier",
+			},
+			wantErr: status.Error(codes.InvalidArgument, "Invalid email"),
+			want:    nil,
+		},
 	}
 
 	for _, tt := range tests {