feat: implement buf connect server (#1038)

* generate buf connect stub

* create buf conenct server with dummy impl of all the RPCs

* change default port to 8002

* update buf connect rpc plugin

* add healthcheck

* refactor

* feat: add curl in the Dockerfile to support K8s exec probe

* remove curl

* update lint

* add graceful shutdown of connect server

* remove toolchain

* update golang version

* debug: update lint

* debug: update lint

* debug: update lint

* debug: update lint

* fix: upgrade to golangci-lint v2

* fix: upgrade to golangci-lint v2

* add error handling in buf connect server init

* change grace period

Author: whoAbhishekSah

.github/workflows/lint.yml

@@ -13,14 +13,14 @@ jobs:
     steps:
       - uses: actions/setup-go@v4
         with:
-          go-version: "1.22.5"
+          go-version: "1.23.1"
       - uses: actions/checkout@v3
         with:
           fetch-depth: 0
       - name: golangci-lint
-        uses: golangci/golangci-lint-action@v3
+        uses: golangci/golangci-lint-action@v8
         with:
-          version: v1.56.2
+          version: v2.2.1
   js-sdk-lint:
     name: JS SDK Lint
     runs-on: ubuntu-latest

.github/workflows/main.yml

@@ -15,7 +15,7 @@ jobs:
       - name: Set up Go
         uses: actions/setup-go@v4
         with:
-          go-version: "1.22.5"
+          go-version: "1.23.1"
       - name: Login to DockerHub
         uses: docker/login-action@v3
         with:

.github/workflows/release.yml

@@ -17,7 +17,7 @@ jobs:
       - name: Set up Go
         uses: actions/setup-go@v4
         with:
-          go-version: "1.22.5"
+          go-version: "1.23.1"
       - name: Login to DockerHub
         uses: docker/login-action@v3
         with:
@@ -41,7 +41,7 @@ jobs:
       - name: Set up Go
         uses: actions/setup-go@v4
         with:
-          go-version: "1.22.5"
+          go-version: "1.23.1"
       - name: Login to DockerHub
         uses: docker/login-action@v1
         with:

.github/workflows/test.yml

@@ -17,7 +17,7 @@ jobs:
       - name: Set up Go
         uses: actions/setup-go@v4
         with:
-          go-version: "1.22.5"
+          go-version: "1.23.1"
       - name: install dependencies
         run: go mod tidy
       - name: run unit tests
@@ -42,7 +42,7 @@ jobs:
       - name: Set up Go
         uses: actions/setup-go@v4
         with:
-          go-version: "1.22.5"
+          go-version: "1.23.1"
       - name: install dependencies
         run: go mod tidy
       - name: install spicedb binary
@@ -65,7 +65,7 @@ jobs:
       - name: Set up Go
         uses: actions/setup-go@v4
         with:
-          go-version: "1.22.5"
+          go-version: "1.23.1"
       - name: install dependencies
         run: go mod tidy
       - name: run regression tests

.golangci.yml

@@ -1,39 +1,45 @@
-run:
-  timeout: 5m
-  skip-dirs:
-    - ui
+version: "2"
 output:
-  format: colored-line-number
+  formats:
+    text:
+      path: stdout
 linters:
-  enable-all: false
-  disable-all: true
+  default: none
   enable:
-    - vet
-    - goimports
-    - thelper
-    - unconvert
-    - revive
-    - unused
-    - gofmt
-    - whitespace
-    - misspell
     - govet
     - importas
-    - protogetter
     - ineffassign
+    - misspell
+    - protogetter
+    - revive
+    - thelper
+    - unconvert
+    - unused
     - wastedassign
-#    - gosec
-#    - prealloc
-#    - errcheck
-#    - errorlint
-#    - staticcheck
-#    - gosimple
-#    - gocritic
-#    - goconst
-#    - perfsprint
-linters-settings:
-  revive:
-    ignore-generated-header: true
-    severity: warning
+    - whitespace
+  settings:
+    revive:
+      severity: warning
+  exclusions:
+    generated: lax
+    presets:
+      - comments
+      - common-false-positives
+      - legacy
+      - std-error-handling
+    paths:
+      - third_party$
+      - builtin$
+      - examples$
 severity:
-  default-severity: error
+  default: error
+formatters:
+  enable:
+    - gofmt
+    - goimports
+  exclusions:
+    generated: lax
+    paths:
+      - third_party$
+      - builtin$
+      - examples$

Dockerfile

@@ -2,4 +2,4 @@ FROM alpine:3.18
 
 COPY frontier /usr/bin/frontier
 
-ENTRYPOINT ["frontier"]
+ENTRYPOINT ["frontier"]

Dockerfile.dev

@@ -8,7 +8,7 @@ COPY Makefile .
 RUN make ui
 
 # Build the Go binary
-FROM golang:1.22.3-alpine3.18 as builder
+FROM golang:1.23.1-alpine3.20 as builder
 RUN apk add --no-cache make
 WORKDIR /app
 
@@ -27,4 +27,4 @@ RUN apk update && \
     apk add --no-cache ca-certificates libc6-compat && \
     rm -rf /var/cache/apk/*
 
-ENTRYPOINT ["frontier"]
+ENTRYPOINT ["frontier"]

buf.gen.yaml

@@ -1,21 +1,33 @@
 ---
-version: "v1"
+version: "v2"
+managed:
+  enabled: true
+  disable:
+    - module: buf.build/googleapis/googleapis
+    - module: buf.build/grpc-ecosystem/grpc-gateway
+    - module: buf.build/envoyproxy/protoc-gen-validate
+  override:
+    - file_option: "go_package"
+      value: "github.com/raystack/frontier/proto/v1beta1;frontierv1beta1"
 plugins:
-  - plugin: "buf.build/protocolbuffers/go:v1.30.0"
+  - remote: "buf.build/protocolbuffers/go:v1.30.0"
     out: "proto"
     opt: "paths=source_relative"
-  - plugin: "buf.build/grpc/go:v1.3.0"
+  - remote: "buf.build/grpc/go:v1.3.0"
     out: "proto"
     opt: "paths=source_relative"
-  - plugin: "buf.build/bufbuild/validate-go:v1.0.0"
+  - remote: "buf.build/bufbuild/validate-go:v1.0.0"
     out: "proto"
     opt: "paths=source_relative"
-  - plugin: "buf.build/grpc-ecosystem/gateway:v2.15.2"
+  - remote: "buf.build/grpc-ecosystem/gateway:v2.15.2"
     out: "proto"
     opt: "paths=source_relative"
-  - plugin: "buf.build/grpc-ecosystem/openapiv2:v2.16.0"
+  - remote: "buf.build/grpc-ecosystem/openapiv2:v2.16.0"
     out: "proto"
     opt:
       - allow_merge=true
       - output_format=yaml
       - json_names_for_fields=false
+  - remote: buf.build/connectrpc/go:v1.18.1
+    out: "proto"
+    opt: "paths=source_relative"

cmd/serve.go

@@ -305,7 +305,14 @@ func StartServer(logger *log.Zap, cfg *config.Frontier) error {
 
 	go server.ServeUI(ctx, logger, cfg.UI, cfg.App)
 
-	// serving server
+	// start connect server
+	go func() {
+		if err := server.ServeConnect(ctx, logger, cfg.App.Connect, deps); err != nil {
+			logger.Fatal("connect server failed", "err", err.Error())
+		}
+	}()
+
+	// serving grpc server
 	return server.Serve(ctx, logger, cfg.App, nrApp, deps, promRegistry)
 }
 

config/sample.config.yaml

@@ -17,6 +17,8 @@ app:
   port: 8000
   grpc:
     port: 8001
+  connect:
+    port: 8002
     # optional tls config
     # tls_cert_file: "temp/server-cert.pem"
     # tls_key_file: "temp/server-key.pem"