Skip to content

Commit 4ab86f0

Browse files
arinda-arifsbchaos
andauthored
fix: replay manual job and timeout issue (#767)
* fix: ignore job that does not have schedule from replay tree Co-authored-by: Sandeep Bhardwaj <[email protected]> * chore: increase write and idle server timeout Co-authored-by: Sandeep Bhardwaj <[email protected]> --------- Co-authored-by: Sandeep Bhardwaj <[email protected]>
1 parent 1dd694e commit 4ab86f0

File tree

2 files changed

+5
-2
lines changed

2 files changed

+5
-2
lines changed

job/replay.go

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -110,6 +110,9 @@ func findOrCreateDAGNode(dagTree *tree.MultiRootTree, dagSpec models.JobSpec) *t
110110
func populateDownstreamRuns(parentNode *tree.TreeNode) (*tree.TreeNode, error) {
111111
for idx, childNode := range parentNode.Dependents {
112112
childDag := childNode.Data.(models.JobSpec)
113+
if childDag.Schedule.Interval == "" {
114+
continue
115+
}
113116
taskSchedule, err := cron.ParseCronSchedule(childDag.Schedule.Interval)
114117
if err != nil {
115118
return nil, err

server/server.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -169,8 +169,8 @@ func prepareHTTPProxy(grpcAddr string, grpcServer *grpc.Server) (*http.Server, f
169169
Handler: grpcHandlerFunc(grpcServer, baseMux),
170170
Addr: grpcAddr,
171171
ReadTimeout: 5 * time.Second,
172-
WriteTimeout: 60 * time.Second,
173-
IdleTimeout: 120 * time.Second,
172+
WriteTimeout: 30 * time.Minute,
173+
IdleTimeout: 5 * time.Minute,
174174
}
175175

176176
return srv, cleanup, nil

0 commit comments

Comments
 (0)