Skip to content

Commit 6562958

Browse files
authored
feat(compass): add filter to get all types (#141)
1 parent 4658a5f commit 6562958

File tree

1 file changed

+29
-13
lines changed

1 file changed

+29
-13
lines changed

odpf/compass/v1beta1/service.proto

Lines changed: 29 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -198,7 +198,6 @@ service CompassService {
198198
};
199199
}
200200

201-
202201
// Domain: Asset
203202
rpc SearchAssets(SearchAssetsRequest) returns (SearchAssetsResponse) {
204203
option (google.api.http) = {
@@ -215,7 +214,6 @@ service CompassService {
215214
};
216215
}
217216

218-
219217
rpc SuggestAssets(SuggestAssetsRequest) returns (SuggestAssetsResponse) {
220218
option (google.api.http) = {
221219
get: "/v1beta1/search/suggest"
@@ -231,7 +229,6 @@ service CompassService {
231229
};
232230
}
233231

234-
235232
rpc GetGraph(GetGraphRequest) returns (GetGraphResponse) {
236233
option (google.api.http) = {
237234
get: "/v1beta1/lineage/{urn=**}"
@@ -247,7 +244,6 @@ service CompassService {
247244
};
248245
}
249246

250-
251247
rpc GetAllTypes(GetAllTypesRequest) returns (GetAllTypesResponse) {
252248
option (google.api.http) = {
253249
get: "/v1beta1/types"
@@ -262,7 +258,6 @@ service CompassService {
262258
};
263259
}
264260

265-
266261
rpc GetAllAssets(GetAllAssetsRequest) returns (GetAllAssetsResponse) {
267262
option (google.api.http) = {
268263
get: "/v1beta1/assets"
@@ -277,7 +272,6 @@ service CompassService {
277272
};
278273
}
279274

280-
281275
rpc GetAssetByID(GetAssetByIDRequest) returns (GetAssetByIDResponse) {
282276
option (google.api.http) = {
283277
get: "/v1beta1/assets/{id}"
@@ -292,7 +286,6 @@ service CompassService {
292286
};
293287
}
294288

295-
296289
rpc UpsertPatchAsset(UpsertPatchAssetRequest) returns (UpsertPatchAssetResponse) {
297290
option (google.api.http) = {
298291
patch: "/v1beta1/assets"
@@ -308,7 +301,6 @@ service CompassService {
308301
};
309302
}
310303

311-
312304
rpc DeleteAsset(DeleteAssetRequest) returns (DeleteAssetResponse) {
313305
option (google.api.http) = {
314306
delete: "/v1beta1/assets/{id}"
@@ -323,7 +315,6 @@ service CompassService {
323315
};
324316
}
325317

326-
327318
rpc GetAssetStargazers(GetAssetStargazersRequest) returns (GetAssetStargazersResponse) {
328319
option (google.api.http) = {
329320
get: "/v1beta1/assets/{id}/stargazers"
@@ -338,7 +329,6 @@ service CompassService {
338329
};
339330
}
340331

341-
342332
rpc GetAssetVersionHistory(GetAssetVersionHistoryRequest) returns (GetAssetVersionHistoryResponse) {
343333
option (google.api.http) = {
344334
get: "/v1beta1/assets/{id}/versions"
@@ -353,7 +343,6 @@ service CompassService {
353343
};
354344
}
355345

356-
357346
rpc GetAssetByVersion(GetAssetByVersionRequest) returns (GetAssetByVersionResponse) {
358347
option (google.api.http) = {
359348
get: "/v1beta1/assets/{id}/versions/{version}"
@@ -368,7 +357,6 @@ service CompassService {
368357
};
369358
}
370359

371-
372360
// Domain: User * Star
373361
rpc GetUserStarredAssets(GetUserStarredAssetsRequest) returns (GetUserStarredAssetsResponse) {
374362
option (google.api.http) = {
@@ -804,7 +792,35 @@ message GetGraphResponse {
804792
repeated LineageEdge data = 1;
805793
}
806794

807-
message GetAllTypesRequest {}
795+
message GetAllTypesRequest {
796+
string q = 1 [
797+
(validate.rules).string.ignore_empty = true,
798+
(grpc.gateway.protoc_gen_openapiv2.options.openapiv2_field) = {
799+
description: "filter by specific query"
800+
}
801+
];
802+
string q_fields = 2 [
803+
(validate.rules).string.ignore_empty = true,
804+
(grpc.gateway.protoc_gen_openapiv2.options.openapiv2_field) = {
805+
description: "filter by multiple query fields"
806+
}
807+
];
808+
string types = 3 [
809+
(validate.rules).string.ignore_empty = true,
810+
(grpc.gateway.protoc_gen_openapiv2.options.openapiv2_field) = {
811+
description: "filter by multiple types"
812+
}
813+
];
814+
string services = 4 [
815+
(validate.rules).string.ignore_empty = true,
816+
(grpc.gateway.protoc_gen_openapiv2.options.openapiv2_field) = {
817+
description: "filter by multiple services"
818+
}
819+
];
820+
map<string, string> data = 5 [(grpc.gateway.protoc_gen_openapiv2.options.openapiv2_field) = {
821+
description: "query result based on a (nested) field of the data asset. the nested field is written with period separated field name. eg, \"data[name.entity]\""
822+
}];
823+
}
808824

809825
message GetAllTypesResponse {
810826
repeated Type data = 1;

0 commit comments

Comments
 (0)