Refactor Lock mixin to an abstract FixedValue superclass

To avoid confusing rule validation mixins with the special "Lock" mixin
that was used in the internal `*::Validation` classes, this is now a
superclass. Also renamed to `FixedValue` to avoid confusion with
`ScheduleLock`.

Author: avit

lib/ice_cube.rb

@@ -34,8 +34,7 @@ module IceCube
   autoload :YearlyRule, 'ice_cube/rules/yearly_rule'
 
   module Validations
-
-    autoload :Lock, 'ice_cube/validations/lock'
+    autoload :FixedValue, 'ice_cube/validations/fixed_value'
     autoload :ScheduleLock, 'ice_cube/validations/schedule_lock'
 
     autoload :Count, 'ice_cube/validations/count'

lib/ice_cube/validations/day.rb

@@ -16,9 +16,7 @@ def day(*days)
       self
     end
 
-    class Validation
-
-      include Validations::Lock
+    class Validation < Validations::FixedValue
 
       attr_reader :day
       alias :value :day

lib/ice_cube/validations/day_of_month.rb

@@ -13,9 +13,7 @@ def day_of_month(*days)
       self
     end
 
-    class Validation
-
-      include Validations::Lock
+    class Validation < Validations::FixedValue
 
       attr_reader :day
       alias :value :day

lib/ice_cube/validations/lock.rb renamed to lib/ice_cube/validations/fixed_value.rb

@@ -1,14 +1,14 @@
 module IceCube
 
-  # This validation mixin is used by the various "fixed-time" (e.g. day,
-  # day_of_month, hour_of_day) Validation and ScheduleLock::Validation modules.
-  # It is not a standalone rule validation like the others.
+  # This abstract validation class is used by the various "fixed-time" (e.g.
+  # day, day_of_month, hour_of_day) Validation and ScheduleLock::Validation
+  # modules. It is not a standalone rule validation module like the others.
   #
-  # Given the including Validation's defined +type+ field, it will lock
-  # to the specified +value+ or else the corresponding time unit from the
-  # schedule's start_time
+  # Given the including Validation's defined +type+ field, it will lock to the
+  # specified +value+ or else the corresponding time unit from the schedule's
+  # start_time
   #
-  module Validations::Lock
+  class Validations::FixedValue
 
     INTERVALS = {:min => 60, :sec => 60, :hour => 24, :month => 12, :wday => 7}
 

lib/ice_cube/validations/hour_of_day.rb

@@ -14,9 +14,7 @@ def hour_of_day(*hours)
       self
     end
 
-    class Validation
-
-      include Validations::Lock
+    class Validation < Validations::FixedValue
 
       attr_reader :hour
       alias :value :hour

lib/ice_cube/validations/minute_of_hour.rb

@@ -13,9 +13,7 @@ def minute_of_hour(*minutes)
       self
     end
 
-    class Validation
-
-      include Validations::Lock
+    class Validation < Validations::FixedValue
 
       attr_reader :minute
       alias :value :minute

lib/ice_cube/validations/month_of_year.rb

@@ -14,9 +14,7 @@ def month_of_year(*months)
       self
     end
 
-    class Validation
-
-      include Validations::Lock
+    class Validation < Validations::FixedValue
 
       attr_reader :month
       alias :value :month

lib/ice_cube/validations/schedule_lock.rb

@@ -12,9 +12,7 @@ def schedule_lock(*types)
       end
     end
 
-    class Validation
-
-      include Validations::Lock
+    class Validation < Validations::FixedValue
 
       attr_reader :type, :value
 

lib/ice_cube/validations/second_of_minute.rb

@@ -13,9 +13,7 @@ def second_of_minute(*seconds)
       self
     end
 
-    class Validation
-
-      include Validations::Lock
+    class Validation < Validations::FixedValue
 
       attr_reader :second
       alias :value :second