Skip to content

Commit 2572d40

Browse files
committed
fix: Introduce REDUX_LOGGING environment variable to enable redux logging
BREAKING CHANGE: #108 #108
1 parent c9091f3 commit 2572d40

File tree

4 files changed

+13
-14
lines changed

4 files changed

+13
-14
lines changed

README.md

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -93,8 +93,8 @@ This is the container component that encapsulates the lanes and cards
9393
| handleDragEnd | function | Callback function triggered when card drag ends: `handleDragEnd(cardId, sourceLaneId, targetLaneId, position, cardDetails)` |
9494
| handleLaneDragStart | function | Callback function triggered when lane drag is started: `handleLaneDragStart(laneId)` |
9595
| handleLaneDragEnd | function | Callback function triggered when lane drag ends: `handleLaneDragEnd(laneId, newPosition)` |
96-
| cardDragClass | string | CSS class to be applied to Card when being dragged |
97-
| laneDragClass | string | CSS class to be applied to Lane when being dragged |
96+
| cardDragClass | string | CSS class to be applied to Card when being dragged |
97+
| laneDragClass | string | CSS class to be applied to Lane when being dragged |
9898
| onLaneScroll | function | Called when a lane is scrolled to the end: `onLaneScroll(requestedPage, laneId)` |
9999
| onCardClick | function | Called when a card is clicked: `onCardClick(cardId, metadata, laneId)` |
100100
| onCardAdd | function | Called when a new card is added: `onCardAdd(card, laneId)` |
@@ -239,6 +239,10 @@ Tested to work with following browsers using [Browserling](https://www.browserli
239239

240240
Check the Milestones for this project to track when the above features will be implemented.
241241

242+
## Logging
243+
244+
Pass environment variable `REDUX_LOGGING` as true to enable Redux logging in any environment
245+
242246
## Development
243247

244248
```

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -91,14 +91,14 @@
9191
"jest-cli": "^21.0.1",
9292
"jsdom": "^9.12.0",
9393
"mocha": "^3.4.2",
94-
"node-sass": "4.9.3",
94+
"node-sass": "^4.5.3",
9595
"prettier": "1.10.2",
9696
"pretty-quick": "^1.4.1",
9797
"react": "^16.2.0",
9898
"react-addons-test-utils": "^15.5.1",
9999
"react-dom": "^16.2.0",
100100
"react-test-renderer": "^15.4.2",
101-
"sass-loader": "7.1.0",
101+
"sass-loader": "^6.0.6",
102102
"semantic-release": "^6.3.6",
103103
"style-loader": "^0.18.2",
104104
"webpack": "^3.0.0"

src/components/Board.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import boardReducer from '../reducers/BoardReducer'
66
import logger from 'redux-logger'
77
import uuidv1 from "uuid/v1"
88

9-
const middlewares = process.env.NODE_ENV === 'development' ? [logger] : []
9+
const middlewares = process.env.REDUX_LOGGING ? [logger] : []
1010

1111
export default class Board extends Component {
1212
constructor() {

yarn.lock

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -6089,7 +6089,7 @@ node-pre-gyp@^0.6.36:
60896089
tar "^2.2.1"
60906090
tar-pack "^3.4.0"
60916091

6092-
node-sass@4.9.3:
6092+
node-sass@^4.5.3:
60936093
version "4.9.3"
60946094
resolved "https://registry.yarnpkg.com/node-sass/-/node-sass-4.9.3.tgz#f407cf3d66f78308bb1e346b24fa428703196224"
60956095
dependencies:
@@ -7887,16 +7887,15 @@ sass-graph@^2.2.4:
78877887
scss-tokenizer "^0.2.3"
78887888
yargs "^7.0.0"
78897889

7890-
sass-loader@7.1.0:
7891-
version "7.1.0"
7892-
resolved "https://registry.yarnpkg.com/sass-loader/-/sass-loader-7.1.0.tgz#16fd5138cb8b424bf8a759528a1972d72aad069d"
7890+
sass-loader@^6.0.6:
7891+
version "6.0.7"
7892+
resolved "https://registry.yarnpkg.com/sass-loader/-/sass-loader-6.0.7.tgz#dd2fdb3e7eeff4a53f35ba6ac408715488353d00"
78937893
dependencies:
78947894
clone-deep "^2.0.1"
78957895
loader-utils "^1.0.1"
78967896
lodash.tail "^4.1.1"
78977897
neo-async "^2.5.0"
78987898
pify "^3.0.0"
7899-
semver "^5.5.0"
79007899

79017900
sax@^1.2.1, sax@~1.2.1:
79027901
version "1.2.4"
@@ -7952,10 +7951,6 @@ semver-diff@^2.0.0:
79527951
version "4.3.6"
79537952
resolved "https://registry.yarnpkg.com/semver/-/semver-4.3.6.tgz#300bc6e0e86374f7ba61068b5b1ecd57fc6532da"
79547953

7955-
semver@^5.5.0:
7956-
version "5.5.1"
7957-
resolved "https://registry.yarnpkg.com/semver/-/semver-5.5.1.tgz#7dfdd8814bdb7cabc7be0fb1d734cfb66c940477"
7958-
79597954
semver@~5.0.1:
79607955
version "5.0.3"
79617956
resolved "https://registry.yarnpkg.com/semver/-/semver-5.0.3.tgz#77466de589cd5d3c95f138aa78bc569a3cb5d27a"

0 commit comments

Comments
 (0)