WIP

Author: rcleveng

CLAUDE.md

@@ -0,0 +1,67 @@
+# CLAUDE.md
+
+This file provides guidance to Claude Code (claude.ai/code) when working with code in this repository.
+
+## Project Overview
+
+This repository contains devcontainer features for use with @devcontainers. It currently includes a `delta` feature that installs the delta pager for git.
+
+## Repository Structure
+
+- `src/` - Contains devcontainer features, each in its own subdirectory
+- `src/delta/` - The delta pager feature
+  - `devcontainer-feature.json` - Feature configuration and metadata
+  - `install.sh` - Installation script for the delta pager
+- `test/` - Test files for each feature
+- `test/delta/test.sh` - Test script for the delta feature
+
+## Development Commands
+
+### Testing Features
+
+To test the delta feature:
+```bash
+devcontainer features test \
+  --features delta \
+  --remote-user root \
+  --skip-scenarios \
+  --base-image mcr.microsoft.com/devcontainers/base:ubuntu \
+  /path/to/this/repo
+```
+
+### Publishing Features
+
+Features are published via GitHub Actions workflow (`.github/workflows/release.yaml`) that:
+- Publishes features using the devcontainers/action
+- Generates documentation automatically
+- Creates PRs for documentation updates
+
+## Architecture
+
+### Feature Structure
+
+Each devcontainer feature follows this pattern:
+- `devcontainer-feature.json` - Defines the feature metadata, options, and environment variables
+- `install.sh` - Installation script that handles cross-platform installation
+- Tests in corresponding `test/` directory
+
+### Installation Script Architecture
+
+The `install.sh` script uses a modular approach:
+- OS detection (`detect_os()`) - Identifies RedHat, Alpine, or Debian-based systems
+- Architecture detection (`detect_architecture()`) - Handles amd64, arm64, armhf
+- Package manager abstraction (`install_package()`) - Unified interface for different package managers
+- Error handling with `run()` function for privilege escalation
+
+### Cross-Platform Support
+
+The delta feature supports:
+- Debian/Ubuntu: Downloads .deb from GitHub releases
+- RedHat/CentOS/Fedora: Uses dnf package manager
+- Alpine: Uses pacman package manager
+
+## Key Files
+
+- `src/delta/devcontainer-feature.json:21` - Sets GIT_PAGER environment variable
+- `src/delta/install.sh:115` - Contains a typo in the .deb URL construction (`.derb` instead of `.deb`)
+- `test/delta/test.sh:43` - Tests delta installation and GIT_PAGER configuration

src/delta/install.sh

@@ -136,23 +136,36 @@ install_delta_for_debian() {
 
 # Install delta based on OS (fallback to package manager)
 install_package() {
-    OS_TYPE=$(detect_os)
+    local OS_TYPE=$(detect_os)
+    local version="${VERSION:-latest}"
     local package_name=$1
-    echo "Detected OS type: $OS_TYPE"
+
+    echo "Installing ${package_name}; version: ${version}; on OS: ${OS_TYPE}"
 
     case "$OS_TYPE" in
         redhat)
             echo "Installing delta using dnf..."
-            run dnf install -y ${package_name}
+            local pkg=${package_name}
+            if [[ -z ${version} ]]; then
+                pkg="${package_name}-${version}"
+            fi
+            run dnf install -y ${pkg}
             ;;
         alpine)
             echo "Installing delta using pacman..."
-            run pacman -S --noconfirm ${package_name}
+            local pkg=${package_name}
+            if [[ -z ${version} ]]; then
+                pkg="${package_name}=${version}"
+            fi
+            run apk add --no-interactiv ${pkg}
             ;;
         debian)
             echo "Installing delta using apt..."
-            run apt update -y
-            run apt install -y ${package_name}
+            run apt-get update -y
+            if [[ -z ${version} ]]; then
+                pkg="${package_name}=${version}"
+            fi
+            run apt-get install -y ${pkg}
             ;;
         *)
             echo "Unsupported OS or package manager not detected"
@@ -166,8 +179,8 @@ install_package() {
 
 # Install delta based on OS (fallback to package manager)
 install_delta() {
+    echo "Installing delta"
     OS_TYPE=$(detect_os)
-    echo "Detected OS type: $OS_TYPE"
 
     case "$OS_TYPE" in
         redhat)
@@ -181,7 +194,7 @@ install_delta() {
             install_delta_for_debian
             ;;
         *)
-            echo "Unsupported OS or package manager not detected"
+            echo "Unsupported OS or package manager not detected: ${OS_TYPE}"
             echo "Please file an issue with the container OS information at:"
             echo "https://github.com/rcleveng/devcontainer-features/issues/new"
 
@@ -190,14 +203,4 @@ install_delta() {
     esac
 }
 
-echo "Activating feature 'delta'"
-
-# Install delta
 install_delta
-
-echo "The effective dev container remoteUser is '$_REMOTE_USER'"
-echo "The effective dev container remoteUser's home directory is '$_REMOTE_USER_HOME'"
-
-echo "The effective dev container containerUser is '$_CONTAINER_USER'"
-echo "The effective dev container containerUser's home directory is '$_CONTAINER_USER_HOME'"
-

test_all.sh

@@ -0,0 +1,5 @@
+#!/bin/bash
+
+devcontainer features test --base-image mcr.microsoft.com/devcontainers/base:alpine
+devcontainer features test --base-image mcr.microsoft.com/devcontainers/base:ubuntu
+devcontainer features test --base-image mcr.microsoft.com/devcontainers/base:debian