Crash registering new cases in live

[mbarton]

Traceback (most recent call last):
  File "/usr/local/lib/python3.11/site-packages/django/core/handlers/exception.py", line 55, in inner
    response = get_response(request)
               ^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/django/core/handlers/base.py", line 197, in _get_response
    response = wrapped_callback(request, *callback_args, **callback_kwargs)
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/django/contrib/auth/decorators.py", line 59, in _view_wrapper
    return view_func(request, *args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/app/epilepsy12/decorator.py", line 407, in wrapper
    return view(request, *args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/django/contrib/auth/decorators.py", line 59, in _view_wrapper
    return view_func(request, *args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/app/epilepsy12/decorator.py", line 312, in wrapper
    permissions = lookup_user_permissions_on_child(request, kwargs)
                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/app/epilepsy12/decorator.py", line 300, in lookup_user_permissions_on_child
    "can_edit": child.editable(),
                ^^^^^^^^^^^^^^^^
  File "/app/epilepsy12/models_folder/case.py", line 187, in editable
    return self.registration.days_remaining_before_submission > 0
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Exception Type: TypeError at /case/17782/register
Exception Value: '>' not supported between instances of 'NoneType' and 'int'
Raised during: epilepsy12.decorator.wrapper

Clearly introduced in #1369 but I'm a bit lost why days_remaining_before_submission is None as I can't reproduce creating new cases myself locally.

Easy enough to fix forward though and investigate the issue afterwards.

[mbarton]

For the affected cases it seems case.registration.audit_submission_date is None. They do have a registration so the bypass here is not firing:

rcpch-audit-engine/epilepsy12/models_folder/case.py

Line 184 in e421745

if not hasattr(self, "registration"):

. I assume it's this bypass that allows it work when I'm creating new cases locally.

Registrations seem only to be created in the register endpoint:

rcpch-audit-engine/epilepsy12/views/registration_views.py

Line 107 in e421745

registration = Registration.objects.create(

.

So I'm a bit confused how the cases in live have registrations without audit_submission_date.

Update: Registrations are created on demand when the register page is viewed

[mbarton]

Seems like #1374 has fixed the problem but leaving this ticket open to investigate why those cases have registrations without audit_submission_date

[mbarton]

Ah I think this is because I was testing as an admin which meant I can always edit everything!