refactor: cleaning up test class

Signed-off-by: rahul <[email protected]>

Author: rcsofttech85

src/FileHandler.php

@@ -83,13 +83,15 @@ public function toJson(): string
         return json_encode($data);
     }
 
-    public function delete()
+    /**
+     * @throws FileHandlerException
+     */
+    public function delete(string $filename): void
     {
-        foreach ($this->files as $file) {
-            if (!unlink($file)) {
-                throw new FileHandlerException('could not delete file');
-            }
+        if (!file_exists($filename)) {
+            throw new FileHandlerException('file does not exists');
         }
+        unlink($filename);
     }
 
     /**
@@ -120,7 +122,6 @@ private function getRows(): Generator
         }
     }
 
-
     /**
      * @throws FileHandlerException
      */

tests/unit/FileHandlerTest.php

@@ -17,25 +17,40 @@ class FileHandlerTest extends TestCase
     protected function setUp(): void
     {
         parent::setUp();
-
         $this->fileHandler = new FileHandler();
-        fopen(filename: "file", mode: "w");
+    }
 
+    public static function setUpBeforeClass(): void
+    {
+        parent::setUpBeforeClass();
         $content = "Film,Genre,Lead Studio,Audience score %,Profitability,Rotten Tomatoes %,Worldwide Gross,Year\n"
             . "Zack and Miri Make a Porno,Romance,The Weinstein Company,70,1.747541667,64,$41.94 ,2008\n"
             . "Youth in Revolt,Comedy,The Weinstein Company,52,1.09,68,$19.62 ,2010\n"
             . "Twilight,Romance,Independent,68,6.383363636,26,$702.17 ,2011";
 
+        fopen(filename: "file", mode: "w");
+        fopen(filename: "file1", mode: "w");
         file_put_contents('movie.csv', $content);
     }
 
+    public static function tearDownAfterClass(): void
+    {
+        parent::tearDownAfterClass();
+
+        $files = ["file", "movie.csv", 'file1'];
+
+        foreach ($files as $file) {
+            if (file_exists($file)) {
+                unlink(filename: $file);
+            }
+        }
+    }
+
     protected function tearDown(): void
     {
         parent::tearDown();
 
         $this->fileHandler = null;
-        unlink(filename: "file");
-        unlink(filename: "movie.csv");
     }
 
 
@@ -67,34 +82,34 @@ public function shouldThrowExceptionIfFileIsNotWritable()
         $this->fileHandler->write(data: "hello world");
     }
 
+
     #[Test]
-    public function multipleFileCanBeWrittenSimultaneously()
+    public function fileIsClosedProperly()
     {
         $this->fileHandler->open(filename: 'file');
-
-        $this->fileHandler->open(filename: 'file1', mode: 'w');
-
         $this->fileHandler->write(data: "hello world");
+        $this->fileHandler->close();
 
-        $this->assertEquals("hello world", file_get_contents(filename: 'file'));
-
-        $this->assertEquals("hello world", file_get_contents(filename: 'file1'));
-
-        unlink("file1");
+        $this->expectException(TypeError::class);
+        $this->fileHandler->write(data: "fwrite(): supplied resource is not a valid stream resource");
     }
 
 
     #[Test]
-    public function fileIsClosedProperly()
+    public function multipleFileCanBeWrittenSimultaneously()
     {
         $this->fileHandler->open(filename: 'file');
+
+        $this->fileHandler->open(filename: 'file1');
+
         $this->fileHandler->write(data: "hello world");
-        $this->fileHandler->close();
 
-        $this->expectException(TypeError::class);
-        $this->fileHandler->write(data: "fwrite(): supplied resource is not a valid stream resource");
+        $this->assertEquals("hello world", file_get_contents(filename: 'file'));
+
+        $this->assertEquals("hello world", file_get_contents(filename: 'file1'));
     }
 
+
     #[Test]
     #[DataProvider('provideMovieNames')]
     #[TestDox('search result with name $keyword exists in file.')]