Test undefined

Author: matthieubosquet

src/DatasetWrapper.ts

@@ -1,5 +1,5 @@
 import type { DataFactory, DatasetCore, Quad, Term } from "@rdfjs/types"
-import type {ITermWrapperConstructor } from "./type/ITermWrapperConstructor.js"
+import type { ITermWrapperConstructor } from "./type/ITermWrapperConstructor.js"
 
 import { RDF } from "./vocabulary/RDF.js"
 

src/TermWrapper.ts

@@ -44,6 +44,7 @@ export class TermWrapper {
             this.dataset.delete(q)
         }
 
+        // TODO: TermMapping undefined: Return after deleting quads if undefined
         if (value === undefined) {
             return
         }
@@ -54,6 +55,7 @@ export class TermWrapper {
             return // TODO: throw error?
         }
 
+        // TODO: TermMapping undefined: the term mapping is not invoked if undefined
         const o = termMapping(value, this.dataset, this.factory)
 
         if (o === undefined) {

src/mapping/TermMapping.ts

@@ -9,24 +9,30 @@ import { TermWrapper } from "../TermWrapper.js"
  * Generic Term Wrapper factories
 */
 export namespace TermMapping {
+    // TODO: consider not allowing null value here, should be taken care of upstream
     export function stringToLiteral(value: string | undefined, dataset: DatasetCore, factory: DataFactory): TermWrapper | undefined {
-        // TODO: Check setting of undefined values
+        // TODO: Check I don't think there's a way to hit this currently
+        // TODO: Check, this would probably only be hit if the TermWrapper method is bogus (see overwrite nullable)
         if (value === undefined) {
             return undefined
         }
 
         return new TermWrapper(factory.literal(value), dataset, factory)
     }
 
+    // TODO: consider not allowing null value here, should be taken care of upstream
     export function dateToLiteral(value: Date | undefined, dataset: DatasetCore, factory: DataFactory): TermWrapper | undefined {
+        // TODO: CHeck, this would probably only be hit if the TermWrapper method is bogus (see overwrite nullable)
         if (value === undefined) {
             return undefined
         }
 
         return new TermWrapper(factory.literal(value.toISOString(), factory.namedNode("http://www.w3.org/2001/XMLSchema#date")), dataset, factory)
     }
 
+    // TODO: consider not allowing null value here, should be taken care of upstream
     export function numberToLiteral(value: number | undefined, dataset: DatasetCore, factory: DataFactory): TermWrapper | undefined {
+        // TODO: CHeck, this would probably only be hit if the TermWrapper method is bogus (see overwrite nullable)
         if (value === undefined) {
             return undefined
         }
@@ -35,7 +41,9 @@ export namespace TermMapping {
         return new TermWrapper(factory.literal(value.toString(), factory.namedNode("http://www.w3.org/2001/XMLSchema#double")), dataset, factory)
     }
 
+    // TODO: consider not allowing null value here, should be taken care of upstream
     export function stringToIri(value: string | undefined, dataset: DatasetCore, factory: DataFactory): TermWrapper | undefined {
+        // TODO: CHeck, this would probably only be hit if the TermWrapper method is bogus (see overwrite nullable)
         if (value === undefined) {
             return undefined
         }

test/unit/term_wrapper.test.ts

@@ -87,6 +87,10 @@ describe("Term Wrappers", async () => {
             assert.equal(parent.hasString, "o1 edited")
         })
 
+        it("set single literal to undefined throws", () => {
+            assert.throws(() => { parent.hasString = undefined as any })
+        })
+
         it("set single nullable literal to string", () => {
             parent.hasNullableString = "o2 edited"
             assert.equal(parent.hasNullableString, "o2 edited")