Merge pull request #263 from frank-weindel/feature/allow-periods-hash-value

Router: Allow periods in hash values

Author: erikhaandrikman

CHANGELOG.md

@@ -1,5 +1,10 @@
 # Changelog
 
+## v4.6.1
+
+*30 aug 2021*
+
+- Fixed cleanup after closing an App
 ## v4.6.0
 
 *16 aug 2021*

docs/changelog.md

@@ -1,5 +1,10 @@
 # Changelog
 
+## v4.6.1
+
+*30 aug 2021*
+
+- Fixed cleanup after closing an App
 ## v4.6.0
 
 *16 aug 2021*

docs/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@lightningjs/sdk",
-  "version": "4.5.0",
+  "version": "4.6.1",
   "license": "Apache-2.0",
   "scripts": {
     "postinstall": "node ./scripts/postinstall.js",

package-lock.json

@@ -1,6 +1,6 @@
 {
   "name": "@lightningjs/sdk",
-  "version": "4.6.0",
+  "version": "4.6.1",
   "license": "Apache-2.0",
   "scripts": {
     "postinstall": "node ./scripts/postinstall.js",

package.json

@@ -160,10 +160,7 @@ export default function(App, appData, platformSettings) {
     }
 
     closeApp() {
-      Log.info('Closing App')
-
-      Settings.clearSubscribers()
-      Registry.clear()
+      Log.info('Signaling App Close')
 
       if (platformSettings.onClose && typeof platformSettings.onClose === 'function') {
         platformSettings.onClose(...arguments)
@@ -174,6 +171,10 @@ export default function(App, appData, platformSettings) {
 
     close() {
       Log.info('Closing App')
+
+      Settings.clearSubscribers()
+      Registry.clear()
+
       this.childList.remove(this.tag('App'))
       this.cleanupFonts()
       // force texture garbage collect

src/Application/index.js

@@ -150,7 +150,7 @@ export const getValuesFromHash = (hash = '', path) => {
   // we already did the matching part
   path = stripRegex(path, '')
 
-  const getUrlParts = /(\/?:?[\w%\s:-]+)/g
+  const getUrlParts = /(\/?:?[\w%\s:.-]+)/g
   const hashParts = hash.match(getUrlParts) || []
   const routeParts = path.match(getUrlParts) || []
   const getNamedGroup = /^\/:([\w-]+)\/?/