Skip to content

Commit 2dc090b

Browse files
Merge pull request #254 from jfboeve/master
Addition of getter and Handling promise rejection
2 parents 88be70a + da816ac commit 2dc090b

File tree

3 files changed

+24
-6
lines changed

3 files changed

+24
-6
lines changed

package-lock.json

Lines changed: 5 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@
2323
"dependencies": {
2424
"@babel/polyfill": "^7.11.5",
2525
"@lightningjs/core": "*",
26+
"@michieljs/execute-as-promise": "^1.0.0",
2627
"deepmerge": "^4.2.2",
2728
"localCookie": "github:WebPlatformForEmbedded/localCookie",
2829
"shelljs": "^0.8.4",

src/VideoPlayer/index.js

Lines changed: 18 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,8 @@
1717
* limitations under the License.
1818
*/
1919

20+
import executeAsPromise from '@michieljs/execute-as-promise'
21+
2022
import Metrics from '../Metrics'
2123
import Log from '../Log'
2224
import Ads from '../Ads'
@@ -233,11 +235,15 @@ const videoPlayerPlugin = {
233235
state.playingAds = true
234236
ads.prerolls().then(() => {
235237
state.playingAds = false
236-
loader(url, videoEl, config).then(() => {
237-
registerEventListeners()
238-
this.show()
239-
this.play()
240-
})
238+
loader(url, videoEl, config)
239+
.then(() => {
240+
registerEventListeners()
241+
this.show()
242+
this.play()
243+
})
244+
.catch(e => {
245+
fireOnConsumer('error', { videoElement: videoEl, event: e })
246+
})
241247
})
242248
})
243249
}
@@ -279,7 +285,9 @@ const videoPlayerPlugin = {
279285
play() {
280286
if (!this.canInteract) return
281287
if (textureMode === true) videoTexture.start()
282-
videoEl.play()
288+
executeAsPromise(videoEl.play, null, videoEl).catch(e => {
289+
fireOnConsumer('error', { videoElement: videoEl, event: e })
290+
})
283291
},
284292

285293
pause() {
@@ -424,6 +432,10 @@ const videoPlayerPlugin = {
424432
get _videoEl() {
425433
return videoEl
426434
},
435+
436+
get _consumer() {
437+
return consumer
438+
},
427439
}
428440

429441
export default autoSetupMixin(videoPlayerPlugin, () => {

0 commit comments

Comments
 (0)