Development/don't touch c,cxx flags (#488)

Author: bramoosterhuis

.github/workflows/Build ThunderInterfaces on Linux.yml

@@ -16,7 +16,7 @@ jobs:
 
   ThunderInterfaces:
     needs: Thunder
-    uses: rdkcentral/ThunderInterfaces/.github/workflows/Linux build template.yml@master
+    uses: ./.github/workflows/Linux build template.yml
 
   ThunderClientLibraries:
     needs: ThunderInterfaces

.github/workflows/Build ThunderInterfaces on MacOS.yml

@@ -16,7 +16,7 @@ jobs:
 
   ThunderInterfaces_MacOS:
     needs: Thunder_MacOS
-    uses: rdkcentral/ThunderInterfaces/.github/workflows/MacOS build template.yml@master
+    uses: ./.github/workflows/MacOS build template.yml
 
   ThunderClientLibraries_MacOS:
     needs: ThunderInterfaces_MacOS

.github/workflows/Linux build template.yml

@@ -104,8 +104,8 @@ jobs:
       run: |
         source venv/bin/activate
         cmake -G Ninja -S ThunderInterfaces -B ${{matrix.build_type}}/build/ThunderInterfaces \
-        -DCMAKE_CXX_FLAGS="-Wall -Wextra -Wpedantic -Werror -m${{matrix.architecture}}" \
-        -DCMAKE_C_FLAGS="-Wall -Wextra -Wpedantic -Werror -m${{matrix.architecture}}" \
+        -DCMAKE_CXX_FLAGS="-m${{matrix.architecture}}" \
+        -DCMAKE_C_FLAGS="-m${{matrix.architecture}}" \
         -DCMAKE_INSTALL_PREFIX="${{matrix.build_type}}/install/usr" \
         -DCMAKE_MODULE_PATH="${PWD}/${{matrix.build_type}}/install/usr/include/WPEFramework/Modules"
         cmake --build ${{matrix.build_type}}/build/ThunderInterfaces --target install

.github/workflows/MacOS build template.yml

@@ -67,8 +67,6 @@ jobs:
       run: |
         source venv/bin/activate
         cmake -G Ninja -S ThunderInterfaces -B ${{matrix.build_type}}/build/ThunderInterfaces \
-        -DCMAKE_CXX_FLAGS="-Wall -Wextra -Wpedantic -Werror" \
-        -DCMAKE_C_FLAGS="-Wall -Wextra -Wpedantic -Werror" \
         -DCMAKE_INSTALL_PREFIX="${{matrix.build_type}}/install/usr" \
         -DCMAKE_MODULE_PATH="${PWD}/${{matrix.build_type}}/install/usr/include/WPEFramework/Modules"
         cmake --build ${{matrix.build_type}}/build/ThunderInterfaces --target install

CMakeLists.txt

@@ -24,25 +24,6 @@ find_package(Thunder)
 set(INTERFACES_PATTERNS "I*.h" CACHE STRING "Patterns matching files for which stubs should be generated")
 set(JSONRPC_PATTERNS "*.json" CACHE STRING "Patterns matching files for which json stubs should be generated")
 
-if(ENABLE_STRICT_COMPILER_SETTINGS)
-    if(CMAKE_CXX_COMPILER_ID MATCHES "Clang")
-        message(FATAL_ERROR "Compiling with Clang")
-        set(CMAKE_STRICT_COMPILER_SETTINGS "-Weverything -Wextra -Wpedantic -Werror")
-        set(CMAKE_STRICT_CXX_COMPILER_SETTINGS "${CMAKE_STRICT_COMPILER_SETTINGS} -Wnon-virtual-dtor")
-    elseif(${CMAKE_COMPILER_IS_GNUCXX})
-        message(STATUS "Compiling with GCC")
-        set(CMAKE_STRICT_COMPILER_SETTINGS "-Wall -Wextra -Wpedantic -Werror")
-        set(CMAKE_STRICT_CXX_COMPILER_SETTINGS "${CMAKE_STRICT_COMPILER_SETTINGS} -Wnon-virtual-dtor")
-    elseif(CMAKE_CXX_COMPILER_ID MATCHES "MSVC")
-        message(STATUS "Compiling with MS Visual Studio")
-        set(CMAKE_STRICT_COMPILER_SETTINGS "/W4")
-    else()
-        message(STATUS "Compiler ${CMAKE_CXX_COMPILER_ID}")
-    endif()
-    set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} ${CMAKE_STRICT_CXX_COMPILER_SETTINGS}")
-    set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} ${CMAKE_STRICT_COMPILER_SETTINGS}")
-endif()
-
 if (BUILD_REFERENCE)
     add_definitions (-DBUILD_REFERENCE=${BUILD_REFERENCE})
 endif()