[Actions][Linux] Add more plugins to be built, fix all compile warnings and errors (#946)

* Fix all the build issues to make it possible to build more stuff in Actions

* Update Linux build template with new packages and plugins

Added additional packages and plugin options for build.

* Update ThunderNanoServices workflow to use development branch

* Fix PKG_CONFIG_PATH export for architecture

* Fix some compile errors on the MinSizeRel version

* Use PRIu64 to print long long unsigned int to work on both 32 and 64 bit

* Use the macro to suppress the release warning instead

* Update ThunderNanoServices workflow to use master branch

* Update examples/IOConnectorTest/CMakeLists.txt

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update examples/IOConnectorTest/Module.h

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Define EXTERNAL in Module.h

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Author: VeithMetro

.github/workflows/Linux build template.yml

@@ -44,8 +44,10 @@ jobs:
         PKGS="python3-venv python3-pip build-essential cmake ninja-build libusb-1.0-0-dev"
         if [ "${{ matrix.architecture }}" = "32" ]; then
           PKGS="$PKGS zlib1g-dev:i386 libssl-dev:i386 libsbc-dev:i386 gcc-13-multilib g++-13-multilib"
+          PKGS="$PKGS libicu-dev:i386 libpng-dev:i386 libdrm-dev:i386 libgbm-dev:i386 libegl-dev:i386 libgles2-mesa-dev:i386"
         else
           PKGS="$PKGS zlib1g-dev libssl-dev libsbc-dev"
+          PKGS="$PKGS libicu-dev libpng-dev libdrm-dev libgbm-dev libegl-dev libgles2-mesa-dev"
         fi
         for attempt in {1..4}; do
           if sudo apt-get install -y --no-install-recommends $PKGS; then
@@ -94,18 +96,32 @@ jobs:
     - name: Build ThunderNanoServices
       run: |
         source venv/bin/activate
+        ${{matrix.architecture == '32' && 'export PKG_CONFIG_PATH=/usr/lib/i386-linux-gnu/pkgconfig:$PKG_CONFIG_PATH' || 'PKG_CONFIG_PATH=/usr/lib/x86_64-linux-gnu/pkgconfig:$PKG_CONFIG_PATH'}}
         cmake -G Ninja -S ThunderNanoServices -B ${{matrix.build_type}}/build/ThunderNanoServices \
         -DCMAKE_CXX_FLAGS="-Wall -Wextra -Wpedantic -Werror -m${{matrix.architecture}}" \
         -DCMAKE_C_FLAGS="-Wall -Wextra -Wpedantic -Werror -m${{matrix.architecture}}" \
         -DCMAKE_INSTALL_PREFIX="${{matrix.build_type}}/install/usr" \
         -DCMAKE_MODULE_PATH="${PWD}/${{matrix.build_type}}/install/usr/include/WPEFramework/Modules" \
+        -DEXAMPLE_CLIENT_SERVER=ON \
         -DEXAMPLE_COMRPCCLIENT=ON \
+        -DEXAMPLE_CUSTOMCODE_EXAMPLE=ON \
+        -DEXAMPLE_DYNAMICJSONRPCERRORMESSAGE_EXAMPLE=ON \
+        -DEXAMPLE_DYNAMICLOADING=ON \
+        -DEXAMPLE_DYNAMICLOADING_YIN=ON \
+        -DEXAMPLE_DYNAMICLOADING_YANG=ON \
+        -DEXAMPLE_GENERATORSHOWCASE_EXAMPLE=ON \
+        -DEXAMPLE_IOCONNECTOR_TEST=ON \
+        -DEXAMPLE_MESSAGECONTROL_UDP_CLIENT=ON \
+        -DEXAMPLE_PLUGINSMARTINTERFACETYPE_EXAMPLE=ON \
+        -DEXAMPLE_SIMPLECOMRPC_TEST=ON \
         -DPLUGIN_BLUETOOTH=ON \
         -DPLUGIN_BLUETOOTHREMOTECONTROL=ON \
         -DPLUGIN_BLUETOOTHAUDIO=ON \
         -DPLUGIN_BLUETOOTHSDPSERVER=ON \
         -DPLUGIN_CECCONTROL=ON \
         -DPLUGIN_COMMANDER=ON \
+        -DPLUGIN_COMPOSITOR=ON \
+        -DPLUGIN_COMPOSITOR_IMPLEMENTATION=RPI \
         -DPLUGIN_CONFIGUPDATEEXAMPLE=ON \
         -DPLUGIN_DHCPSERVER=ON \
         -DPLUGIN_DIALSERVER=ON \
@@ -114,19 +130,32 @@ jobs:
         -DPLUGIN_INPUTSWITCH=ON \
         -DPLUGIN_IOCONNECTOR=ON \
         -DPLUGIN_JSONRPC=ON \
+        -DPLUGIN_JSONRPCMUXER=ON \
+        -DPLUGIN_LANGUAGEADMINISTRATOR=ON \
         -DPLUGIN_NETWORKCONTROL=ON \
         -DPLUGIN_OUTOFPROCESS=ON \
+        -DPLUGIN_PERFORMANCEMONITOR=ON \
+        -DPLUGIN_PLUGININITIALIZERSERVICE=ON \
+        -DPLUGIN_POWER=ON \
+        -DPLUGIN_PROCESSCONTAINERS=ON \
         -DPLUGIN_PROCESSMONITOR=ON \
+        -DPLUGIN_REMOTECONTROL=ON \
         -DPLUGIN_RESOURCEMONITOR=ON \
+        -DPLUGIN_SNAPSHOT=ON \
         -DPLUGIN_STATECONTROLLER=ON \
+        -DPLUGIN_SUBSYSTEMCONTROLLER=ON \
         -DPLUGIN_SWITCHBOARD=ON \
         -DPLUGIN_SYSTEMCOMMANDS=ON \
         -DPLUGIN_TESTCONTROLLER=ON \
+        -DPLUGIN_TESTPRIORITYQUEUE=ON \
+        -DPLUGIN_TESTTEXTOPTIONS=ON \
         -DPLUGIN_TESTUTILITY=ON \
+        -DPLUGIN_TIMESYNC=ON \
         -DPLUGIN_WEBPROXY=ON \
         -DPLUGIN_WEBSERVER=ON \
         -DPLUGIN_WEBSHELL=ON \
         -DPLUGIN_WIFICONTROL=ON \
+        -DPLUGIN_VOLUMECONTROL=ON \
         -DSTORE_TEST=ON \
         -DTEST_AUTOMATION_TOOLS=ON \
         ${{steps.plugins.outputs.first_match}}

Power/PowerImplementation/Linux/PowerImplementation.cpp

@@ -130,7 +130,9 @@ class PowerImplementation {
             if (_triggerFile < 0) {
                 TRACE(Trace::Error, (_T("Not able to access %s."), TriggerFile));
             } else {
+PUSH_WARNING(DISABLE_WARNING_UNUSED_RESULT)
                 ::write(_triggerFile, "0", 1);
+POP_WARNING()
             }
         }
     }
@@ -213,6 +215,7 @@ class PowerImplementation {
                     case Exchange::IPower::PCState::PassiveStandby: break;
                     case Exchange::IPower::PCState::SuspendToRAM:
                         {
+PUSH_WARNING(DISABLE_WARNING_UNUSED_RESULT)
                             ::write(_triggerFile, "1", 1);
                             /* We will be able to write state only if we are in 'On' State. */
                             ::write(_stateFile, newMode->label, newMode->length);
@@ -221,14 +224,17 @@ class PowerImplementation {
                             ::read(_triggerFile, &value, 1);
                             /* Reset the early wakeup trigger for low level drivers. */
                             ::write(_triggerFile, "0", 1);
+POP_WARNING()
                             /* Reset the State to 'On' once device wakes-up. */
                             RevokeJob();
                             SetState(Exchange::IPower::PCState::On, 0);
                         }
                         break;
                     case Exchange::IPower::PCState::Hibernate: break;
                     case Exchange::IPower::PCState::PowerOff:
+PUSH_WARNING(DISABLE_WARNING_UNUSED_RESULT)
                         system("poweroff");
+POP_WARNING()
                         break;
                     default:
                         TRACE(Trace::Error, (_T("Should not reach here at any case...!!!")));

examples/DynamicLoading/Yin/YinImplementation.cpp

@@ -200,7 +200,7 @@ namespace Plugin {
                 Core::File dataFile(_service->DataPath() + _dataFile);
 
                 if (dataFile.Open(true) == true) {
-                    const uint64_t size = std::min(dataFile.Size(), 4096ULL);
+                    const uint64_t size = std::min(dataFile.Size(), static_cast<uint64_t>(4096));
                     uint8_t *data = static_cast<uint8_t*>(ALLOCA(size + 1));
                     ASSERT(data != nullptr);
                     dataFile.Read(data, size);

examples/IOConnectorTest/CMakeLists.txt

@@ -33,7 +33,12 @@ find_package(${NAMESPACE}Messaging REQUIRED)
 find_package(${NAMESPACE}WebSocket REQUIRED)
 find_package(CompileSettingsDebug CONFIG REQUIRED)
 
-add_executable(${MODULE_NAME} IOConnectorTest.cpp)
+set(IOCONNECTOR_TEST_SOURCES
+        IOConnectorTest.cpp
+        Module.cpp
+)
+
+add_executable(${MODULE_NAME} ${IOCONNECTOR_TEST_SOURCES})
 
 set_target_properties(${MODULE_NAME} PROPERTIES
         CXX_STANDARD 11

examples/IOConnectorTest/IOConnectorTest.cpp

@@ -17,16 +17,7 @@
  * limitations under the License.
  */
 
-#ifndef MODULE_NAME
-#define MODULE_NAME IOConnectorTest
-#endif
-
-#include <com/com.h>
-#include <core/core.h>
-#include <websocket/websocket.h>
-
-#include <interfaces/IExternal.h>
-#include <interfaces/IInputPin.h>
+#include "Module.h"
 
 #define INPUT_PIN_ID    16
 #define OUTPUT_PIN_ID   20

examples/IOConnectorTest/Module.cpp

@@ -0,0 +1,22 @@
+ /*
+ * If not stated otherwise in this file or this component's LICENSE file the
+ * following copyright and licenses apply:
+ *
+ * Copyright 2020 Metrological
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+#include "Module.h"
+
+MODULE_NAME_DECLARATION(BUILD_REFERENCE)

examples/IOConnectorTest/Module.h

@@ -0,0 +1,34 @@
+ /*
+ * If not stated otherwise in this file or this component's LICENSE file the
+ * following copyright and licenses apply:
+ *
+ * Copyright 2020 Metrological
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+ 
+#pragma once
+
+#ifndef MODULE_NAME
+#define MODULE_NAME IOConnectorTest
+#endif
+
+#include <com/com.h>
+#include <core/core.h>
+#include <websocket/websocket.h>
+
+#include <interfaces/IExternal.h>
+#include <interfaces/IInputPin.h>
+
+#undef EXTERNAL
+#define EXTERNAL

examples/SimpleCOMRPC/Client/SimpleCOMRPCClient.cpp

@@ -244,7 +244,7 @@ int main(int argc, char* argv[])
                     printf("We do not have a clock interface, so we can not get the time\n");
                 }
                 else {
-                    printf("The Ticker is at: %lu\n", clock->Now());
+                    printf("The Ticker is at: %" PRIu64 "\n", clock->Now());
                 }
                 break;
             case 'T':

examples/SimpleCOMRPCServer/SimpleCOMRPCServer.cpp

@@ -41,7 +41,7 @@ class COMServer : public RPC::Communicator {
                 Notifier(const uint16_t period, Exchange::IWallClock::ICallback* callback)
                     : _period(period)
                     , _ticks(Core::Time::Now().Add(_period * 1000).Ticks())
-                    , _callback(_callback) {
+                    , _callback(callback) {
                     _callback->AddRef();
                 }
                 ~Notifier() {
@@ -242,7 +242,7 @@ POP_WARNING()
     }
 
 private:
-    void* Acquire(const string& className, const uint32_t interfaceId, const uint32_t versionId) override
+    void* Acquire(const string& /* className */, const uint32_t interfaceId, const uint32_t versionId) override
     {
         void* result = nullptr;
 

examples/testconsole/CMakeLists.txt

@@ -18,6 +18,7 @@ find_package(CompileSettingsDebug CONFIG REQUIRED)
 
 set (PLUGIN_TEST_TESTCONSOLE_SOURCES
         testconsole.cpp
+        Module.cpp
         ../testserver/DataContainer.cpp
 )