Skip to content

Commit 08b4966

Browse files
lashminthalashmintha
committed
VPLAY-11225 [Tech Debt] mediafailed event enhancements ( minor code etc )
Reason for change: Added minor code for MediaFailedEvent Risks: Low Test Procedure: Refer jira ticket Priority: P1 Signed-off-by: lashmintha <[email protected]>
1 parent 03cdd02 commit 08b4966

File tree

9 files changed

+370
-132
lines changed

9 files changed

+370
-132
lines changed

‎AAMP-UVE-API.md‎

Lines changed: 45 additions & 40 deletions
Original file line numberDiff line numberDiff line change
@@ -2420,46 +2420,51 @@ When a player instance is no longer needed, recommend to call explicit release()
24202420

24212421
## Universal Video Engine Player Errors
24222422

2423-
| Error Code | Code | Error String |
2424-
| ---- | ---- | ----- |
2425-
| AAMP_TUNE_INIT_FAILED | 10 | AAMP: init failed |
2426-
| AAMP_TUNE_INIT_FAILED_MANIFEST_DNLD_ERROR | 10 | AAMP: init failed (unable to download manifest) |
2427-
| AAMP_TUNE_INIT_FAILED_MANIFEST_CONTENT_ERROR | 10 | AAMP: init failed (manifest missing tracks) |
2428-
| AAMP_TUNE_INIT_FAILED_MANIFEST_PARSE_ERROR | 10 | AAMP: init failed (corrupt/invalid manifest) |
2429-
| AAMP_TUNE_INIT_FAILED_TRACK_SYNC_ERROR | 10 | AAMP: init failed (unsynchronized tracks) |
2430-
| AAMP_TUNE_MANIFEST_REQ_FAILED | 10 | AAMP: Manifest Download failed; Playlist refresh failed |
2431-
| AAMP_TUNE_INIT_FAILED_PLAYLIST_VIDEO_DNLD_ERROR | 10 | AAMP: init failed (unable to download video playlist) |
2432-
| AAMP_TUNE_INIT_FAILED_PLAYLIST_AUDIO_DNLD_ERROR | 10 | AAMP: init failed (unable to download audio playlist) |
2433-
| AAMP_TUNE_FRAGMENT_DOWNLOAD_FAILURE | 10 | AAMP: fragment download failures |
2434-
| AAMP_TUNE_INIT_FRAGMENT_DOWNLOAD_FAILURE | 10 | AAMP: init fragment download failed |
2435-
| AAMP_TUNE_INVALID_MANIFEST_FAILURE | 10 | AAMP: Invalid Manifest, parse failed |
2436-
| AAMP_TUNE_MP4_INIT_FRAGMENT_MISSING | 10 | AAMP: init fragments missing in playlist |
2437-
| AAMP_TUNE_CONTENT_NOT_FOUND | 20 | AAMP: Resource was not found at the URL(HTTP 404) |
2438-
| AAMP_TUNE_AUTHORIZATION_FAILURE | 40 | AAMP: Authorization failure |
2439-
| AAMP_TUNE_UNTRACKED_DRM_ERROR | 50 | AAMP: DRM error untracked error |
2440-
| AAMP_TUNE_DRM_INIT_FAILED | 50 | AAMP: DRM Initialization Failed |
2441-
| AAMP_TUNE_DRM_DATA_BIND_FAILED | 50 | AAMP: InitData-DRM Binding Failed |
2442-
| AAMP_TUNE_DRM_SESSIONID_EMPTY | 50 | AAMP: DRM Session ID Empty |
2443-
| AAMP_TUNE_DRM_CHALLENGE_FAILED | 50 | AAMP: DRM License Challenge Generation Failed |
2444-
| AAMP_TUNE_LICENCE_TIMEOUT | 50 | AAMP: DRM License Request Timed out |
2445-
| AAMP_TUNE_LICENCE_REQUEST_FAILED | 50 | AAMP: DRM License Request Failed |
2446-
| AAMP_TUNE_INVALID_DRM_KEY | 50 | AAMP: Invalid Key Error, from DRM |
2447-
| AAMP_TUNE_UNSUPPORTED_STREAM_TYPE | 60 | AAMP: Unsupported Stream Type. Unable to determine stream type for DRM Init |
2448-
| AAMP_TUNE_UNSUPPORTED_AUDIO_TYPE | 60 | AAMP: No supported Audio Types in Manifest |
2449-
| AAMP_TUNE_FAILED_TO_GET_KEYID | 50 | AAMP: Failed to parse key id from PSSH |
2450-
| AAMP_TUNE_FAILED_TO_GET_ACCESS_TOKEN | 50 | AAMP: Failed to get access token from Auth Service |
2451-
| AAMP_TUNE_CORRUPT_DRM_METADATA | 50 | AAMP: DRM failure due to Bad DRMMetadata in stream |
2452-
| AAMP_TUNE_DRM_DECRYPT_FAILED | 50 | AAMP: DRM Decryption Failed for Fragments |
2453-
| AAMP_TUNE_DRM_UNSUPPORTED | 50 | AAMP: DRM format Unsupported |
2454-
| AAMP_TUNE_DRM_SELF_ABORT | 50 | AAMP: DRM license request aborted by player |
2455-
| AAMP_TUNE_DRM_KEY_UPDATE_FAILED | 50 | AAMP: Failed to process DRM key |
2456-
| AAMP_TUNE_CORRUPT_DRM_DATA | 51 | AAMP: DRM failure due to Corrupt DRM files |
2457-
| AAMP_TUNE_DEVICE_NOT_PROVISIONED | 52 | AAMP: Device not provisioned |
2458-
| AAMP_TUNE_HDCP_COMPLIANCE_ERROR | 53 | AAMP: HDCP Compliance Check Failure |
2459-
| AAMP_TUNE_GST_PIPELINE_ERROR | 80 | AAMP: Error from gstreamer pipeline |
2460-
| AAMP_TUNE_FAILED_PTS_ERROR | 80 | AAMP: Playback failed due to PTS error |
2461-
| AAMP_TUNE_PLAYBACK_STALLED | 7600 | AAMP: Playback was stalled due to lack of new fragments |
2462-
| AAMP_TUNE_FAILURE_UNKNOWN | 100 | AAMP: Unknown Failure |
2423+
| Error Code | Code | MinorCode | Error String |
2424+
| ---- | ---- | ----- | ----- |
2425+
| AAMP_TUNE_INIT_FAILED | 10 | 1001 | AAMP: init failed |
2426+
| AAMP_TUNE_INIT_FAILED_MANIFEST_DNLD_ERROR | 10 | 1002 | AAMP: init failed (unable to download manifest) |
2427+
| AAMP_TUNE_INIT_FAILED_MANIFEST_CONTENT_ERROR | 10 | 1003 | AAMP: init failed (manifest missing tracks) |
2428+
| AAMP_TUNE_INIT_FAILED_MANIFEST_PARSE_ERROR | 10 | 1004 | AAMP: init failed (corrupt/invalid manifest) |
2429+
| AAMP_TUNE_INIT_FAILED_PLAYLIST_VIDEO_DNLD_ERROR | 10 | 1005 | AAMP: init failed (unable to download video playlist) |
2430+
| AAMP_TUNE_INIT_FAILED_PLAYLIST_AUDIO_DNLD_ERROR | 10 | 1006 | AAMP: init failed (unable to download audio playlist) |
2431+
| AAMP_TUNE_INIT_FAILED_TRACK_SYNC_ERROR | 10 | 1007 | AAMP: init failed (unsynchronized tracks) |
2432+
| AAMP_TUNE_CONTENT_NOT_FOUND | 20 | 2001 | AAMP: Resource was not found at the URL(HTTP 404) |
2433+
| AAMP_TUNE_MANIFEST_REQ_FAILED | 30 | 3001 | AAMP: Manifest Download failed |
2434+
| AAMP_TUNE_FRAGMENT_DOWNLOAD_FAILURE | 30 | 3002 | AAMP: fragment download failures |
2435+
| AAMP_TUNE_INIT_FRAGMENT_DOWNLOAD_FAILURE | 30 | 3003 | AAMP: init fragment download failed |
2436+
| AAMP_TUNE_INVALID_MANIFEST_FAILURE | 30 | 3004 | AAMP: Invalid Manifest, parse failed |
2437+
| AAMP_TUNE_MP4_INIT_FRAGMENT_MISSING | 30 | 3005 | AAMP: init fragments missing in playlist |
2438+
| AAMP_TUNE_DNS_RESOLVE_TIMEOUT | 30 | 3006 | AAMP: Manifest download failed due to DNS resolve timeout |
2439+
| AAMP_TUNE_CURL_CONNECTION_TIMEOUT | 30 | 3007 | AAMP: Manifest download failed due to connection timeout |
2440+
| AAMP_TUNE_DATA_TRANSFER_TIMEOUT | 30 | 3008 | AAMP: Manifest download failed due to data transfer timeout |
2441+
| AAMP_TUNE_AUTHORIZATION_FAILURE | 40 | 4001 | AAMP: Authorization failure |
2442+
| AAMP_TUNE_UNTRACKED_DRM_ERROR | 50 | 5001 | AAMP: DRM error untracked error |
2443+
| AAMP_TUNE_DRM_INIT_FAILED | 50 | 5002 | AAMP: DRM Initialization Failed |
2444+
| AAMP_TUNE_DRM_DATA_BIND_FAILED | 50 | 5003 | AAMP: InitData-DRM Binding Failed |
2445+
| AAMP_TUNE_DRM_SESSIONID_EMPTY | 50 | 5004 | AAMP: DRM Session ID Empty |
2446+
| AAMP_TUNE_DRM_CHALLENGE_FAILED | 50 | 5005 | AAMP: DRM License Challenge Generation Failed |
2447+
| AAMP_TUNE_LICENCE_TIMEOUT | 50 | 5006 | AAMP: DRM License Request Timed out |
2448+
| AAMP_TUNE_LICENCE_REQUEST_FAILED | 50 | 5007 | AAMP: DRM License Request Failed |
2449+
| AAMP_TUNE_INVALID_DRM_KEY | 50 | 5008 | AAMP: Invalid Key Error, from DRM |
2450+
| AAMP_TUNE_FAILED_TO_GET_KEYID | 50 | 5009 | AAMP: Failed to parse key id from PSSH |
2451+
| AAMP_TUNE_CORRUPT_DRM_DATA | 50 | 5010 | AAMP: DRM failure due to Corrupt DRM files |
2452+
| AAMP_TUNE_CORRUPT_DRM_METADATA | 50 | 5011 | AAMP: DRM failure due to Bad DRMMetadata in stream |
2453+
| AAMP_TUNE_DRM_DECRYPT_FAILED | 50 | 5012 | AAMP: DRM Decryption Failed for Fragments |
2454+
| AAMP_TUNE_DRM_UNSUPPORTED | 50 | 5013 | AAMP: DRM format Unsupported |
2455+
| AAMP_TUNE_DRM_SELF_ABORT | 50 | 5014 | AAMP: DRM license request aborted by player |
2456+
| AAMP_TUNE_FAILED_TO_GET_ACCESS_TOKEN | 50 | 5015 | AAMP: Failed to get access token from Auth Service |
2457+
| AAMP_TUNE_DRM_KEY_UPDATE_FAILED | 50 | 5016 | AAMP: Failed to process DRM key |
2458+
| AAMP_TUNE_DEVICE_NOT_PROVISIONED | 51 | 5101 | AAMP: Device not provisioned |
2459+
| AAMP_TUNE_HDCP_COMPLIANCE_ERROR | 52 | 5201 | AAMP: HDCP Compliance Check Failure |
2460+
2461+
| AAMP_TUNE_UNSUPPORTED_STREAM_TYPE | 60 | 6001 | AAMP: Unsupported Stream Type |
2462+
| AAMP_TUNE_UNSUPPORTED_AUDIO_TYPE | 60 | 6002 | AAMP: No supported Audio Types in Manifest |
2463+
| AAMP_TUNE_GST_PIPELINE_ERROR | 80 | 8001 | AAMP: Error from gstreamer pipeline |
2464+
| AAMP_TUNE_FAILED_PTS_ERROR | 80 | 8002 | AAMP: Playback failed due to PTS error |
2465+
2466+
| AAMP_TUNE_PLAYBACK_STALLED | 7600 | 0 | AAMP: Playback was stalled due to lack of new fragments |
2467+
| AAMP_TUNE_FAILURE_UNKNOWN | 100 | 0 | AAMP: Unknown Failure |
24632468

24642469
---
24652470

‎AampEvent.cpp‎

Lines changed: 13 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -49,8 +49,8 @@ AAMPEventType AAMPEventObject::getType() const
4949
/**
5050
* @brief MediaErrorEvent Constructor
5151
*/
52-
MediaErrorEvent::MediaErrorEvent(AAMPTuneFailure failure, int code, const std::string &desc, bool shouldRetry, int classCode, int reason, int businessStatus, const std::string &responseData, std::string sid):
53-
AAMPEventObject(AAMP_EVENT_TUNE_FAILED, std::move(sid)), mFailure(failure), mCode(code),
52+
MediaErrorEvent::MediaErrorEvent(AAMPTuneFailure failure, int code, int minorCode, const std::string &desc, bool shouldRetry, int classCode, int reason, int businessStatus, const std::string &responseData, std::string sid):
53+
AAMPEventObject(AAMP_EVENT_TUNE_FAILED, std::move(sid)), mFailure(failure), mCode(code), mMinorCode(minorCode),
5454
mDescription(desc), mShouldRetry(shouldRetry), mSecManagerClass(classCode), mSecManagerReasonCode(reason), mBusinessStatus(businessStatus), mResponseData(responseData)
5555
{
5656

@@ -67,15 +67,23 @@ AAMPTuneFailure MediaErrorEvent::getFailure() const
6767
}
6868

6969
/**
70-
* @brief Get Error Code
70+
* @brief Get Major Code
7171
*
72-
* @return Tune error code
72+
* @return Major code
7373
*/
7474
int MediaErrorEvent::getCode() const
7575
{
7676
return mCode;
7777
}
78-
78+
/**
79+
* @brief Get Minor Code
80+
*
81+
* @return Minor code
82+
*/
83+
int MediaErrorEvent::getMinorCode() const
84+
{
85+
return mMinorCode;
86+
}
7987
/**
8088
* @brief Get Description
8189
*

‎AampEvent.h‎

Lines changed: 66 additions & 37 deletions
Original file line numberDiff line numberDiff line change
@@ -123,40 +123,63 @@ typedef enum
123123
AAMP_TUNE_INIT_FAILED_PLAYLIST_VIDEO_DNLD_ERROR, /**< Tune failure due to video playlist download error*/
124124
AAMP_TUNE_INIT_FAILED_PLAYLIST_AUDIO_DNLD_ERROR, /**< Tune failure due to audio playlist download error*/
125125
AAMP_TUNE_INIT_FAILED_TRACK_SYNC_ERROR, /**< Tune failure due to A/V track sync error*/
126-
AAMP_TUNE_MANIFEST_REQ_FAILED, /**< Tune failure caused by manifest fetch failure*/
127-
AAMP_TUNE_AUTHORIZATION_FAILURE, /**< Not authorized to view the content*/
128-
AAMP_TUNE_FRAGMENT_DOWNLOAD_FAILURE, /**< When fragment download fails for 5 consecutive fragments*/
129-
AAMP_TUNE_INIT_FRAGMENT_DOWNLOAD_FAILURE, /**< Unable to download init fragment*/
130-
AAMP_TUNE_UNTRACKED_DRM_ERROR, /**< DRM error*/
131-
AAMP_TUNE_DRM_INIT_FAILED, /**< DRM initialization failure */
132-
AAMP_TUNE_DRM_DATA_BIND_FAILED, /**< InitData binding with DRM failed */
133-
AAMP_TUNE_DRM_SESSIONID_EMPTY, /**< DRM session ID empty */
134-
AAMP_TUNE_DRM_CHALLENGE_FAILED, /**< DRM key request challenge generation failed */
135-
AAMP_TUNE_LICENCE_TIMEOUT, /**< DRM license request timeout */
136-
AAMP_TUNE_LICENCE_REQUEST_FAILED, /**< DRM license got invalid response */
137-
AAMP_TUNE_INVALID_DRM_KEY, /**< DRM reporting invalid license key */
138-
AAMP_TUNE_UNSUPPORTED_STREAM_TYPE, /**< Unsupported stream type */
139-
AAMP_TUNE_UNSUPPORTED_AUDIO_TYPE, /**< Unsupported audio type in manifest */
140-
AAMP_TUNE_FAILED_TO_GET_KEYID, /**< Failed to parse key id from init data*/
141-
AAMP_TUNE_FAILED_TO_GET_ACCESS_TOKEN, /**< Failed to get session token from AuthService*/
142-
AAMP_TUNE_CORRUPT_DRM_DATA, /**< DRM failure due to corrupt drm data, self heal might clear further errors*/
143-
AAMP_TUNE_CORRUPT_DRM_METADATA, /**< DRM failure due to corrupt drm metadata in the stream*/
144-
AAMP_TUNE_DRM_DECRYPT_FAILED, /**< DRM Decryption Failed for Fragments */
145-
AAMP_TUNE_DRM_UNSUPPORTED, /**< DRM Format Unsupported */
146-
AAMP_TUNE_DRM_SELF_ABORT, /**< Download activity is aborted by player */
147-
AAMP_TUNE_GST_PIPELINE_ERROR, /**< Playback failure due to error from GStreamer pipeline or associated plugins */
148-
AAMP_TUNE_PLAYBACK_STALLED, /**< Playback was stalled due to valid fragments not available in playlist */
149-
AAMP_TUNE_CONTENT_NOT_FOUND, /**< The resource was not found at the URL provided (HTTP 404) */
150-
AAMP_TUNE_DRM_KEY_UPDATE_FAILED, /**< Failed to process DRM key, see the error code returned from Update() for more info */
151-
AAMP_TUNE_DEVICE_NOT_PROVISIONED, /**< STB not provisioned/corrupted; need to re-provision. */
152-
AAMP_TUNE_HDCP_COMPLIANCE_ERROR, /**< HDCP Compliance Check failure.Not compatible hdcp version for playback */
153-
AAMP_TUNE_INVALID_MANIFEST_FAILURE, /**< Manifest is invalid */
154-
AAMP_TUNE_FAILED_PTS_ERROR, /**< Playback failed due to PTS error */
155-
AAMP_TUNE_MP4_INIT_FRAGMENT_MISSING, /**< Init fragments missing in playlist */
156-
AAMP_TUNE_DNS_RESOLVE_TIMEOUT,
157-
AAMP_TUNE_CURL_CONNECTION_TIMEOUT,
158-
AAMP_TUNE_DATA_TRANSFER_TIMEOUT,
159-
AAMP_TUNE_FAILURE_UNKNOWN /**< Unknown failure */
126+
127+
128+
//Resource failure
129+
AAMP_TUNE_CONTENT_NOT_FOUND, /**< The resource was not found at the URL provided (HTTP 404) */
130+
131+
//Download failure
132+
AAMP_TUNE_MANIFEST_REQ_FAILED, /**< Tune failure caused by manifest fetch failure*/
133+
AAMP_TUNE_FRAGMENT_DOWNLOAD_FAILURE, /**< When fragment download fails for 5 consecutive fragments*/
134+
AAMP_TUNE_INIT_FRAGMENT_DOWNLOAD_FAILURE, /**< Unable to download init fragment*/
135+
AAMP_TUNE_INVALID_MANIFEST_FAILURE, /**< Manifest is invalid */
136+
AAMP_TUNE_MP4_INIT_FRAGMENT_MISSING, /**< Init fragments missing in playlist */
137+
AAMP_TUNE_DNS_RESOLVE_TIMEOUT, /**< DNS resolve timedout */
138+
AAMP_TUNE_CURL_CONNECTION_TIMEOUT, /**< Curl connection timedout */
139+
AAMP_TUNE_DATA_TRANSFER_TIMEOUT, /**< Data transfer timedout */
140+
141+
//Authorization failure
142+
AAMP_TUNE_AUTHORIZATION_FAILURE, /**< Not authorized to view the content*/
143+
144+
//DRM Failure
145+
AAMP_TUNE_UNTRACKED_DRM_ERROR, /**< DRM error*/
146+
AAMP_TUNE_DRM_INIT_FAILED, /**< DRM initialization failure */
147+
AAMP_TUNE_DRM_DATA_BIND_FAILED, /**< InitData binding with DRM failed */
148+
AAMP_TUNE_DRM_SESSIONID_EMPTY, /**< DRM session ID empty */
149+
AAMP_TUNE_DRM_CHALLENGE_FAILED, /**< DRM key request challenge generation failed */
150+
AAMP_TUNE_LICENCE_TIMEOUT, /**< DRM license request timeout */
151+
AAMP_TUNE_LICENCE_REQUEST_FAILED, /**< DRM license got invalid response */
152+
AAMP_TUNE_INVALID_DRM_KEY, /**< DRM reporting invalid license key */
153+
AAMP_TUNE_FAILED_TO_GET_KEYID, /**< Failed to parse key id from init data*/
154+
AAMP_TUNE_CORRUPT_DRM_DATA, /**< DRM failure due to corrupt drm data, self heal might clear further errors*/
155+
AAMP_TUNE_CORRUPT_DRM_METADATA, /**< DRM failure due to corrupt drm metadata in the stream*/
156+
AAMP_TUNE_DRM_DECRYPT_FAILED, /**< DRM Decryption Failed for Fragments */
157+
AAMP_TUNE_DRM_UNSUPPORTED, /**< DRM Format Unsupported */
158+
AAMP_TUNE_DRM_SELF_ABORT, /**< Download activity is aborted by player */
159+
AAMP_TUNE_FAILED_TO_GET_ACCESS_TOKEN, /**< Failed to get session token from AuthService*/
160+
AAMP_TUNE_DRM_KEY_UPDATE_FAILED, /**< Failed to process DRM key, see the error code returned from Update() for more info */
161+
162+
163+
164+
//Provisioning failure
165+
AAMP_TUNE_DEVICE_NOT_PROVISIONED, /**< STB not provisioned/corrupted; need to re-provision. */
166+
167+
//Hdcp failure
168+
AAMP_TUNE_HDCP_COMPLIANCE_ERROR, /**< HDCP Compliance Check failure.Not compatible hdcp version for playback */
169+
170+
//Stream failure
171+
AAMP_TUNE_UNSUPPORTED_STREAM_TYPE, /**< Unsupported stream type */
172+
AAMP_TUNE_UNSUPPORTED_AUDIO_TYPE, /**< Unsupported audio type in manifest */
173+
174+
//Gstreamer error
175+
AAMP_TUNE_GST_PIPELINE_ERROR, /**< Playback failed due to an error in the GStreamer pipeline */
176+
AAMP_TUNE_FAILED_PTS_ERROR, /**< Playback failed due to PTS error */
177+
178+
//Playback failure
179+
AAMP_TUNE_PLAYBACK_STALLED, /**< Playback was stalled due to valid fragments not available in playlist */
180+
181+
//Unknown failure
182+
AAMP_TUNE_FAILURE_UNKNOWN
160183
} AAMPTuneFailure;
161184

162185
/**
@@ -383,7 +406,8 @@ struct AAMPEvent
383406
struct
384407
{
385408
AAMPTuneFailure failure; /**< Error Type */
386-
int code; /**< Error code */
409+
int code;
410+
int minorCode; /**< Error code */
387411
const char *description; /**< Error description */
388412
bool shouldRetry; /**< If recovery on retry is possible */
389413
int32_t classCode; /**< class Code */
@@ -620,6 +644,7 @@ class MediaErrorEvent: public AAMPEventObject
620644
{
621645
AAMPTuneFailure mFailure; /**< Error Type */
622646
int mCode; /**< Error code */
647+
int mMinorCode;
623648
std::string mDescription; /**< Error description */
624649
std::string mResponseData; /**< Response Data */
625650
bool mShouldRetry; /**< If recovery on retry is possible */
@@ -638,10 +663,11 @@ class MediaErrorEvent: public AAMPEventObject
638663
*
639664
* @param[in] failure - Failure type
640665
* @param[in] code - Error code
666+
* @param[in] minorCode - Error code
641667
* @param[in] desc - Error description
642668
* @param[in] shouldRetry - Retry or not
643669
*/
644-
MediaErrorEvent(AAMPTuneFailure failure, int code, const std::string &desc, bool shouldRetry, int32_t classCode, int32_t reason, int32_t businessStatus, const std::string &responseData, std::string sid);
670+
MediaErrorEvent(AAMPTuneFailure failure, int code, int minorCode, const std::string &desc, bool shouldRetry, int32_t classCode, int32_t reason, int32_t businessStatus, const std::string &responseData, std::string sid);
645671

646672
/**
647673
* @brief MediaErrorEvent Destructor
@@ -653,11 +679,14 @@ class MediaErrorEvent: public AAMPEventObject
653679
*/
654680
AAMPTuneFailure getFailure() const;
655681

682+
/**
683+
* @fn getMinorCode
684+
*/
685+
int getMinorCode() const;
656686
/**
657687
* @fn getCode
658688
*/
659689
int getCode() const;
660-
661690
/**
662691
* @fn getDescription
663692
*/

‎AampEventListener.cpp‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,7 @@ static void GenerateLegacyAAMPEvent(const AAMPEventPtr &e, AAMPEvent &event)
4242
MediaErrorEventPtr ev = std::dynamic_pointer_cast<MediaErrorEvent>(e);
4343
event.data.mediaError.failure = ev->getFailure();
4444
event.data.mediaError.code = ev->getCode();
45+
event.data.mediaError.minorCode = ev->getMinorCode();
4546
event.data.mediaError.description = ev->getDescription().c_str();
4647
event.data.mediaError.shouldRetry = ev->shouldRetry();
4748
if(-1 != ev->getClass()) //Only send the verbose logging for DRM failure due to secclient/secmanager

‎jsbindings/jsbindings.cpp‎

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -928,14 +928,19 @@ class AAMP_JSListener_TuneFailed : public AAMP_JSListener
928928
void setEventProperties(const AAMPEventPtr& e, JSContextRef context, JSObjectRef eventObj)
929929
{
930930
MediaErrorEventPtr evt = std::dynamic_pointer_cast<MediaErrorEvent>(e);
931-
931+
932932
int code = evt->getCode();
933+
int minorCode = evt->getMinorCode();
933934
const char* description = evt->getDescription().c_str();
934935

935936
JSStringRef name = JSStringCreateWithUTF8CString("code");
936937
JSObjectSetProperty(context, eventObj, name, JSValueMakeNumber(context, code), kJSPropertyAttributeReadOnly, NULL);
937938
JSStringRelease(name);
938939

940+
name = JSStringCreateWithUTF8CString("minorcode");
941+
JSObjectSetProperty(context, eventObj, name, JSValueMakeNumber(context, minorCode), kJSPropertyAttributeReadOnly, NULL);
942+
JSStringRelease(name);
943+
939944
name = JSStringCreateWithUTF8CString("description");
940945
JSObjectSetProperty(context, eventObj, name, aamp_CStringToJSValue(context, description), kJSPropertyAttributeReadOnly, NULL);
941946
JSStringRelease(name);

‎jsbindings/jseventlistener.cpp‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -261,6 +261,10 @@ class AAMP_Listener_PlaybackFailed : public AAMP_JSEventListener
261261
JSObjectSetProperty(p_obj->_ctx, jsEventObj, prop, JSValueMakeNumber(p_obj->_ctx, evt->getCode()), kJSPropertyAttributeReadOnly, NULL);
262262
JSStringRelease(prop);
263263

264+
prop = JSStringCreateWithUTF8CString("minorcode");
265+
JSObjectSetProperty(p_obj->_ctx, jsEventObj, prop, JSValueMakeNumber(p_obj->_ctx, evt->getMinorCode()), kJSPropertyAttributeReadOnly, NULL);
266+
JSStringRelease(prop);
267+
264268
prop = JSStringCreateWithUTF8CString("description");
265269
JSObjectSetProperty(p_obj->_ctx, jsEventObj, prop, aamp_CStringToJSValue(p_obj->_ctx, evt->getDescription().c_str()), kJSPropertyAttributeReadOnly, NULL);
266270
JSStringRelease(prop);

0 commit comments

Comments
 (0)