VPLAY-11786: Observed crash with fingerprint "88814015/82391305" (#686)

nu641001 · web-flow · commit aeaedc669795 · 2025-11-18T13:38:42.000-05:00
VPLAY-11786: Observed crash with fingerprint "88814015/82391305"

Reason for change:Fixing the CacheEncryptedHeader with downloadInfo before downloading
Risks: Low
Test Procedure: Test with DRM contents
Priority: P1

---------

Signed-off-by: Philip Stroffolino &lt;philip_stroffolino@cable.comcast.com&gt;
diff --git a/fragmentcollector_mpd.cpp b/fragmentcollector_mpd.cpp
@@ -8499,12 +8499,23 @@ void StreamAbstractionAAMP_MPD::CacheEncryptedHeader(int trackIdx, std::string h
 		bool temp = false;
 		try
 		{
+			DownloadInfoPtr info = std::make_shared<DownloadInfo>();
+			info->absolutePosition = 0;
+			info->ptsOffset = 0;
+			info->isInitSegment = true;
+			info->mediaType = (AampMediaType)trackIdx;
+			mMediaStreamContext[trackIdx]->mActiveDownloadInfo = std::move(info);
 			temp =  mMediaStreamContext[trackIdx]->CacheFragment(headerUrl, (eCURLINSTANCE_VIDEO + mMediaStreamContext[trackIdx]->mediaType), mMediaStreamContext[trackIdx]->fragmentTime, 0.0, NULL, true, false, false, 0);
 		}
 		catch(const std::regex_error& e)
 		{
 			AAMPLOG_ERR("regex exception in Calling CacheFragment: %s", e.what());
 		}
+		catch (...)
+		{
+			AAMPLOG_ERR("unknown exception calling CacheFragment");
+		}
+		mMediaStreamContext[trackIdx]->mActiveDownloadInfo = nullptr;
 		if(!temp)
 		{
 			AAMPLOG_TRACE("StreamAbstractionAAMP_MPD: did not cache fragmentUrl %s fragmentTime %f", headerUrl.c_str(), mMediaStreamContext[trackIdx]->fragmentTime); //CID:84438 - checked return

Original file line number	Diff line number	Diff line change
`@@ -8499,12 +8499,23 @@ void StreamAbstractionAAMP_MPD::CacheEncryptedHeader(int trackIdx, std::string h`
`8499`	`8499`	`bool temp = false;`
`8500`	`8500`	`try`
`8501`	`8501`	`{`
	`8502`	`+ DownloadInfoPtr info = std::make_shared<DownloadInfo>();`
	`8503`	`+ info->absolutePosition = 0;`
	`8504`	`+ info->ptsOffset = 0;`
	`8505`	`+ info->isInitSegment = true;`
	`8506`	`+ info->mediaType = (AampMediaType)trackIdx;`
	`8507`	`+ mMediaStreamContext[trackIdx]->mActiveDownloadInfo = std::move(info);`
`8502`	`8508`	`temp = mMediaStreamContext[trackIdx]->CacheFragment(headerUrl, (eCURLINSTANCE_VIDEO + mMediaStreamContext[trackIdx]->mediaType), mMediaStreamContext[trackIdx]->fragmentTime, 0.0, NULL, true, false, false, 0);`
`8503`	`8509`	`}`
`8504`	`8510`	`catch(const std::regex_error& e)`
`8505`	`8511`	`{`
`8506`	`8512`	`AAMPLOG_ERR("regex exception in Calling CacheFragment: %s", e.what());`
`8507`	`8513`	`}`
	`8514`	`+ catch (...)`
	`8515`	`+ {`
	`8516`	`+ AAMPLOG_ERR("unknown exception calling CacheFragment");`
	`8517`	`+ }`
	`8518`	`+ mMediaStreamContext[trackIdx]->mActiveDownloadInfo = nullptr;`
`8508`	`8519`	`if(!temp)`
`8509`	`8520`	`{`
`8510`	`8521`	`AAMPLOG_TRACE("StreamAbstractionAAMP_MPD: did not cache fragmentUrl %s fragmentTime %f", headerUrl.c_str(), mMediaStreamContext[trackIdx]->fragmentTime); //CID:84438 - checked return`