VPLAY-11530: Increase in PLTV XSTPP-999 Failures (#679)

VPLAY-11530 [Charter XiOne | ES1][R38] Increase in PLTV XSTPP-999 Failures on both Xi1/ES1

- Reintroduced the condition check before calling clear() in clearDrmSession(), which was missed during the DRM refactoring
- Apply suggestions from code review
- Added mutex lock

---------

Signed-off-by: Philip Stroffolino <[email protected]>
Co-authored-by: paulpandian25 <[email protected]>
Co-authored-by: vkadun208_comcast <[email protected]>
Co-authored-by: pstroffolino <[email protected]>
Co-authored-by: Copilot <[email protected]>

Author: 5 people

drm/AampDRMLicManager.cpp

@@ -1450,10 +1450,17 @@ void AampDRMLicenseManager::clearDrmSession(bool forceClearSession)
 {
 	mDrmSessionManager->clearDrmSession(forceClearSession);
 	for(int i = 0 ; i < mMaxDRMSessions;i++)
-        {
-
-             mLicenseDownloader[i].Clear();
-        }
+	{
+		bool isFailedKeyId = mDrmSessionManager->getFailedKeyIdStatus(i);
+		if(( mDrmSessionManager->drmSessionContexts != NULL && (isFailedKeyId || forceClearSession)  ))
+		{
+			if(mDrmSessionManager->drmSessionContexts[i].drmSession != NULL)
+			{
+				AAMPLOG_INFO("Clearing Session %d, isFailedKeyId=%d, forceClearSession=%d",i, isFailedKeyId, forceClearSession);
+				mLicenseDownloader[i].Clear();
+			}
+		}
+	}
 }
 
 /**

middleware/drm/DrmSessionManager.cpp

@@ -170,6 +170,20 @@ void DrmSessionManager::clearAccessToken()
 	}
 }
 
+/**
+ * @brief Get the failed key ID status for a specific session
+ */
+bool DrmSessionManager::getFailedKeyIdStatus(int sessionIndex)
+{
+	bool rc = false;
+	std::lock_guard<std::mutex> guard(cachedKeyMutex);
+	if (sessionIndex >= 0 && sessionIndex < mMaxDRMSessions && cachedKeyIDs)
+	{
+		rc = cachedKeyIDs[sessionIndex].isFailedKeyId;
+	}
+	return rc;
+}
+
 /**
  * @brief Clean up the Session Data if license key acquisition failed or if LicenseCaching is false.
  */

middleware/drm/DrmSessionManager.h

@@ -301,6 +301,16 @@ class DrmSessionManager
 	 * @return	void.
 	 */
 	void clearFailedKeyIds();
+
+
+	/**
+	 * @fn		getFailedKeyIdStatus
+	 *
+	 * @param	sessionIndex - curl session index to check
+	 * @return	bool - true if the key ID is marked as failed, false otherwise
+	 */
+	bool getFailedKeyIdStatus(int sessionIndex);
+
 	/**
 	 * @fn		clearDrmSession
 	 *