VPLAY-10871: AddOn Fix for COPY_INSTEAD_OF_MOVE Coverity Issue (#553)

Reason for change: Resolved More Coverity Issues caused by(COPY_INSTEAD_OF_MOVE)
Test Procedure: Refer jira ticket VPLAY-10871
Priority: P1

Signed-off-by: srikanthreddybijjam-comcast <[email protected]>

…fied fragment class

VPLAY-10932  Unify CachedFragment and CachedFragmentChunks: Create unified fragment class

Reason for Change:
* First pass unified caching mechanism for streamabstraction
* Enhance fragment class
* Still building functionality using tdd
* Extending AampFragment
* Move constructor
* Move cachedFragment to separate file.  Update deps + L1 ftests, create new (mocked) L1 test for standalone testing.
* Updated existing tests to use new CachedFragment
* Excise earlier AampFragment
* Revertreenabled SessionManager tests
* Move mock growable buffer to vector impl
* Remove empty files
* Disable problematic test & remove null chec from priv_aamp
* Ensure EXPECT_EQ_DOUBLE is used for double comparisons
* Remove testing fake growable buffer
* Remove all checks on fragment member variable
* Excise more mock calls
* Refix l1 tests
* restore priv_aamp.cpp
* Expand comments

Test Guidance: L1 tests passing and general regression
Risk: Low
---------

Co-authored-by: pstroffolino <[email protected]>

VPLAY-11395 L2 Test AAMP-TUNE-1012_ManifestPreProcess failing

Reason for Change: fixes for aampcli-getManifestData utility function used in l2 test
Corrections to logging
Filled out user agent (avoids 403 on S3 server)

Test Guidance: L2 1012 passing
Risk: Low

Signed-off-by: Philip Stroffolino <[email protected]>

VPLAY-11242 [VIPA] Refactor SetPreferredTextLanguages
Reason for Change: refactoring/cleanup
Test Guidance: L1 tests passing, including closed caption test
Signed-off-by: Philip Stroffolino <[email protected]>

VPLAY-11372 Mute CC if video is muted (#565)

Reason for Change: fix edge cases for cc muting and beef up tests

- VPLAY-11356 Verify SetCCStatus() in L1 tests
- Verify SetCCStatus() call when StreamAbstraction object is created
- VPLAY-11356 Update the copyright date for MockPlayerCCManager.h
- Add blank lines to MockPlayerCCManager.h
- Only call SetStatus() if StreamAbstraction is not null
- Handle calls to SetCCStatus() before StreamAbstraction object is created
- Call SetStatus() even if StreamAbstraction object does not exist
- Use bool instead of int for subtitles methods
- Fix memory leak in L1 tests
- Add expectations and clarify L1 tests

Test Guidance: refer ticket

Risk: Low

VPLAY-10999 [AAMP] Investigate AAMP playback stop time

Reason for change: optimization for stopping playback - fix to correctly interrupt downloads
Test Procedure: Refer ticket
Priority: P1

Signed-off-by: varshnie <[email protected]>

VPLAY-11411: Aamp tune Version is displayed 7.08 Instead of 7.09
Reason for change: Changed AAMP version to 7.09
Test Procedure: Refer Jira
Risks: No

Co-authored-by: pstroffolino <[email protected]>

…ted (#580)

VPLAY-11356 Verify SetCCStatus() in L1 tests

Reason for Change:
* Verify SetCCStatus() call when StreamAbstraction object is created
* VPLAY-11356 Update the copyright date for MockPlayerCCManager.h
* Add blank lines to MockPlayerCCManager.h
* VPLAY-11372 Mute CC if video is muted
* Only call SetStatus() if StreamAbstraction is not null
* Handle calls to SetCCStatus() before StreamAbstraction object is created
* Call SetStatus() even if StreamAbstraction object does not exist
* Use bool instead of int for subtitles methods
* Fix memory leak in L1 tests
* VPLAY-11315 Avoid calling GStreamer subtec sink mute twice when CC muted
* Ignore WebVTT cue listener to decide if using PlayerCCManager or GStreamer sink
* Revert comment
* Add L1 test to verify the change
* Add expectations and clarify L1 tests
* Print video_muted and subtitles_muted in SetCCStatus()

---------

Co-authored-by: pstroffolino <[email protected]>

…ly while playing HD/UHD linear and VOD

VPLAY-11457 [VIPA][LLAMA G1/G2/IT]: Technical Fault issue seen randomly while playing HD/UHD linear and VOD

Reason for Change: Firebolt DRM request was sometimes (barely) timing out and failing.  Changed timeout from 3s to more generous 5s.

Test Guidance: monitor for reduced occurrence of VIPA tune failures

Risk: Low

Co-authored-by: nrames759 <[email protected]>

VPLAY-11245: [VIPA] Add CC Manager class for Rialto

Reason for Change:
VPLAY-11245 (new derived class PlayerRialtoCCManager for inband captions with VIPA/Rialto)
These changes bring in the new derived class for rialto CC which combined with the GStreamer pipeline changes for VPLAY-11246 allow inband 608/708 CC to work on Rialto.

---------

Co-authored-by: DomSyna <[email protected]>

…k to AAMP (#556)

RDK-59455 : Integrating Device API calls from firebolt-native-aamp-sdk to AAMP (#556)

Reason for Change:
- changes are to bring firebolt device api support for video resolution change (previously implemented using IARM, which doesn't work from inside container)
- for now, backwards compatibility for IARM is included as a runtime option using UseFireboltSDK config
- note that there is an external issue for getting network interface that will be addressed outside AAMP with RPPL-3663
also fixes a recent typo outside this review

Test Guidance: details in ticket

Risk: Medium

---------

Signed-off-by: Philip Stroffolino <[email protected]>
Co-authored-by: nrames759 <[email protected]>
Co-authored-by: pstroffolino <[email protected]>

…k is enabled for inband captions with VIPA/Rialto (#554)

VPLAY-11246: [VIPA] Change the pipeline configuration when Rialto sink is enabled for inband captions with VIPA/Rialto (#554)

Reason For Change: Add Rialto subtitle sink to gstreamer pipeline to
act as a control handle for Closed Caption; required as part of working inband caption delivery

Signed-off-by: anshephe <[email protected]>

VPLAY-11379 address compiler warnings from tip of dev_sprint_25_2 (#596)

Reason for Change: address various xcode warnings

Test Guidance: refer ticket - the cited warnings should no longer be seen

Risk: Low

Signed-off-by: Philip Stroffolino <[email protected]>

VPLAY-10563 curl timeout disambiguation

Reason for change: Disambiguation for curl error 28 to distinguish between DNS lookup and host connection, and data timeouts timeouts
Test Procedure: Refer Ticket
Risks: Medium
Signed-off-by: lashmintha <[email protected]>

VPLAY-10563 curl timeout disambiguation

Reason for change: replace default 1002 with curl 28, minimizing needed changes in l2 tests.

Test Guidance: refer ticket

Risk: Low

Signed-off-by: Philip Stroffolino <[email protected]>

VPLAY-11245 RialtoCCManager build fix

Reason for Change: add missing header in PlayerRialtoCCManager.cpp
Test Guidance: no more full-stack build failure
Risk: None

VPLAY-11384 Get access (session) token from auth service

Reason for change: replace deprecated method of getting access token
Test Procedure: See ticket
Risks: Low

Signed-off-by: James Lofthouse <[email protected]>

#598)

VPLAY-11442 : [Update UVE Doc] Ability to configure + / - av sync threshold values for MonitorAV.

Reason for change: added documentation for monitorAV sync
Test Procedure: No Test required
Priority: P1

Signed-off-by: Gnanesha <[email protected]>

Update CODEOWNERS

VPLAY-11062: Bringback with L2 fixes

Reason for change: Set EventManager State to RELEASED in
PrivateInstanceAAMP::Stop() to avoid event processing.
Test Procedure: Refer Jira
Risks: Low

VPLAY-11251 : Fix for js logging 

Reason for change: VIPA fix for js logging from container
Test Procedure:Refer ticket
Priority: P2
Risks:Low

Signed-off-by: Abhi-jith-S <[email protected]>

…591)

VPLAY-11435 Switch to play when the beginning of the TSB is reached (#591)
Reason for Change:
* Switch to play when the beginning of the TSB is reached
* Handle BoS even if rate is not < 0
* Send BoS notification with position=0
* Revert to setting position=start when reaching BoS
* Only handle the BoS if rate is negative
* Address review comments: rename to PlayFromTsbStart(), add L1 test...
* Check the rate before calling PlayFromTsbStart()
* Replace verbose MIL with TRACE
* Rename ReportProgress() to MonitorProgress() and extend the function comments

Test Guidance: refer ticket
Risk: Low
---------

Co-authored-by: pstroffolino <[email protected]>

VPLAY-11276 : Inconsistent event names in InterfacePlayerRDK

Reason for change: Standardized audio/video frame event name logging
Test Procedure: No l2 breakage
Priority: P1

Signed-off-by: Varatharajan_Narayanan <[email protected]>
Co-authored-by: pstroffolino <[email protected]>

VPLAY-11543 fix command line openssl path issues with utests

Reason for Change: fix issues with utests build from command line seen on osx
- update middleware to use CMAKE_CXX_STANDARD 17
- explicit openssl package install and include via:
    pkg_check_modules(OPENSSL REQUIRED openssl)
    include_directories(${OPENSSL_INCLUDE_DIRS})

Test Guidance: l1 tests able to build with run.sh on OSX

Risk: Low

Signed-off-by: Philip Stroffolino <[email protected]>

RDKAAMP-3639 : review and eliminate runtime behaviors dependent

Reason for change: Moving the SOC related code changes to vendor layer from GST RDK plugins, eliminating various #ifdef AMLOGIC.  Also makes "first audio frame event" name consistent with first video frame.

Test Procedure: Need to ensure the playback in SOC specific devices

Risks: Low

Signed-off-by: Varatharajan_Narayanan <[email protected]>

VPLAY-11540 godspell cleanup 

Reason for Change: spelling fixes

Test Guidance: no compilation issues

Risk: Low

Signed-off-by: Philip Stroffolino <[email protected]>

… times (#613)

VPLAY-11408:Same JS event listeners should not be registered multiple times

Reason for change:Same JS event listeners should not be registered multiple times
Test Procedure: Refer jira ticket
Priority: P1

Signed-off-by: varshnie <[email protected]>

…#638)

VPLAY-11588 [VIPA] inband captions not set correctly when playing HLS (#638)

Reason for Change: handful of small fixes specific to inband CC support with HLS & Rialto done on behalf of XIPA
* Enable some debugging
* fix logging
* Fix track selection
* Replace ptr with reference because they are better
* add some L1 tests

Test Guidance: Refer Ticket

Risk: zero for DASH, medium for HLS

VPLAY-11407 : Migrate AAMP Eventlisteners to shared_ptr for better memory handling

Reason for change: improve the memory handling,move the AAMPEventListener
		   object cached in AAMP to be of shared_ptr
Test Procedure: Updated in the ticket
Risks: Low

Signed-off-by: haripriya_molakalapalli <[email protected]>

VPLAY-11407 godspell fix (#667)

Reason for Change: change logged text from usecount to use_count; this avoids godspell flagging it, but also aligns with use_count() method of shared_ptr API

Test Guidance: godspell passing

Risk: None

Signed-off-by: Philip Stroffolino <[email protected]>

#662)

VPLAY-11267 : SLE thumbnails presented to the user is drifted by times ranging 10-15 seconds

Reason for change : added logic to correct sle live thumbnail timing
Risks: Low
Test Procedure: test SLE with thumbnails
Priority: P0

Signed-off-by: Gnanesha <[email protected]>
Co-authored-by: pstroffolino <[email protected]>

VPLAY-11412 : UVE DOC Update for LLD Documentation (#658)

Reason for change: Fleshed out/corrected AAMP-UVE-API.md documentation for LLDASH related configuration
Test Procedure: Updated in ticket
Risks: Low

Signed-off-by: Reshma-JO07 <[email protected]>
Co-authored-by: pstroffolino <[email protected]>

VPLAY-11709: l2 test 2073 regression

* l2 test 2073 regression
* Fix L1 tests

---------

Co-authored-by: pstroffolino <[email protected]>

VPLAY-11062  Bring back with L2 & L3 fixes

This reverts commit 546df9a.

Reason for change: During detach(), set the EventManager state to
RELEASED to disable further event processing. When reusing a previously
detached player, reset the EventManager state to IDLE to re-enable
event handling.
Test Procedure: Refer Jira
Risks: Low

Signed-off-by: psiva01 <[email protected]>

VPLAY-9274:[DASH] optimization: independent track downloads

Reason for change: Implementing independent track downloads in dash downloads
Risks: Low
Test Procedure: Test with all sort of DASH contents
Priority: P1
Signed-off-by: Nandakishor Udiyannur Mana <[email protected]>

…ulti-period streams. (#669)

VPLAY-10806 AV playback stuck observed during profile reordering in multi-period streams.

Reason for change: If the Profile order changes across the periods, facing video stuck up issue as it retains the previous Representation index value during each period switch, so properly reset the Representation index during each period switch
Risks: Low
Test Procedure: Refer jira ticket
Priority: P1

Signed-off-by: lashmintha <[email protected]>

…mLogic since ~25 October 2025 (#678)

VPLAY-11737 AAMP Test L3 2000, 2013, 2014, 2015 failing with Rialto+AmLogic since ~25 October 2025 (#678)

Reason for Change: fix regression from VPLAY-11239, where use of IsVideoMaster was inadvertently inverted to drive use of handle-segment-change

Signed-off-by: Philip Stroffolino <[email protected]>

VPLAY-11530 [Charter XiOne | ES1][R38] Increase in PLTV XSTPP-999 Failures on both Xi1/ES1

- Reintroduced the condition check before calling clear() in clearDrmSession(), which was missed during the DRM refactoring
- Apply suggestions from code review
- Added mutex lock

---------

Signed-off-by: Philip Stroffolino <[email protected]>
Co-authored-by: paulpandian25 <[email protected]>
Co-authored-by: vkadun208_comcast <[email protected]>
Co-authored-by: pstroffolino <[email protected]>
Co-authored-by: Copilot <[email protected]>

#683)

VPLAY-11773: [AAMP]Aamp tune Version is displayed 7.09 Instead of 7.10

Reason for change: Changed AAMP version to 7.10
Test Procedure: Refer Jira
Risks: None

VPLAY-11781 : Got PTS error message (#681)

Reason for change: brought back missing logline
Risks: Low
Test Procedure: see ticket
Priority: P1

Signed-off-by: Gnanesha <[email protected]>

…FailedKeyIdStatus fake (#687)

Reason for Change: fix link error impacting DrmLegacy L1 test

Test Guidance: all l1 tests passing

Risk: None: fake-only change

Signed-off-by: Philip Stroffolino <[email protected]>

 VPLAY-11786: Observed crash with fingerprint "88814015/82391305"

Reason for change:Fixing the CacheEncryptedHeader with downloadInfo before downloading
Risks: Low
Test Procedure: Test with DRM contents
Priority: P1

---------

Signed-off-by: Philip Stroffolino <[email protected]>

VPLAY-11594 Remove rate condition from UpdatePtsOffset()

Reason for Change:  Remove the rate condition from UpdatePtsOffset().
 The PTS offset should be updated regardless of the rate. This is
 important when using AAMP TSB, since downloading segments and
 calculating the PTS offset is independent from the play rate. However,
 this issue does not currently impact the behaviour due to VPLAY-11583.
 When using FOG or cloud TSB, this condition does not matter (the PTS
 offset is not used for trick modes).

* Add null check to fragmentcollector_mpd.cpp
* Unlike audio, mMediaStreamContext[eMEDIATYPE_VIDEO] should not be null, but adding a check for consistency and to make the code more robust.
* Add UpdatePtsOffset() L1 test for short ad with trick modes
* Change condition in UpdatePtsOffset() to address Copilot review comment

Test Guidance: General Regression only + updated L1 tests passing.

Risk: Low

…ged (#581)

VPLAY-11213 [VIPA] No need to reset TSB when Closed Caption Lang changed

Reason for Change: With in-band subtitles then all subtitle tracks are in the video segments and stored in the local TSB. Changing closed caption language does not need the TSB to be reset. I.E a tune does not need to happen

Test Guidance: Refer Ticket

Risk: Low

Signed-off-by: Philip Stroffolino <[email protected]>

VPLAY-11830 Correct spelling in comments: "dont" to "don't"

Reason for Change: copilot noticed that we have "dont" misspelled in our code

Test Guidance: code compiles - no functional change as review only touches comments

Risk: None
---------

Signed-off-by: Philip Stroffolino <[email protected]>

VPLAY-11362:Playback starts at the actual position the user requested 

Reason for change: Adjusted Detla to match PTO and StartTime
Test Procedure: Refer jira ticket VPLAY-11362
Priority: P1

Signed-off-by: srikanthreddybijjam-comcast <[email protected]>

#674)

VPLAY-11763 many WARN logs while tuning that should be MIL (milestone)

Reason for Change: convert batch of milestone logging from AAMPLOG_WARN to AAMPLOG_MIL

Test Guidance: review logs while tuning

Risk: Low

---------

Signed-off-by: Philip Stroffolino <[email protected]>
Co-authored-by: Copilot <[email protected]>

…05" (#686)"

This reverts commit aeaedc6.

Revert "VPLAY-9274:[DASH] optimization: independent track downloads (#614)"

This reverts commit 3746211.

Reason for change: Fix L1 regression due to VPLAY-9274 revert
Test Procedure: L1 verification
Priority: P1

Signed-off-by: psiva01 <[email protected]>

…led (#691)

VPLAY-11707 Subtitles displayed for channels when subtitles are disabled

Reason for change:
Subtiles not initially muted when SetCCStatus called prior to load

Risks: Low

Test Procedure:
Test subtitles/closed captions are muted correctly, e.g. on tune

Priority: P1

Signed-off-by: anshephe <[email protected]>

VPLAY-11707 Subtitles displayed for channels when subtitles are disab…

RDKEMW-1096: RPI MW build fix