-
Notifications
You must be signed in to change notification settings - Fork 6
Feature/vplay 11066 rialto standalone liblink #715
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rajat698
wants to merge
24
commits into
dev_sprint_25_2
Choose a base branch
from
feature/VPLAY-11066-rialtoStandalone-liblink
base: dev_sprint_25_2
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Feature/vplay 11066 rialto standalone liblink #715
rajat698
wants to merge
24
commits into
dev_sprint_25_2
from
feature/VPLAY-11066-rialtoStandalone-liblink
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ration/testing Reason for Change: new rialtoTest app Test Guidance: see ticket Risk: low Signed-off-by: Philip Stroffolino <[email protected]>
Signed-off-by: Philip Stroffolino <[email protected]>
Signed-off-by: Philip Stroffolino <[email protected]>
…ing easier Signed-off-by: Philip Stroffolino <[email protected]>
Signed-off-by: Philip Stroffolino <[email protected]>
…ration/testing Reason for change: Do Not Merge - Device test Risks: Low Priority: P1 Signed-off-by: ryadav698 <[email protected]>
Signed-off-by: ryadav698 <[email protected]>
Signed-off-by: ryadav698 <[email protected]>
Signed-off-by: ryadav698 <[email protected]>
Signed-off-by: ryadav698 <[email protected]>
Signed-off-by: ryadav698 <[email protected]>
Signed-off-by: ryadav698 <[email protected]>
f0fdd22 to
49874f5
Compare
Signed-off-by: ryadav698 <[email protected]>
Signed-off-by: ryadav698 <[email protected]>
91ba733 to
2fbfaed
Compare
Signed-off-by: ryadav698 <[email protected]>
cbc478a to
11883f7
Compare
765f13c to
0c5f43d
Compare
Signed-off-by: ryadav698 <[email protected]>
6ae06b3 to
9ba0d11
Compare
Signed-off-by: ryadav698 <[email protected]>
9ba0d11 to
6df2d7e
Compare
Signed-off-by: ryadav698 <[email protected]>
136df74 to
cba51d6
Compare
Signed-off-by: ryadav698 <[email protected]>
cba51d6 to
18670fd
Compare
Signed-off-by: ryadav698 <[email protected]>
pstroffolino
reviewed
Dec 4, 2025
| } | ||
| } | ||
|
|
||
| bool GstMediaPipeline::init() |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can move to constructor for the class
pstroffolino
reviewed
Dec 4, 2025
|
|
||
| // ConfigureAudio(); | ||
| // ConfigureVideo(); | ||
| // ConfigureComplete(); |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why are these commented out? Test only?
Signed-off-by: ryadav698 <[email protected]>
00e132c to
c5a4efc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.