Merge branch 'release/1.16.5'

Author: actions-user

CHANGELOG.md

@@ -4,9 +4,25 @@ All notable changes to this project will be documented in this file. Dates are d
 
 Generated by [`auto-changelog`](https://github.com/CookPete/auto-changelog).
 
+#### [1.16.5](https://github.com/rdkcentral/entservices-apis/compare/1.16.4...1.16.5)
+
+- RDKEMW-3789: refactor ILEDControl plugin interface with proper LED state enum. [`#529`](https://github.com/rdkcentral/entservices-apis/pull/529)
+- rebase [`#547`](https://github.com/rdkcentral/entservices-apis/pull/547)
+- rebase [`#543`](https://github.com/rdkcentral/entservices-apis/pull/543)
+- rebase [`#531`](https://github.com/rdkcentral/entservices-apis/pull/531)
+- rebase [`#528`](https://github.com/rdkcentral/entservices-apis/pull/528)
+- rebase [`#520`](https://github.com/rdkcentral/entservices-apis/pull/520)
+- rebase [`#490`](https://github.com/rdkcentral/entservices-apis/pull/490)
+- Merge tag '1.16.4' into develop [`ad0130d`](https://github.com/rdkcentral/entservices-apis/commit/ad0130d7748db0dbe51afe2eda1badacf48ddf21)
+- RDKEMW-3789: update the LEDControlPlugin.md [`779375b`](https://github.com/rdkcentral/entservices-apis/commit/779375bf984b7fc83d0371be3e18a8d8b3297bbc)
+- RDKEMW-3789: clean up the ILEDControl header [`995545c`](https://github.com/rdkcentral/entservices-apis/commit/995545c8f962a40ecf57f26b84324cf9a70a9abb)
+
 #### [1.16.4](https://github.com/rdkcentral/entservices-apis/compare/1.16.3...1.16.4)
 
+> 23 September 2025
+
 - RDKEMW-6916: Create documentation for AppManager [`#538`](https://github.com/rdkcentral/entservices-apis/pull/538)
+- 1.16.4 release changelog updates [`dd0dcd7`](https://github.com/rdkcentral/entservices-apis/commit/dd0dcd7e2d38c2876e422d791b5122faa58bfe89)
 - Merge tag '1.16.3' into develop [`7b3edec`](https://github.com/rdkcentral/entservices-apis/commit/7b3edeccb63d476d2d6c2a29f98798101151d2ba)
 
 #### [1.16.3](https://github.com/rdkcentral/entservices-apis/compare/1.16.2...1.16.3)

apis/LEDControl/ILEDControl.h

@@ -33,26 +33,42 @@ namespace WPEFramework
 
             using IStringIterator = RPC::IIteratorType<string, RPC::ID_STRINGITERATOR>;
 
-            struct EXTERNAL LEDControlState {
-                string state;
+            virtual ~ILEDControl() = default;
+
+            enum LEDControlState : uint8_t {
+                LEDSTATE_NONE = 0       /* @text NONE */,
+                LEDSTATE_ACTIVE         /* @text ACTIVE */,
+                LEDSTATE_STANDBY        /* @text STANDBY */,
+                LEDSTATE_WPS_CONNECTING /* @text WPS_CONNECTING */,
+                LEDSTATE_WPS_CONNECTED  /* @text WPS_CONNECTED */,
+                LEDSTATE_WPS_ERROR      /* @text WPS_ERROR */,
+                LEDSTATE_FACTORY_RESET  /* @text FACTORY_RESET */,
+                LEDSTATE_USB_UPGRADE    /* @text USB_UPGRADE */,
+                LEDSTATE_DOWNLOAD_ERROR /* @text DOWNLOAD_ERROR */,
+                LEDSTATE_MAX            /* @text MAX */
+            };
+
+            // Struct to wrap LEDControlState for API compatibility
+            struct EXTERNAL LEDState {
+                LEDControlState state;
             };
 
             // @text getSupportedLEDStates
-            // @brief Returns all the LED states supported by the platform
-            // @param supportedLEDStates - out - string [] of supported LED states
-            // @param success - out - boolean
+            // @details Returns the list of LED states that are actually supported by the platform at runtime. Possible values include `NONE`, `ACTIVE`, `STANDBY`, `WPS_CONNECTING`, `WPS_CONNECTED`, `WPS_ERROR`, `FACTORY_RESET`, `USB_UPGRADE` and `DOWNLOAD_ERROR`.
+            // @param supportedLEDStates: string [] of supported LED states. e.g. "['ACTIVE', 'STANDBY', 'WPS_CONNECTING', 'WPS_CONNECTED', 'WPS_ERROR', 'FACTORY_RESET', 'USB_UPGRADE', 'DOWNLOAD_ERROR']"
+            // @param success: boolean
             virtual Core::hresult GetSupportedLEDStates(IStringIterator*& supportedLEDStates /* @out */, bool& success /* @out */) = 0;
 
             // @text getLEDState
-            // @brief Returns current LED state.
-            // @param LEDControlState - out  
-            virtual Core::hresult GetLEDState(LEDControlState& ledState /* @out */) = 0;
+            // @brief Retrieves current state of the LED. e.g. {"state":"WPS_CONNECTING"}
+            // @param ledState: LEDState
+            virtual Core::hresult GetLEDState(LEDState& ledState /* @out */) = 0;
 
             // @text setLEDState
-            // @brief Change the device LED state to one mentioned in the input argument.
-            // @param state - in - string
-            // @param success - out - boolean
-            virtual Core::hresult SetLEDState(const string& state, bool& success /* @out */) = 0;
+            // @brief Sets the device LED to a requested state from those available in `GetSupportedLEDStates`.
+            // @param state: LEDControlState. e.g. "FACTORY_RESET"
+            // @param success: boolean
+            virtual Core::hresult SetLEDState(const LEDControlState& state, bool& success /* @out */) = 0;
         };
     } // namespace Exchange
 } // namespace WPEFramework