RDKEMW-7722: Align PowerManager WakeupSrcConfiguration API's with SystemService plugin #497
Conversation
|
|
skamath
force-pushed
the
feature/RDKEMW-7722
branch
2 times, most recently
from
f3620a2 to
22d6bf0
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Pull Request Overview
This PR aligns the PowerManager WakeupSrcConfiguration APIs with the SystemService plugin by modernizing the API design and adding new power mode pre-change management functionality.
- Replaced the old wakeupSources property with new setWakeupSourceConfig/getWakeupSourceConfig methods using a cleaner iterator-based design
- Added comprehensive power mode pre-change client management APIs (add, remove, complete, delay operations)
- Updated event structure to include transaction IDs and timing information for better power state transition control
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tools/json_generator/output/PowerManager/PowerManager.json | Removes old wakeupSources property, adds new power mode pre-change APIs and modernized wakeup source configuration methods |
| docs/apis/PowerManagerPlugin.md | Documents the new APIs with examples and updates parameter requirements |
| apis/PowerManager/IPowerManager.h | Defines the WakeupSrcConfig struct and iterator interface for the new wakeup source configuration |
| apis/Ids.h | Adds the iterator ID for the wakeup source configuration |
Comments suppressed due to low confidence (2)
docs/apis/PowerManagerPlugin.md:1
- There's an inconsistency in the class name casing. It should be 'PowerManager::WakeupSrcType' (with capital 'M') to match the pattern used elsewhere in the documentation.
<!-- Generated automatically, DO NOT EDIT! -->
docs/apis/PowerManagerPlugin.md:1
- There's an inconsistency in the class name casing. It should be 'PowerManager::WakeupSrcType' (with capital 'M') to match the pattern used elsewhere in the documentation.
<!-- Generated automatically, DO NOT EDIT! -->
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
…temService plugin
skamath
force-pushed
the
feature/RDKEMW-7722
branch
from
48c2e3d to
1e8bce2
Compare
No description provided.