Skip to content

Commit 29b8169

Browse files
authored
method-by-method: setEnabled change expected calls and add more tests for true/false enabled param
1 parent 743dfd0 commit 29b8169

File tree

1 file changed

+13
-18
lines changed

1 file changed

+13
-18
lines changed

Tests/L1Tests/tests/test_HdmiCecSource.cpp

Lines changed: 13 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -497,24 +497,7 @@ class HdmiCecSourceInitializedEventTest : public HdmiCecSourceInitializedTest {
497497

498498
TEST_F(HdmiCecSourceInitializedTest, setEnabled_EnablesCecSuccessfully)
499499
{
500-
// Setup mocks for device settings initialization
501-
EXPECT_CALL(*p_managerImplMock, Initialize())
502-
.Times(1);
503-
504-
EXPECT_CALL(*p_hostImplMock, getVideoOutputPort(::testing::_))
505-
.Times(::testing::AtLeast(1))
506-
.WillRepeatedly(::testing::ReturnRef(*p_videoOutputPortMock));
507-
508-
EXPECT_CALL(*p_videoOutputPortMock, getDisplay())
509-
.Times(::testing::AtLeast(1))
510-
.WillRepeatedly(::testing::ReturnRef(*p_displayMock));
511-
512-
// Setup IARM bus mock expectations
513-
EXPECT_CALL(*p_iarmBusImplMock, IARM_Bus_RegisterEventHandler(::testing::_, ::testing::_, ::testing::_))
514-
.Times(::testing::AtLeast(1))
515-
.WillRepeatedly(::testing::Return(IARM_RESULT_SUCCESS));
516-
517-
// Test setEnabled with enabled=true
500+
// Test setEnabled with enabled=true (CEC is already enabled in fixture setup)
518501
string response;
519502
EXPECT_EQ(Core::ERROR_NONE, handler.Invoke(connection, _T("setEnabled"), _T("{\"enabled\": true}"), response));
520503

@@ -525,4 +508,16 @@ TEST_F(HdmiCecSourceInitializedTest, setEnabled_EnablesCecSuccessfully)
525508
string getEnabledResponse;
526509
EXPECT_EQ(Core::ERROR_NONE, handler.Invoke(connection, _T("getEnabled"), _T("{}"), getEnabledResponse));
527510
EXPECT_THAT(getEnabledResponse, ::testing::HasSubstr("\"enabled\":true"));
511+
512+
// Test setEnabled with enabled=false to verify disable functionality
513+
EXPECT_EQ(Core::ERROR_NONE, handler.Invoke(connection, _T("setEnabled"), _T("{\"enabled\": false}"), response));
514+
EXPECT_EQ(response, string("{\"success\":true}"));
515+
516+
// Verify CEC is now disabled
517+
EXPECT_EQ(Core::ERROR_NONE, handler.Invoke(connection, _T("getEnabled"), _T("{}"), getEnabledResponse));
518+
EXPECT_THAT(getEnabledResponse, ::testing::HasSubstr("\"enabled\":false"));
519+
520+
// Re-enable for clean teardown
521+
EXPECT_EQ(Core::ERROR_NONE, handler.Invoke(connection, _T("setEnabled"), _T("{\"enabled\": true}"), response));
522+
EXPECT_EQ(response, string("{\"success\":true}"));
528523
}

0 commit comments

Comments
 (0)