Skip to content

Commit 2e6c622

Browse files
slkanthiarjunbinu
slkanthi
authored and
arjunbinu
committed
API Name Updates as per Review Comments:
The new caps APIs should not include the V2 suffix in their names. If an older caps version already exists, the existing API name should remain unchanged, and the new version should be named by appending the V2 suffix.
1 parent 3e57712 commit 2e6c622

File tree

2 files changed

+21
-17
lines changed

2 files changed

+21
-17
lines changed

‎AVOutput/AVOutputTV.cpp‎

Lines changed: 16 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -361,12 +361,12 @@ namespace Plugin {
361361
registerMethod("getPrecisionDetail", &AVOutputTV::getPrecisionDetail, this);
362362
registerMethod("setPrecisionDetail", &AVOutputTV::setPrecisionDetail, this);
363363
registerMethod("resetPrecisionDetail", &AVOutputTV::resetPrecisionDetail, this);
364-
registerMethod("getPrecisionDetailCaps", &AVOutputTV::getPrecisionDetailCaps, this);
364+
//registerMethod("getPrecisionDetailCaps", &AVOutputTV::getPrecisionDetailCaps, this);
365365

366366
registerMethod("getSDRGamma", &AVOutputTV::getSDRGamma, this);
367367
registerMethod("setSDRGamma", &AVOutputTV::setSDRGamma, this);
368368
registerMethod("resetSDRGamma", &AVOutputTV::resetSDRGamma, this);
369-
registerMethod("getSDRGammaCaps", &AVOutputTV::getSDRGammaCaps, this);
369+
//registerMethod("getSDRGammaCaps", &AVOutputTV::getSDRGammaCaps, this);
370370

371371
registerMethod("getLocalContrastEnhancement", &AVOutputTV::getLocalContrastEnhancement, this);
372372
registerMethod("setLocalContrastEnhancement", &AVOutputTV::setLocalContrastEnhancement, this);
@@ -403,13 +403,13 @@ namespace Plugin {
403403
registerMethod("getSharpnessCapsV2", &AVOutputTV::getSharpnessCapsV2, this);
404404
registerMethod("getSaturationCapsV2", &AVOutputTV::getSaturationCapsV2, this);
405405
registerMethod("getHueCapsV2", &AVOutputTV::getHueCapsV2, this);
406-
registerMethod("getPrecisionDetailCapsV2", &AVOutputTV::getPrecisionDetailCapsV2, this);
406+
registerMethod("getPrecisionDetailCaps", &AVOutputTV::getPrecisionDetailCaps, this);
407407
registerMethod("getLowLatencyStateCapsV2", &AVOutputTV::getLowLatencyStateCapsV2, this);
408408
registerMethod("getColorTemperatureCapsV2", &AVOutputTV::getColorTemperatureCapsV2, this);
409-
registerMethod("getSdrGammaCapsV2", &AVOutputTV::getSdrGammaCapsV2, this);
410-
registerMethod("getTVDimmingModeCapsV2", &AVOutputTV::getTVDimmingModeCapsV2, this);
411-
registerMethod("getAspectRatioCapsV2", &AVOutputTV::getAspectRatioCapsV2, this);
412-
registerMethod("getDVCalibrationCapsV2", &AVOutputTV::getDVCalibrationCapsV2, this);
409+
registerMethod("getSdrGammaCaps", &AVOutputTV::getSdrGammaCaps, this);
410+
registerMethod("getBacklightDimmingModeCapsV2", &AVOutputTV::getBacklightDimmingModeCapsV2, this);
411+
registerMethod("getZoomModeCapsV2", &AVOutputTV::getZoomModeCapsV2, this);
412+
registerMethod("getDVCalibrationCaps", &AVOutputTV::getDVCalibrationCaps, this);
413413
registerMethod("getPictureModeCapsV2", &AVOutputTV::getPictureModeCapsV2, this);
414414

415415
LOGINFO("Exit\n");
@@ -709,7 +709,7 @@ namespace Plugin {
709709
"Hue", parameters, response);
710710
}
711711

712-
uint32_t AVOutputTV::getPrecisionDetailCapsV2(const JsonObject& parameters, JsonObject& response) {
712+
uint32_t AVOutputTV::getPrecisionDetailCaps(const JsonObject& parameters, JsonObject& response) {
713713
return getCapsV2([this](tvContextCaps_t** context_caps, int* max_precision) {
714714
return this->GetPrecisionDetailCaps(max_precision, context_caps);
715715
},
@@ -761,7 +761,7 @@ namespace Plugin {
761761
returnResponse(true);
762762
}
763763

764-
uint32_t AVOutputTV::getSdrGammaCapsV2(const JsonObject& parameters, JsonObject& response) {
764+
uint32_t AVOutputTV::getSdrGammaCaps(const JsonObject& parameters, JsonObject& response) {
765765
tvSdrGamma_t* sdr_gamma = nullptr;
766766
size_t num_sdr_gamma = 0;
767767
tvContextCaps_t* context_caps = nullptr;
@@ -797,7 +797,7 @@ namespace Plugin {
797797
returnResponse(true);
798798
}
799799

800-
uint32_t AVOutputTV::getTVDimmingModeCapsV2(const JsonObject& parameters, JsonObject& response) {
800+
uint32_t AVOutputTV::getBacklightDimmingModeCapsV2(const JsonObject& parameters, JsonObject& response) {
801801
tvDimmingMode_t* dimming_mode = nullptr;
802802
size_t num_dimming_mode = 0;
803803
tvContextCaps_t* context_caps = nullptr;
@@ -828,7 +828,7 @@ namespace Plugin {
828828
returnResponse(true);
829829
}
830830

831-
uint32_t AVOutputTV::getAspectRatioCapsV2(const JsonObject& parameters, JsonObject& response) {
831+
uint32_t AVOutputTV::getZoomModeCapsV2(const JsonObject& parameters, JsonObject& response) {
832832
tvDisplayMode_t* aspect_ratio = nullptr;
833833
size_t num_aspect_ratio = 0;
834834
tvContextCaps_t* context_caps = nullptr;
@@ -905,7 +905,7 @@ namespace Plugin {
905905
returnResponse(true);
906906
}
907907

908-
uint32_t AVOutputTV::getDVCalibrationCapsV2(const JsonObject& parameters, JsonObject& response) {
908+
uint32_t AVOutputTV::getDVCalibrationCaps(const JsonObject& parameters, JsonObject& response) {
909909
tvDVCalibrationSettings_t *min_values = nullptr;
910910
tvDVCalibrationSettings_t *max_values = nullptr;
911911
tvContextCaps_t *context_caps = nullptr;
@@ -4535,6 +4535,7 @@ namespace Plugin {
45354535
}
45364536
}
45374537

4538+
#if 0
45384539
uint32_t AVOutputTV::getPrecisionDetailCaps(const JsonObject& parameters, JsonObject& response) {
45394540
LOGINFO("Entry");
45404541

@@ -4589,6 +4590,7 @@ namespace Plugin {
45894590
LOGINFO("Exit : getPrecisionDetailCaps successful");
45904591
returnResponse(true);
45914592
}
4593+
#endif
45924594

45934595
uint32_t AVOutputTV::getSDRGamma(const JsonObject& parameters, JsonObject& response) {
45944596
LOGINFO("Entry");
@@ -4701,6 +4703,7 @@ namespace Plugin {
47014703
}
47024704
}
47034705

4706+
#if 0
47044707
uint32_t AVOutputTV::getSDRGammaCaps(const JsonObject& parameters, JsonObject& response) {
47054708
LOGINFO("Entry");
47064709

@@ -4758,6 +4761,7 @@ namespace Plugin {
47584761
LOGINFO("Exit : getSDRGammaCaps successful");
47594762
returnResponse(true);
47604763
}
4764+
#endif
47614765

47624766
uint32_t AVOutputTV::getLocalContrastEnhancement(const JsonObject& parameters, JsonObject& response) {
47634767
LOGINFO("Entry");

‎AVOutput/AVOutputTV.h‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -254,13 +254,13 @@ class AVOutputTV : public AVOutputBase {
254254
DECLARE_JSON_RPC_METHOD(getSharpnessCapsV2)
255255
DECLARE_JSON_RPC_METHOD(getSaturationCapsV2)
256256
DECLARE_JSON_RPC_METHOD(getHueCapsV2)
257-
DECLARE_JSON_RPC_METHOD(getPrecisionDetailCapsV2)
257+
DECLARE_JSON_RPC_METHOD(getPrecisionDetailCaps)
258258
DECLARE_JSON_RPC_METHOD(getLowLatencyStateCapsV2)
259259
DECLARE_JSON_RPC_METHOD(getColorTemperatureCapsV2)
260-
DECLARE_JSON_RPC_METHOD(getSdrGammaCapsV2)
261-
DECLARE_JSON_RPC_METHOD(getTVDimmingModeCapsV2)
262-
DECLARE_JSON_RPC_METHOD(getAspectRatioCapsV2)
263-
DECLARE_JSON_RPC_METHOD(getDVCalibrationCapsV2)
260+
DECLARE_JSON_RPC_METHOD(getSdrGammaCaps)
261+
DECLARE_JSON_RPC_METHOD(getBacklightDimmingModeCapsV2)
262+
DECLARE_JSON_RPC_METHOD(getZoomModeCapsV2)
263+
DECLARE_JSON_RPC_METHOD(getDVCalibrationCaps)
264264
DECLARE_JSON_RPC_METHOD(getPictureModeCapsV2)
265265

266266
/*Set API's*/

0 commit comments

Comments
 (0)