RDKEMW-2031: Fix Coverity issues within iarmmgr

hgfell683 · hgfell683 · commit 6f9047414c07 · 2025-03-19T15:58:36.000-04:00
Reason for change: Fix coverity issues within iarmmgr
Test Procedure:
Risks: low
Priority: P1

Signed-off-by:Hayden Gfeller &lt;Hayden_Gfeller@comcast.com&gt;
diff --git a/HdmiCecSource/HdmiCecSource.h b/HdmiCecSource/HdmiCecSource.h
@@ -80,58 +80,65 @@ namespace WPEFramework {
                                 INTERFACE_ENTRY(RPC::IRemoteConnection::INotification)
                                 END_INTERFACE_MAP
 
-                                void Activated(RPC::IRemoteConnection*) override;
-                                void Deactivated(RPC::IRemoteConnection *connection) override;
+                                void Activated(RPC::IRemoteConnection*) override
+                                {
+                                }
+                            
+                                void Deactivated(RPC::IRemoteConnection *connection) override
+                                {
+                                   _parent.Deactivated(connection);
+                                }
 
                                 void OnDeviceAdded(const int logicalAddress) override
                                 {
                                     LOGINFO("OnDeviceAdded");
                                     JsonObject params;
                                     params["logicalAddress"] = logicalAddress;
                                     _parent.Notify(_T("onDeviceAdded"), params);
+                                    Exchange::JHdmiCecSource::Event::OnDeviceAdded(_parent, logicalAddress);
                                 }
                                 void OnDeviceRemoved(const int logicalAddress) override
                                 {
                                     LOGINFO("OnDeviceRemoved");
                                     JsonObject params;
                                     params["logicalAddress"] = logicalAddress;
-                                    _parent.Notify(_T("onDeviceRemoved"), params);
+                                    Exchange::JHdmiCecSource::Event::OnDeviceRemoved(_parent, logicalAddress);
                                 }
                                 void OnDeviceInfoUpdated(const int logicalAddress) override
                                 {
                                     LOGINFO("OnDeviceInfoUpdated");
                                     JsonObject params;
                                     params["logicalAddress"] = logicalAddress;
-                                    _parent.Notify(_T("onDeviceInfoUpdated"), params);
+                                    Exchange::JHdmiCecSource::Event::OnDeviceInfoUpdated(_parent, logicalAddress);
                                 }
                                 void OnActiveSourceStatusUpdated(const bool status) override
                                 {
                                     LOGINFO("OnActiveSourceStatusUpdated");
                                     JsonObject params;
                                     params["isActiveSource"] = status;
-                                    _parent.Notify(_T("onActiveSourceStatusUpdated"), params);
+                                    Exchange::JHdmiCecSource::Event::OnActiveSourceStatusUpdated(_parent, status);
                                 }
                                 void StandbyMessageReceived(const int logicalAddress) override
                                 {
                                     LOGINFO("StandbyMessageReceived");
                                     JsonObject params;
                                     params["logicalAddress"] = logicalAddress;
-                                    _parent.Notify(_T("standbyMessageReceived"), params);
+                                    Exchange::JHdmiCecSource::Event::StandbyMessageReceived(_parent, logicalAddress);
                                 }
                                 void SendKeyReleaseMsgEvent(const int logicalAddress) override
                                 {
                                     LOGINFO("SendKeyReleaseMsgEvent");
                                     JsonObject params;
                                     params["logicalAddress"] = logicalAddress;
-                                    _parent.Notify(_T("SendKeyReleaseMsgEvent"), params);
+                                    Exchange::JHdmiCecSource::Event::SendKeyReleaseMsgEvent(_parent, logicalAddress);
                                 }
                                 void SendKeyPressMsgEvent(const int logicalAddress, const int keyCode) override
                                 {
                                     LOGINFO("SendKeyPressMsgEvent");
                                     JsonObject params;
                                     params["logicalAddress"] = logicalAddress;
                                     params["keyCode"] = keyCode;
-                                    _parent.Notify(_T("sendKeyPressMsgEvent"), params);
+                                    Exchange::JHdmiCecSource::Event::SendKeyPressMsgEvent(_parent, logicalAddress, keyCode);
                                 }
 
                             private:

Original file line number	Diff line number	Diff line change
`@@ -80,58 +80,65 @@ namespace WPEFramework {`
`80`	`80`	`INTERFACE_ENTRY(RPC::IRemoteConnection::INotification)`
`81`	`81`	`END_INTERFACE_MAP`
`82`	`82`
`83`		`- void Activated(RPC::IRemoteConnection*) override;`
`84`		`- void Deactivated(RPC::IRemoteConnection *connection) override;`
	`83`	`+ void Activated(RPC::IRemoteConnection*) override`
	`84`	`+ {`
	`85`	`+ }`
	`86`	`+`
	`87`	`+ void Deactivated(RPC::IRemoteConnection *connection) override`
	`88`	`+ {`
	`89`	`+ _parent.Deactivated(connection);`
	`90`	`+ }`
`85`	`91`
`86`	`92`	`void OnDeviceAdded(const int logicalAddress) override`
`87`	`93`	`{`
`88`	`94`	`LOGINFO("OnDeviceAdded");`
`89`	`95`	`JsonObject params;`
`90`	`96`	`params["logicalAddress"] = logicalAddress;`
`91`	`97`	`_parent.Notify(_T("onDeviceAdded"), params);`
	`98`	`+ Exchange::JHdmiCecSource::Event::OnDeviceAdded(_parent, logicalAddress);`
`92`	`99`	`}`
`93`	`100`	`void OnDeviceRemoved(const int logicalAddress) override`
`94`	`101`	`{`
`95`	`102`	`LOGINFO("OnDeviceRemoved");`
`96`	`103`	`JsonObject params;`
`97`	`104`	`params["logicalAddress"] = logicalAddress;`
`98`		`- _parent.Notify(_T("onDeviceRemoved"), params);`
	`105`	`+ Exchange::JHdmiCecSource::Event::OnDeviceRemoved(_parent, logicalAddress);`
`99`	`106`	`}`
`100`	`107`	`void OnDeviceInfoUpdated(const int logicalAddress) override`
`101`	`108`	`{`
`102`	`109`	`LOGINFO("OnDeviceInfoUpdated");`
`103`	`110`	`JsonObject params;`
`104`	`111`	`params["logicalAddress"] = logicalAddress;`
`105`		`- _parent.Notify(_T("onDeviceInfoUpdated"), params);`
	`112`	`+ Exchange::JHdmiCecSource::Event::OnDeviceInfoUpdated(_parent, logicalAddress);`
`106`	`113`	`}`
`107`	`114`	`void OnActiveSourceStatusUpdated(const bool status) override`
`108`	`115`	`{`
`109`	`116`	`LOGINFO("OnActiveSourceStatusUpdated");`
`110`	`117`	`JsonObject params;`
`111`	`118`	`params["isActiveSource"] = status;`
`112`		`- _parent.Notify(_T("onActiveSourceStatusUpdated"), params);`
	`119`	`+ Exchange::JHdmiCecSource::Event::OnActiveSourceStatusUpdated(_parent, status);`
`113`	`120`	`}`
`114`	`121`	`void StandbyMessageReceived(const int logicalAddress) override`
`115`	`122`	`{`
`116`	`123`	`LOGINFO("StandbyMessageReceived");`
`117`	`124`	`JsonObject params;`
`118`	`125`	`params["logicalAddress"] = logicalAddress;`
`119`		`- _parent.Notify(_T("standbyMessageReceived"), params);`
	`126`	`+ Exchange::JHdmiCecSource::Event::StandbyMessageReceived(_parent, logicalAddress);`
`120`	`127`	`}`
`121`	`128`	`void SendKeyReleaseMsgEvent(const int logicalAddress) override`
`122`	`129`	`{`
`123`	`130`	`LOGINFO("SendKeyReleaseMsgEvent");`
`124`	`131`	`JsonObject params;`
`125`	`132`	`params["logicalAddress"] = logicalAddress;`
`126`		`- _parent.Notify(_T("SendKeyReleaseMsgEvent"), params);`
	`133`	`+ Exchange::JHdmiCecSource::Event::SendKeyReleaseMsgEvent(_parent, logicalAddress);`
`127`	`134`	`}`
`128`	`135`	`void SendKeyPressMsgEvent(const int logicalAddress, const int keyCode) override`
`129`	`136`	`{`
`130`	`137`	`LOGINFO("SendKeyPressMsgEvent");`
`131`	`138`	`JsonObject params;`
`132`	`139`	`params["logicalAddress"] = logicalAddress;`
`133`	`140`	`params["keyCode"] = keyCode;`
`134`		`- _parent.Notify(_T("sendKeyPressMsgEvent"), params);`
	`141`	`+ Exchange::JHdmiCecSource::Event::SendKeyPressMsgEvent(_parent, logicalAddress, keyCode);`
`135`	`142`	`}`
`136`	`143`
`137`	`144`	`private:`