Skip to content

Commit c8d5cfd

Browse files
committed
Merge branch 'release/1.3.2' into main
2 parents ace4f1f + a70cf9a commit c8d5cfd

File tree

5 files changed

+38
-90
lines changed

5 files changed

+38
-90
lines changed

AVOutput/AVOutputTV.cpp

Lines changed: 14 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2203,14 +2203,17 @@ namespace Plugin {
22032203
uint32_t AVOutputTV::getSupportedDolbyVisionModes(const JsonObject& parameters, JsonObject& response)
22042204
{
22052205
LOGINFO("Entry\n");
2206-
tvDolbyMode_t dvModes[tvMode_Max];
2207-
tvDolbyMode_t *dvModesPtr = dvModes; // Pointer to statically allocated tvDolbyMode_t array
2206+
tvDolbyMode_t dvModes[tvMode_Max] = { tvDolbyMode_Invalid };
2207+
tvDolbyMode_t *dvModesPtr[tvMode_Max] = { 0 };
22082208
unsigned short totalAvailable = 0;
2209-
2209+
for (int i = 0; i < tvMode_Max; i++)
2210+
{
2211+
dvModesPtr[i] = &dvModes[i];
2212+
}
22102213
// Set an initial value to indicate the mode type
22112214
dvModes[0] = tvDolbyMode_Dark;
22122215

2213-
tvError_t ret = GetTVSupportedDolbyVisionModes(&dvModesPtr, &totalAvailable);
2216+
tvError_t ret = GetTVSupportedDolbyVisionModes(dvModesPtr, &totalAvailable);
22142217
if(ret != tvERROR_NONE) {
22152218
returnResponse(false);
22162219
}
@@ -2423,9 +2426,14 @@ namespace Plugin {
24232426
uint32_t AVOutputTV::getSupportedPictureModes(const JsonObject& parameters, JsonObject& response)
24242427
{
24252428
LOGINFO("Entry\n");
2426-
pic_modes_t *pictureModes;
2429+
pic_modes_t pictureModes[PIC_MODES_SUPPORTED_MAX];
2430+
pic_modes_t *pictureModesPtr[PIC_MODES_SUPPORTED_MAX]={0};
24272431
unsigned short totalAvailable = 0;
2428-
tvError_t ret = GetTVSupportedPictureModes(&pictureModes,&totalAvailable);
2432+
for (int i = 0; i < PIC_MODES_SUPPORTED_MAX; i++)
2433+
{
2434+
pictureModesPtr[i] = &pictureModes[i];
2435+
}
2436+
tvError_t ret = GetTVSupportedPictureModes(pictureModesPtr,&totalAvailable);
24292437
if(ret != tvERROR_NONE) {
24302438
returnResponse(false);
24312439
}

AVOutput/AVOutputTV.h

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@
2727

2828
#include "tvTypes.h"
2929
#include "tvSettings.h"
30-
#include "tvSettingsExtODM.h"
3130
#include <pthread.h>
3231
#include "Module.h"
3332
#include "tvError.h"
@@ -270,7 +269,6 @@ class AVOutputTV : public AVOutputBase {
270269
private:
271270

272271

273-
tvContentFormatType_t getContentFormatIndex(tvVideoHDRFormat_t formatToConvert);
274272
int getPictureModeIndex(std::string pqmode);
275273
int getSourceIndex(std::string source);
276274
int getFormatIndex(std::string format);
@@ -308,7 +306,6 @@ class AVOutputTV : public AVOutputBase {
308306
string convertSourceIndexToString(int source);
309307
string convertVideoFormatToString(int format);
310308
string convertPictureIndexToString(int pqmode);
311-
tvContentFormatType_t convertFormatStringToTVContentFormat(const char *format);
312309
//std::string convertSourceIndexToString(int sourceIndex);
313310
//std::string convertVideoFormatToString( int formatIndex );
314311
void convertUserScaleBacklightToDriverScale(int format,int * params);
@@ -340,10 +337,8 @@ class AVOutputTV : public AVOutputBase {
340337
int getLocalparam( std::string forParam,paramIndex_t indexInfo,int & value,tvPQParameterIndex_t pqParamIndex,bool sync=false);
341338

342339
tvDataComponentColor_t getComponentColorEnum(std::string colorName);
343-
int getDolbyParams(tvContentFormatType_t format, std::string &s, std::string source = "");
344340
tvError_t getParamsCaps(std::string param, capVectors_t &vecInfo);
345341
int GetPanelID(char *panelid);
346-
int ConvertHDRFormatToContentFormat(tvhdr_type_t hdrFormat);
347342
int ReadCapablitiesFromConf(std::string param, capDetails_t& info);
348343
void getDimmingModeStringFromEnum(int value, std::string &toStore);
349344
void getColorTempStringFromEnum(int value, std::string &toStore);

AVOutput/AVOutputTVHelper.cpp

Lines changed: 8 additions & 79 deletions
Original file line numberDiff line numberDiff line change
@@ -32,36 +32,6 @@ static bool m_isDalsEnabled = false;
3232
namespace WPEFramework {
3333
namespace Plugin {
3434

35-
tvContentFormatType_t AVOutputTV::getContentFormatIndex(tvVideoHDRFormat_t formatToConvert)
36-
{
37-
/* default to SDR always*/
38-
tvContentFormatType_t ret = tvContentFormatType_NONE;
39-
switch(formatToConvert) {
40-
case tvVideoHDRFormat_HLG:
41-
ret = tvContentFormatType_HLG;
42-
break;
43-
44-
case tvVideoHDRFormat_HDR10:
45-
ret = tvContentFormatType_HDR10;
46-
break;
47-
48-
case tvVideoHDRFormat_HDR10PLUS:
49-
ret = tvContentFormatType_HDR10PLUS;
50-
break;
51-
52-
case tvVideoHDRFormat_DV:
53-
ret = tvContentFormatType_DOVI;
54-
break;
55-
56-
case tvVideoHDRFormat_SDR:
57-
case tvVideoHDRFormat_NONE:
58-
default:
59-
ret = tvContentFormatType_SDR;
60-
break;
61-
}
62-
return ret;
63-
}
64-
6535
int AVOutputTV::getPictureModeIndex(std::string pqparam)
6636
{
6737
int index = -1;
@@ -265,14 +235,19 @@ namespace Plugin {
265235
int AVOutputTV::getDolbyModeIndex(const char * dolbyMode)
266236
{
267237
int mode = 0;
268-
tvDolbyMode_t dolbyModes[tvMode_Max];
269-
tvDolbyMode_t *dolbyModesPtr = dolbyModes; // Pointer to statically allocated tvDolbyMode_t array
238+
tvDolbyMode_t dolbyModes[tvMode_Max] = { tvDolbyMode_Invalid };
239+
tvDolbyMode_t *dolbyModesPtr[tvMode_Max] = { 0 };
270240
unsigned short totalAvailable = 0;
271241

242+
for (int i = 0; i < tvMode_Max; i++)
243+
{
244+
dolbyModesPtr[i] = &dolbyModes[i];
245+
}
246+
272247
// Set an initial value to indicate the mode type
273248
dolbyModes[0] = tvDolbyMode_Dark;
274249

275-
tvError_t ret = GetTVSupportedDolbyVisionModes(&dolbyModesPtr, &totalAvailable);
250+
tvError_t ret = GetTVSupportedDolbyVisionModes(dolbyModesPtr, &totalAvailable);
276251
if (ret == tvERROR_NONE) {
277252
for (int count = 0; count < totalAvailable; count++) {
278253
if(strncasecmp(dolbyMode, getDolbyModeStringFromEnum(dolbyModes[count]).c_str(), strlen(dolbyMode))==0) {
@@ -925,26 +900,6 @@ namespace Plugin {
925900
return ret;
926901
}
927902

928-
tvContentFormatType_t AVOutputTV::convertFormatStringToTVContentFormat(const char *format)
929-
{
930-
tvContentFormatType_t ret = tvContentFormatType_SDR;
931-
932-
if( strncmp(format,"sdr",strlen(format)) == 0 || strncmp(format,"SDR",strlen(format)) == 0 ) {
933-
ret = tvContentFormatType_SDR;
934-
}
935-
else if( strncmp(format,"hdr10",strlen(format)) == 0 || strncmp(format,"HDR10",strlen(format))==0 ) {
936-
ret = tvContentFormatType_HDR10;
937-
}
938-
else if( strncmp(format,"hlg",strlen(format)) == 0 || strncmp(format,"HLG",strlen(format)) == 0 ) {
939-
ret = tvContentFormatType_HLG;
940-
}
941-
else if( strncmp(format,"dolby",strlen(format)) == 0 || strncmp(format,"DOLBY",strlen(format)) == 0 ) {
942-
ret=tvContentFormatType_DOVI;
943-
}
944-
945-
return ret;
946-
}
947-
948903
tvError_t AVOutputTV::updateAVoutputTVParamToHAL(std::string forParam, paramIndex_t indexInfo, int value,bool setNotDelete)
949904
{
950905
tvError_t ret = tvERROR_NONE;
@@ -1654,32 +1609,6 @@ namespace Plugin {
16541609
return 0;
16551610
}
16561611

1657-
int AVOutputTV::ConvertHDRFormatToContentFormat(tvhdr_type_t hdrFormat)
1658-
{
1659-
int ret=tvContentFormatType_SDR;
1660-
switch(hdrFormat)
1661-
{
1662-
case HDR_TYPE_SDR:
1663-
ret=tvContentFormatType_SDR;
1664-
break;
1665-
case HDR_TYPE_HDR10:
1666-
ret=tvContentFormatType_HDR10;
1667-
break;
1668-
case HDR_TYPE_HDR10PLUS:
1669-
ret=tvContentFormatType_HDR10PLUS;
1670-
break;
1671-
case HDR_TYPE_DOVI:
1672-
ret=tvContentFormatType_DOVI;
1673-
break;
1674-
case HDR_TYPE_HLG:
1675-
ret=tvContentFormatType_HLG;
1676-
break;
1677-
default:
1678-
break;
1679-
}
1680-
return ret;
1681-
}
1682-
16831612
void AVOutputTV::getDimmingModeStringFromEnum(int value, std::string &toStore)
16841613
{
16851614
const char *color_temp_string[] = {

AVOutput/CHANGELOG.md

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,14 @@ All notable changes to this RDK Service will be documented in this file.
1414

1515
* Changes in CHANGELOG should be updated when commits are added to the main or release branches. There should be one CHANGELOG entry per JIRA Ticket. This is not enforced on sprint branches since there could be multiple changes for the same JIRA ticket during development.
1616

17+
## [1.1.2] - 2025-07-01
18+
### Fixed
19+
- Phase2 ODM
20+
21+
## [1.1.1] - 2025-06-26
22+
### Fixed
23+
- Fixed dimmingMode failures
24+
1725
## [1.1.0] - 2025-03-14
1826
### Added
1927
- Add additional features on AVOutput

CHANGELOG.md

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,18 @@ All notable changes to this project will be documented in this file. Dates are d
44

55
Generated by [`auto-changelog`](https://github.com/CookPete/auto-changelog).
66

7+
#### [1.3.2](https://github.com/rdkcentral/entservices-inputoutput/compare/1.3.1...1.3.2)
8+
9+
- RDKEMW-5510: Integrate the ODM Phase 2 middleware changes into RDKE [`#160`](https://github.com/rdkcentral/entservices-inputoutput/pull/160)
10+
- Merge tag '1.3.1' into develop [`8083548`](https://github.com/rdkcentral/entservices-inputoutput/commit/808354842ca703cbcd49d04ee6ceeca5911d1653)
11+
712
#### [1.3.1](https://github.com/rdkcentral/entservices-inputoutput/compare/1.3.0...1.3.1)
813

14+
> 26 June 2025
15+
916
- RDKEMW-5512: Implement a fix for the SaveTVDimmingMode failure [`#157`](https://github.com/rdkcentral/entservices-inputoutput/pull/157)
1017
- RDKEMW-1015 - Update gtest [`#155`](https://github.com/rdkcentral/entservices-inputoutput/pull/155)
18+
- 1.3.1 release changelog updates [`88527ce`](https://github.com/rdkcentral/entservices-inputoutput/commit/88527cedd22c2ca3d58c8b625ed9f90ba1128066)
1119
- Merge tag '1.3.0' into develop [`2499e0b`](https://github.com/rdkcentral/entservices-inputoutput/commit/2499e0b71c2fbb9e9a303a342fbc4965da5b52c9)
1220

1321
#### [1.3.0](https://github.com/rdkcentral/entservices-inputoutput/compare/1.2.0...1.3.0)

0 commit comments

Comments
 (0)