From f02d42ee0a21ef7e601b37f25eec59d1418709c5 Mon Sep 17 00:00:00 2001 From: tabbas651 Date: Fri, 6 Jun 2025 19:00:12 +0000 Subject: [PATCH 1/2] RDKEMW-3750 : Upgrade Thunder to Version R4.4.3 Reason for change: AddRef return type got changed in R4.4.3 , modified the changes in RustAdapter pligin Test Procedure: please referred ticket descriptions Risks: Medium Priority: P1 Signed-off-by: Thamim Razith --- AVOutput/AVOutput.h | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/AVOutput/AVOutput.h b/AVOutput/AVOutput.h index fb260ada..1cab0496 100644 --- a/AVOutput/AVOutput.h +++ b/AVOutput/AVOutput.h @@ -60,7 +60,11 @@ namespace Plugin { const std::string Initialize(PluginHost::IShell* service); void Deinitialize(PluginHost::IShell* service); virtual string Information() const override { return {}; } +#if ((THUNDER_VERSION >= 4) && (THUNDER_VERSION_MINOR == 4) && (THUNDER_VERSION_PATCH == 3)) + virtual uint32_t AddRef() const {return 0; } +#else virtual void AddRef() const { } +#endif virtual uint32_t Release() const {return 0; } BEGIN_INTERFACE_MAP(AVOutput) INTERFACE_ENTRY(PluginHost::IPlugin) From bfe49adb33c6506c8c346a41f55f4618562e6ec1 Mon Sep 17 00:00:00 2001 From: tabbas651 Date: Wed, 11 Jun 2025 14:43:56 +0000 Subject: [PATCH 2/2] Removed the AddRef and release which not in use --- AVOutput/AVOutput.h | 6 ------ 1 file changed, 6 deletions(-) diff --git a/AVOutput/AVOutput.h b/AVOutput/AVOutput.h index 1cab0496..13536705 100644 --- a/AVOutput/AVOutput.h +++ b/AVOutput/AVOutput.h @@ -60,12 +60,6 @@ namespace Plugin { const std::string Initialize(PluginHost::IShell* service); void Deinitialize(PluginHost::IShell* service); virtual string Information() const override { return {}; } -#if ((THUNDER_VERSION >= 4) && (THUNDER_VERSION_MINOR == 4) && (THUNDER_VERSION_PATCH == 3)) - virtual uint32_t AddRef() const {return 0; } -#else - virtual void AddRef() const { } -#endif - virtual uint32_t Release() const {return 0; } BEGIN_INTERFACE_MAP(AVOutput) INTERFACE_ENTRY(PluginHost::IPlugin) INTERFACE_ENTRY(PluginHost::IDispatcher)