From 7c9ad94be6b776b159f0fc2c23db035666e5c9d4 Mon Sep 17 00:00:00 2001
From: benjaminqcox <benjaminqcox@gmail.com>
Date: Wed, 9 Apr 2025 11:49:14 +0100
Subject: [PATCH 1/2] RDKTV-35711: Set dimming mode fails

---
 AVOutput/AVOutputTVHelper.cpp | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)

diff --git a/AVOutput/AVOutputTVHelper.cpp b/AVOutput/AVOutputTVHelper.cpp
index 7e3b28c5..cc401a7a 100644
--- a/AVOutput/AVOutputTVHelper.cpp
+++ b/AVOutput/AVOutputTVHelper.cpp
@@ -321,13 +321,13 @@ namespace Plugin {
     {
         tvDimmingMode_t index = tvDimmingMode_MAX;
 
-        if(mode.compare("local") == 0 ) {
+        if(mode.compare("Local") == 0 ) {
             index=tvDimmingMode_Local;
 	}
-        else if(mode.compare("fixed") == 0 ) {
+        else if(mode.compare("Fixed") == 0 ) {
             index=tvDimmingMode_Fixed;
 	}
-        else if(mode.compare("global") == 0 ) {
+        else if(mode.compare("Global") == 0 ) {
             index=tvDimmingMode_Global;
 	}
         else {
@@ -1514,13 +1514,13 @@ namespace Plugin {
                 return 0;
             }
            else if( forParam.compare("DimmingMode") == 0 ) {
-               if (strncmp(param.value, "fixed", strlen(param.value))==0) {
+               if (strncmp(param.value, "Fixed", strlen(param.value))==0) {
                    value=tvDimmingMode_Fixed;
 	           }
-               else if (strncmp(param.value, "local", strlen(param.value))==0) {
+               else if (strncmp(param.value, "Local", strlen(param.value))==0) {
                    value=tvDimmingMode_Local;
 	           }
-               else if (strncmp(param.value, "global", strlen(param.value))==0) {
+               else if (strncmp(param.value, "Global", strlen(param.value))==0) {
                    value=tvDimmingMode_Global;
 	           }
                return 0;
@@ -1683,9 +1683,9 @@ namespace Plugin {
     void AVOutputTV::getDimmingModeStringFromEnum(int value, std::string &toStore)
     {
         const char *color_temp_string[] = {
-                    [tvDimmingMode_Fixed] = "fixed",
-                    [tvDimmingMode_Local] = "local",
-                    [tvDimmingMode_Global] = "global",
+                    [tvDimmingMode_Fixed] = "Fixed",
+                    [tvDimmingMode_Local] = "Local",
+                    [tvDimmingMode_Global] = "Global",
                 };
         toStore.clear();
         toStore+=color_temp_string[value];

From 31f68179c73189553d26aff7185a44475db84280 Mon Sep 17 00:00:00 2001
From: arjunbinu <51983664+arjunbinu@users.noreply.github.com>
Date: Thu, 12 Jun 2025 15:43:37 +0100
Subject: [PATCH 2/2] Added debug prints

---
 AVOutput/.AVOutputTV.cpp.swp  | Bin 0 -> 20480 bytes
 AVOutput/AVOutputTV.cpp       |   4 +++-
 AVOutput/AVOutputTVHelper.cpp |   2 +-
 3 files changed, 4 insertions(+), 2 deletions(-)
 create mode 100644 AVOutput/.AVOutputTV.cpp.swp

diff --git a/AVOutput/.AVOutputTV.cpp.swp b/AVOutput/.AVOutputTV.cpp.swp
new file mode 100644
index 0000000000000000000000000000000000000000..e3032208d8f74a1fa6ef987bfa4feaf7ef501950
GIT binary patch
literal 20480
zcmeI4dyrdI9mk`kNQ($l{!kS3G)ysBw%P5rBQ<4<=_b3Ic9Sg0ZjhEvxSO18Za29%
z+<UXz1s4affbT&%DxiaZIHF^5MnD+&1JqIe5EPsdTe0$fh{!{ED3piabM860k9}|3
zVbo;i(`4`OoZmU;cb>oBxiHe1Po~JmNLK)#lLCPo_iwFKZvMovd-ik%l##~zjT@L?
z?$5}?+6pyl)SNq6;8I&*2h}W-8sln_nrl_9-mvtBg?~F@`Hc6+P(D(u*XPmN61ObS
zvcS9+XjtX78&4Qs-?grjr9C~knw-39c;0NS1T71+EYPw*%K|M6v@FoFK+6Ix3$!fo
zzheQb9u9mS&3V6Qk|n<1=lgzFe2U_E!zX`7$a}@}13vlNLcU%+|F|eXmh+a7?-25H
zeey#>evy#x^U2>7@?AoHnrM*J|Avs4g#0R>{NF;Z2>J6q`M-p`BIE<h>>pD9>q4#y
z`E5S=YrgVNJI0&;RUt2n{FnLUuL${=kU#5_|5M1RkY|^B_5Z^szr!bgS;#e!|I}l>
z`Ck%pY2PpT<Sz=jtpBS%`3t`Cw|~H^Uo<Bm?SGF?{=6^$>f^lm|K=<IN}v2WA-~Yh
z7WlhQ{#PNd3HiVZul{F+T=wssKKV03zE$K8uJq=ATF6sEUiHbJ67ma${7#?zNuT_b
z<GuQy5OUf7lRo+5LN4dmBR=_KLS7Q(fBJ)7{f`Ryh>(BRCx1l9<@|WpC;y92|L6%`
z{Rf3y*6%)_{LezZQ<Q(khrIb87V@f)U*VJgNyz2+ddVk0AmrU5|KN#U{o--!t7U<f
z1zHwpS)gTsmIYcCXj!0Tf&Xd?C^+ylANB?I5AOe^|Nl15zdr?6fjxkNB3KO`!P)sX
za0}Q2*jc+9yn!?OPe29qfjH;^>%b}C{oqCT1uuXH!0$i`41hMU92^6lhi`HK><2f2
zAAk%<f@8rS;2ZrCd<*OaUjttSQLq8L4BzZ-un$}YE(N>61o#M81#W}?cR8qoZV&|<
zz<RJBzUS}3)gTYz;AC(TSP52uU%|h<8+;F32}VE{SOpHjw|)lv4D1C{zyRC95Xgb$
z;9WSq2f#hxJK$na1e?J}!7}hL;t02Z8^CUm2j_s(z*~q>JPjTMH-m42uYe-h3gVy#
z@V;fEl;C4pilr9uRf<MU%TTpZGD@wyTB3TEntHWisk$~aS*JsKj*COqxFZ-;45e1E
zh|x?Mw$)B?<*WdMS`9-(0Y+Y_Ht43nih)dDGToaA1$il?S2t>k6<uRqpat8T>B5_u
z8XR3rAN!0LR2g#;*biA->@r9<38pjYM9`b0M9WH}YDEJwz5HH)x_I8Ftf-ij<dgA4
zrqG+oreZ^dcz#Km`v>~wRgE-D(;d&Q>l_>y&dpzfOu6)O7FNcR^ylK)d9@>rquZQN
ztzsoq=0ht?E@^goQP)h16f25B+GZIpc49Fv-09`Kum`MfPVlkpNH8Zv;j_$#a;=uq
zOPCIF5KfWiPx)w;aVfH5l$VvN=~5x{H78h)u331yim<vy37Zm_W3HLSGAwphIHg+#
zo6fRO`8`YFy{XjnviT&k#zi$*Eel9DtsBt^tQqcp9MSbEajN1ngs1y>GTCpgVqA-v
z>nS=-7A1Ra#Z+JgYneW>YwhN=ZmH!-yQi`4(X3+8o{FN4(ok9c?Xs>~4k4Sn*7A+E
zp*(4W2t62bKMFVS9$Z|p6vwJfYg*$omD{gqr7AVVSc|SH5w?i>E8{WAxUQDSoZ7I$
zd&^>jS+=j8a0P9$s?GI&HcL61g)o(CuW;IVG;HNBSsKf!01U?L<vfTuKlyGYdUI9-
z&QioYd*otl*sE4+DP@crY_$*;tl{U;8)q|=C@m*uha6|Fddy^@*%iS)-f71)EygOY
z)mBbGd#OLVBg$Ui?GmL;>}6h>L@fGtHD)r(w3-V&%}K}G!Iwh0h0J0YXXR)k&hKbc
z#SW)vMT*r$YgDUs%h(hMXjrbyx`L;J)yAl*VM}x#oi~{1W%GMNH^v|ch`o<5p0$E%
z#<9&LG-aepOU|a_PE>Xe(&n}lI30V7s!<#PM^)3p5T;f|FNGqJNSLiyB-BtfYa><{
z6>8UQB7M}7)=<Nnh<fIkVehlGo3ldI*;`Fr%Z%)zMXQ}Szc+^pg?y|K%l7381uRXn
z23v-EdlT70F1bCy_o>jju8mBrYQ<`!L`l#n7nQmisRUimhAp*fCKaRReeBrU^ZaZa
zCvbY+4Bw?A&_=3iO=U-GoHs~AD`AbcDwGW1C1=f~5hTb_>VCux!jhPET2#w8l2@^@
zG?Y<FM)h%OXzXNO$7|K9X>z4l`Jv^!<WPTRc!-=A%VuNgp=2UQGFj4-Nyn2z$xIr5
z^^#cne6lT>j<*x4q6CA`-F2*UCP5ddwR%;hC03yl`p8g68WwtaT8)WndJ^awQ8W^a
z<w!CYBwJ#+WUd`LhP5hFY|x7ussTMClSHYbgd!U}Xwd{KQyDcVWR^}a4krxNLep^Y
z*UQ#~V$eVv^i(XX9_{Fun3#wt7_}7|(T&j#=wa3~I|h<HiF7Wpwky)flb^3QNKKi<
zE^R5$sbCwg<FB&Ez={RMlOm<2TLfDe5};uiz7$3&(mIBshRn<;d<x+hS#c|2b`pK)
zHd2h&QA*lLo*Jx^2<k^dtW$#`6FYpd_Vu8ChB{iYNLOdq29k|$BPm5gXV-Af;VH^`
zwW?3BPG@bg)1u2Uu524{yG}--D_JJ2HEce@sygf82^CF4OPtoh?EDYbHeEv@pEQZE
zqTPIC3v{#vnE%i2YL9{6%lv<N|Mfcj{MW$sU@zDWHiK^P4t)KC;3n_|a4{GICxd(8
z<9{Dq5B7p<!8bq$2!rFnO7I~3d=>+^0h|vqAPqVJiv@(iGVnJ1{fEFEU@vHZ=iuXK
zKmu$A8^KxNM6d!px*`zx1-K4;9n`@yXkQw{0rU6I0-pjwa2#OmUj|yAmIYcCXj!0T
zftCgSUo6nkF%_8V=$P3*@JeiFLIz7tr&>uZ2lxpa|9IoJ$yhd3=;=@NYzq<odrQMC
zWN8hD+r&5yB=Y2M%Z77>crMkKEu>?qM7!@<BA-YP75d|;WFeU@*g@D-CY~q^55{9d
ziFQ&l`%5*IyIRa`cIyulm*>oCderKb8;T7L=VWDaIG#1k`D=oR0%FwgiEu)9oLSqG
zWYty6B*Yz)Xq43)?w$!(T7w@%OQCQW?n{}hw*9UW2{9YNL>smhwr4V_aDZuGAL+wv
zK@>Y0jZ;;_DO{<l7gMG*<OzH5c#q65l%Fa2;S2!VHFO&$<m>MDY6u*OnjOhOFum*1
zYv^;h>`UqO<YM~VpIG*|J)Gn%4+by13zLReXc&ViAjRIL07IK6+Yu}_3<GoD6Di8+
z4FmrvaBwGr0tO4N#tcK5bmjsx146nza12M(s%lNz8A49lFzN0loy;!H3d~(3FUu3e
zaMhhf7kCw>)yAHcEQqnb3p3U|M`nmQhY&r(-GdXXAZL&|yFa4{jhOBz1_ZLcVQf0g
zh>iiBU+lSkyXLn$lgLjqf}Gf`TG8g^o^3S3;#RmgYZPH|lLwE9=o34EZ?TlsYW5so
zW9_8eh-f2%6_))ZiMYq^W~hBOy%cvC=qg#?IorqM{EMxV|1J=*W|)nv?nW3qk<DhX
z$>3(h9jC{0!_W=B3R@V42u$_ZBh}U3&>8*~HQOKp=sBY(0(qX4P-yR2xy*33Cs9Za
zI)mHkEzL3}og0${3^m*4(?*$RkU4|TGsKwfr`SK-|BqwLJtgk{6>;df3x0kLM8K)w
zN%-~;fonh<EC;W^kG~7-1MJTKW8ffs_TPYOz!jhbwt$VG3#<e8!-u~Y>;pdrUj}0!
z4N~9`eE8eJwcv~3YOn>o2|s>6_${~}+y``!2OGdj@Bn=HZ-XiDIgkY(29M#+{@3i@
z9$W`@f;C_zVE6fl5Cgd#>;>%I_DjHLK^pXfKJWzY><@yUgL}Y@;Bs&Qh=I?5Cva!K
z3#cFr{)l_}TfvXO1Q-Wvz(cr~zXkjd+yvO2{VMPh`r&E7`r}scIPia1$Fa{sXHI~p
zUPK0&o?vuh!i0ir%qZdOFI#?lDzrF;t4IXVN<4}gS8Fu{uGq<o-L8;Ap?5gl!@`k>
z$vQ(F(~zvj>4mN1O+AB(Y2qM5f-WUN(vDyj{*Mqzt*jHi-yNAI^xAbsAQI~^4+gTR
z844nbG1_3EII$$o+5!?{Inmf0MeUF?CNi?;&6VBLnD%B<!fXlhZc`=4bXX;@iMY(b
zSJTiqdx^qj#f5hIjD478+be-ewZuc!OX@|!>ckXKZh=AB@Q}CJcEz10JFkJT(Uhf#
zJ=1ZFAXkf7%^JA47O#f5djWSMwjt~dFj?ls;)1qUN9@{deNQc1hU58RWT&Gd{farD
zjL@pL=3#P<E71;*zMYYr{ZdSrL`g8{IyJaosNqF91K+>9xOX8Z6;2h1xHo4KYTD@t
zaaj?kh;>&@c6%b{hO77`>?0<%wkXB1Dho@yI$`b&#dVySzN0K{mM-QzAkLZ1!HpkI
z%W>X8ueh2*@?t#M*W_;Vx&{VQHszcg-MVLaA%i7xPDZW*`H?6%TGdCCDh7vJmHgeT
zt}C0YXCKe#90Ft>_AOqWaOEo4$)iWI>Q%kCq?!+~d<(8PPklt|T~>F~(h@A*%knL_
z-aNJQwhHSO@#0a*nYiwACEN0-VQ}|^cm$a2T)@_RZVtXIc^4w=95_$2O|adiznu)8
zTNsRGW2r(snMx(oeJm7$@$8I)!`dTIA-=Zq?MH49*fR0l_7~jCvTGU%H_gdAtubOp
zcbdihwzca#j@we|Zogf~wiW*lFZcDi&n3-Wy>H>Wy0Z$;u&vLzmh+zG*5zxt=wfHJ
zSmatS-|xC4z{cZj&gpxy($BYAPoH?+-e(PR*4c6Pj;j4e2AdPXo!$1!7rt--%fvp@
zRk5e8ERk5L6jGrnVn56yrluP^_@vwE8rUow`ydrTdh{3Hn=t^`&$IFEQxP!{S3^wA
zPQhMku=~bVV~6yn7aS=Yc<l}0od~<L#l?6isNv=|=nOBJpM6hnozGCxBj<)Pd5C3E
zhH_<b3}rt&EJL|fEZk6@Tu01Mb+w3hl__&v#E7b2#NJF=l%ZT%97EX;56e()6$>(y
OJ)}I@=C%|Ym;V6``?dA}

literal 0
HcmV?d00001

diff --git a/AVOutput/AVOutputTV.cpp b/AVOutput/AVOutputTV.cpp
index e95b81e7..daa21ec4 100644
--- a/AVOutput/AVOutputTV.cpp
+++ b/AVOutput/AVOutputTV.cpp
@@ -2059,13 +2059,15 @@ namespace Plugin {
         std::string value;
 
         value = parameters.HasLabel("DimmingMode") ? parameters["DimmingMode"].String() : "";
-        returnIfParamNotFound(parameters,"DimmingMode");
+	LOGINFO("%s: DimmingMode [value]: %s\n", __FUNCTION__, value);
+	returnIfParamNotFound(parameters,"DimmingMode");
 
         if (validateInputParameter("DimmingMode",value) != 0) {
             LOGERR("%s: Range validation failed for DimmingMode\n", __FUNCTION__);
             returnResponse(false);
         }
         dimmingMode = getDimmingModeIndex(value);
+	LOGINFO("%s: dimmingMode : %d\n", __FUNCTION__, dimmingMode);
 
         if (parsingSetInputArgument(parameters, "DimmingMode",inputInfo) != 0) {
             LOGERR("%s: Failed to parse the input arguments \n", __FUNCTION__);
diff --git a/AVOutput/AVOutputTVHelper.cpp b/AVOutput/AVOutputTVHelper.cpp
index cc401a7a..02328607 100644
--- a/AVOutput/AVOutputTVHelper.cpp
+++ b/AVOutput/AVOutputTVHelper.cpp
@@ -320,7 +320,7 @@ namespace Plugin {
     tvDimmingMode_t AVOutputTV::getDimmingModeIndex(std::string mode)
     {
         tvDimmingMode_t index = tvDimmingMode_MAX;
-
+	LOGINFO("mode =%s!!!\n",mode);
         if(mode.compare("Local") == 0 ) {
             index=tvDimmingMode_Local;
 	}