feat: Device.chipsetId (#476)

Author: damcav64

src/cpp/include/device.h

@@ -65,6 +65,13 @@ class IDevice
      */
     virtual Result<u_int32_t> timeInActiveState() const = 0;
 
+    /**
+     * @brief Returns chipset ID as a printable string, e.g. "BCM72180"
+     *
+     * @retval The uid string or error
+     */
+    virtual Result<std::string> chipsetId() const = 0;
+
     /**
      * @brief Returns a persistent unique UUID for the current app and device.  The UUID is reset when the app or device is reset
      *

src/cpp/src/device_impl.cpp

@@ -42,6 +42,11 @@ Result<uint32_t> DeviceImpl::uptime() const
     return helper_.get<Firebolt::JSON::Integer, uint32_t>("Device.uptime");
 }
 
+Result<std::string> DeviceImpl::chipsetId() const
+{
+    return helper_.get<Firebolt::JSON::String, std::string>("Device.chipsetId");
+}
+
 Result<std::string> DeviceImpl::uid() const
 {
     return helper_.get<Firebolt::JSON::String, std::string>("Device.uid");

src/cpp/src/device_impl.h

@@ -36,6 +36,7 @@ class DeviceImpl : public IDevice
     Result<DeviceClass> deviceClass() const override;
     Result<uint32_t> uptime() const override;
     Result<u_int32_t> timeInActiveState() const override;
+    Result<std::string> chipsetId() const override;
     Result<std::string> uid() const override;
 
 private:

src/cpp/test/component/deviceTest.cpp

@@ -69,6 +69,14 @@ TEST_F(DeviceTest, TimeInActiveState)
     EXPECT_EQ(*result, expectedValue);
 }
 
+TEST_F(DeviceTest, ChipsetId)
+{
+    auto expectedValue = jsonEngine.get_value("Device.chipsetId");
+    auto result = Firebolt::IFireboltAccessor::Instance().DeviceInterface().chipsetId();
+    ASSERT_TRUE(result) << "DeviceImpl::chipsetId() returned an error";
+    EXPECT_EQ(*result, expectedValue);
+}
+
 TEST_F(DeviceTest, Uid)
 {
     auto expectedValue = jsonEngine.get_value("Device.uid");

src/cpp/test/unit/deviceTest.cpp

@@ -62,6 +62,17 @@ TEST_F(DeviceTest, Uptime)
     EXPECT_EQ(*result, expectedValue);
 }
 
+TEST_F(DeviceTest, ChipsetId)
+{
+    mock("Device.chipsetId");
+    auto expectedValue = jsonEngine.get_value("Device.chipsetId");
+
+    auto result = deviceImpl_.chipsetId();
+    ASSERT_TRUE(result) << "DeviceImpl::chipsetId() returned an error";
+
+    EXPECT_EQ(*result, expectedValue);
+}
+
 TEST_F(DeviceTest, Uid)
 {
     mock("Device.uid");