Skip to content

fix: Disable so-version#32

Merged
tomasz-blasz merged 1 commit intomainfrom
topic/so-versioning
Mar 16, 2026
Merged

fix: Disable so-version#32
tomasz-blasz merged 1 commit intomainfrom
topic/so-versioning

Conversation

@tomasz-blasz
Copy link
Contributor

Needed for Prime integration

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request disables the SONAME (shared object version name) in the FireboltClient shared library to support Prime integration. The change affects how the library is versioned at the system level, removing the symbolic links typically created with versioned shared libraries.

Changes:

  • Replace SOVERSION property with NO_SONAME in CMake configuration
  • Add changelog entry for the unreleased version documenting this change

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
src/CMakeLists.txt Removes SOVERSION and sets NO_SONAME property to disable shared library versioning
CHANGELOG.md Adds Unreleased section with entry documenting the SONAME removal and removes dates from version headers

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@tomasz-blasz tomasz-blasz marked this pull request as draft February 17, 2026 13:01
@tomasz-blasz tomasz-blasz changed the title build: Disable so-version fix: Disable so-version Mar 16, 2026
@tomasz-blasz tomasz-blasz marked this pull request as ready for review March 16, 2026 09:06
Copilot AI review requested due to automatic review settings March 16, 2026 09:06
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings March 16, 2026 09:28
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@tomasz-blasz tomasz-blasz merged commit 51cdabf into main Mar 16, 2026
12 checks passed
@tomasz-blasz tomasz-blasz deleted the topic/so-versioning branch March 16, 2026 10:21
@github-actions github-actions bot locked and limited conversation to collaborators Mar 16, 2026
@tomasz-blasz
Copy link
Contributor Author

🎉 This PR is included in version 0.5.5 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants