From 4c79650c78d8aea1d58390082a89f8de89f58862 Mon Sep 17 00:00:00 2001 From: Keaton Sentak Date: Tue, 15 Apr 2025 11:07:57 -0400 Subject: [PATCH 1/2] fix: Add RPCv2 endpoint to ws connection --- languages/javascript/src/shared/Transport/index.mjs | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/languages/javascript/src/shared/Transport/index.mjs b/languages/javascript/src/shared/Transport/index.mjs index d400b4ac..4939fcdd 100644 --- a/languages/javascript/src/shared/Transport/index.mjs +++ b/languages/javascript/src/shared/Transport/index.mjs @@ -56,7 +56,12 @@ function getImplementation() { implementation = win.__firebolt.transport } else if (win.__firebolt.endpoint) { - implementation = new WebsocketTransport(win.__firebolt.endpoint) + // Only adds RPCv2=true query parameter when using bidirectional SDK. + // This parameter will not be present when using unidirectional SDK. + // Unidirectional endpoint is handled in Gateway/Unidirectional.mjs + const endpoint = win.__firebolt.endpoint + const url = endpoint + (endpoing.includes('?') ? '&' : '?') + 'RPCv2=true' + implementation = new WebsocketTransport(url) } else { implementation = MockTransport From f96846af098fa65ca67c7c14f2bb3b2739e69a65 Mon Sep 17 00:00:00 2001 From: Keaton Sentak Date: Wed, 16 Apr 2025 08:48:18 -0400 Subject: [PATCH 2/2] fix: Spelling error --- languages/javascript/src/shared/Transport/index.mjs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/languages/javascript/src/shared/Transport/index.mjs b/languages/javascript/src/shared/Transport/index.mjs index 4939fcdd..47f78df3 100644 --- a/languages/javascript/src/shared/Transport/index.mjs +++ b/languages/javascript/src/shared/Transport/index.mjs @@ -60,7 +60,7 @@ function getImplementation() { // This parameter will not be present when using unidirectional SDK. // Unidirectional endpoint is handled in Gateway/Unidirectional.mjs const endpoint = win.__firebolt.endpoint - const url = endpoint + (endpoing.includes('?') ? '&' : '?') + 'RPCv2=true' + const url = endpoint + (endpoint.includes('?') ? '&' : '?') + 'RPCv2=true' implementation = new WebsocketTransport(url) } else {